Stefan Tauner has posted comments on this change. ( https://review.coreboot.org/25683 )
Change subject: Add support for National Instruments USB-845x devices
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/#/c/25683/10/ni845x_spi.c
File ni845x_spi.c:
https://review.coreboot.org/#/c/25683/10/ni845x_spi.c@123
PS10, Line 123: %ld
This is not the standard-compliant format specifier for int32. You include inttypes.h already, please use it (everywhere...).
--
To view, visit
https://review.coreboot.org/25683
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549
Gerrit-Change-Number: 25683
Gerrit-PatchSet: 10
Gerrit-Owner: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes HAOUAS
ehaouas@noos.fr
Gerrit-CC: Márton Miklós
martonmiklosqdev@gmail.com
Gerrit-CC: Stefan Tauner
stefan.tauner@gmx.at
Gerrit-Comment-Date: Mon, 27 Aug 2018 00:17:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No