Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Georg Gottleuber has posted comments on this change by Georg Gottleuber. ( https://review.coreboot.org/c/flashrom/+/82101?usp=email )
Change subject: flashchips.c: Add support for XM25RU256C
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
I double-checked with the datasheet: looks good. Only one additional ".block_erase" mode with code 0x21 is mentioned, but I am unsure how to add it (SPI_BLOCK_ERASE_21).
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/82101/comment/992bc5be_306fd6c6?usp... :
PS2, Line 21729: | FEATURE_4BA_EAR_C5C8 | FEATURE_4BA_READ | FEATURE_4BA_FAST_READ
: | FEATURE_4BA_WRITE,
Sorry I didn't notice last time: please intend these two lines so that they align with the first fea […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/82101?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I431474a662304d09438e274706d3fc9cfbbe0bd6
Gerrit-Change-Number: 82101
Gerrit-PatchSet: 3
Gerrit-Owner: Georg Gottleuber
ggo@tuxedo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Tue, 28 May 2024 10:57:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
