Ryan O'Leary has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/36946 )
Change subject: Fix a handful of compiler warnings ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/flashrom/+/36946/2/util/ich_descriptors_tool/i... File util/ich_descriptors_tool/ich_descriptors_tool.c:
https://review.coreboot.org/c/flashrom/+/36946/2/util/ich_descriptors_tool/i... PS2, Line 155: struct ich_descriptors desc = { 0 };
It looks like gcc and clang support a feature (possibly an extension to the language) where you use […]
Ron suggested using static which works well.
https://review.coreboot.org/c/flashrom/+/36946/6/util/ich_descriptors_tool/i... File util/ich_descriptors_tool/ich_descriptors_tool.c:
https://review.coreboot.org/c/flashrom/+/36946/6/util/ich_descriptors_tool/i... PS6, Line 155: struct ich_descriptors desc = { };
if it needs to be zero, and it is an auto, just put an explicit memset. […]
Thanks! static worked well.