Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44621 )
Change subject: allow 0x34 as ICCRIBA for CHIPSET_C620_SERIES_LEWISBURG ......................................................................
Patch Set 7: Code-Review+2
(3 comments)
https://review.coreboot.org/c/flashrom/+/44621/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/44621/4//COMMIT_MSG@13 PS4, Line 13: Print status info for read_ich_descriptors_from_dump().
I did add this code change in layout_from_ich_descriptors(). […]
Ack
https://review.coreboot.org/c/flashrom/+/44621/1/ich_descriptors.c File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/44621/1/ich_descriptors.c@1248 PS1, Line 1248: "__FUNC__, __LINE__ Failed with value %d.\n", ret
The problem is that when read_ich_descriptors_from_dump() returns non-successful status, layout_from […]
Ack
https://review.coreboot.org/c/flashrom/+/44621/2/ich_descriptors.c File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/44621/2/ich_descriptors.c@a943 PS2, Line 943: return CHIPSET_300_SERIES_CANNON_POINT;
The C621A PCH (used in DeltaLake DVT server) has ICCRIBA as 0x34 and NM as 6. […]
Done