Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51487 )
Change subject: tests: Add unit test to run init/shutdown for mec1308.c, ene_lpc.c
......................................................................
Patch Set 18:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/51487/comment/64b18c06_4cdf9bf9
PS6, Line 9: hwaccess_io.h
: because those are needed to test lifecycle of mec1308.c
I added test for ene_lpc. […]
This is done, marking resolved
File tests/tests.c:
https://review.coreboot.org/c/flashrom/+/51487/comment/c77a3e1c_c78ab0f8
PS6, Line 102: return ((port == 0x2e /* MEC1308_SIO_PORT1 */
: || port == 0x4e /* MEC1308_SIO_PORT2 */)
: ? 0x20 /* MEC1308_DEVICE_ID_REG */
: : ((outb_val == 0x84 /* MEC1308_MBX_DATA_START */)
: ? 0xaa /* MEC1308_CMD_PASSTHRU_SUCCESS */
: : 0));
This is awesome, and it works! Thank you!
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/51487
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3af612defe1af3850dfc1626a208d873e3a3eddc
Gerrit-Change-Number: 51487
Gerrit-PatchSet: 18
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 25 May 2021 04:05:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment