Attention is currently required from: Angel Pons, Anastasia Klimchuk. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59921 )
Change subject: flashrom.c: extract operation only uses layout files ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Sorry for delay, just looked into this patch. […]
I don't understand the concern that goes away when "filename check would move from read_flash_to_file into do_read". In both cases (with and without CB:59291) the filename in do_read should be optional (i.e., required and enforced by cli_classic.c for option -r and missing for option -x)
As stated in the other CL, I believe both CLs should be merged but they are solving orthogonal issues. Since this CL is solving a bug I believe it should go on first. Otherwise I'm not strongly opposed with rebasing.