Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Sergii Dmytruk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58483 )
Change subject: writeprotect: add {get,set}_wp_mode() ......................................................................
Patch Set 31:
(5 comments)
File libflashrom.h:
https://review.coreboot.org/c/flashrom/+/58483/comment/dc3b2b1b_b98a1819 PS25, Line 148: const
In a forward declaration, `const` as a qualifier of a parameter (i.e. […]
Done
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/58483/comment/2cecaf9e_f7e419d9 PS25, Line 374:
Spurious line break?
Done
https://review.coreboot.org/c/flashrom/+/58483/comment/85d5c77e_4be0c46c PS25, Line 410: return 1;
Wouldn't it be a success if `mode == WP_MODE_DISABLE`?
Done
https://review.coreboot.org/c/flashrom/+/58483/comment/42fc2e33_f1d280c3 PS25, Line 412: f(
Missing space. Could be a `switch/case` though.
Done
https://review.coreboot.org/c/flashrom/+/58483/comment/f3e0aede_eb32225b PS25, Line 420: f(
Missing space.
Done