[flashrom-gerrit] Change in flashrom[master]: [UGLY HACK] move structs and probe_variable_size() out of dummyflasher.c

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Nico Huber, Namyoon Woo, Thomas Heijligen, Edward O'Callaghan.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63831 )

Change subject: [UGLY HACK] move structs and probe_variable_size() out of dummyflasher.c
......................................................................

Patch Set 10:

(1 comment)

Patchset:

PS4:
> Alright, as we agreed, I will fix https://ticket.coreboot.org/issues/365 first.

I started looking into this. First I needed to understand what the feature is doing and what is the use case. And how to test it when I start modifying code. I think I got enough understanding about those questions for now.

At the moment I think the code `probe_variable_size` should be staying in dummy because it is only used with dummy programmer, and only emulates probing (not doing anything for real). However, the function is wired in a wrong way, IMO. I will be trying different options how to wire it differently and see how it goes.