Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/53946 )
Change subject: flashchips.c: add support for W25Q32JW..IM ......................................................................
Patch Set 1:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/53946/comment/33c162d1_7538f38a PS1, Line 10: commit 1fc77dd1ee27a5d6e58a82c6ed6ed390a15372d7 For reference, this is CL:2160487
(No action needed, this comment just provides a direct link to the upstream change for convenience)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/53946/comment/eb28bb62_ca7cb4ce PS1, Line 17583: ..IM For consistency with W25Q64JW, I'd drop the trailing `..IM` suffix
https://review.coreboot.org/c/flashrom/+/53946/comment/82b761eb_4887ecb9 PS1, Line 17589: FEATURE_WRSR_WREN Datasheet says that OTP is supported
https://review.coreboot.org/c/flashrom/+/53946/comment/53d9e88b_0474b7ee PS1, Line 17611: }, Add:
.printlock = spi_prettyprint_status_register_bp2_tb_bpl,
https://review.coreboot.org/c/flashrom/+/53946/comment/c868e9aa_a551106e PS1, Line 17612: spi_disable_blockprotect spi_disable_blockprotect_bp2_srwd seems more accurate. Not perfect, but better.