Attention is currently required from: Angel Pons, Nikolai Artemiev.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/53953 )
Change subject: linux_mtd: drop 'mtd_' prefix from programmer data fields
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File linux_mtd.c:
https://review.coreboot.org/c/flashrom/+/53953/comment/b9369dd9_7e42eb09
PS1, Line 126: device_name
Strictly speaking, this isn't a programmer data field. I don't really care, though.
agree, probably shouldn't be conflated in this change. I suspect you ran a s/mtd_//g across the file and missed this one? Not a huge deal either way.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/53953
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2503c98e9111d1fecd911473f65eeea7031cfdc3
Gerrit-Change-Number: 53953
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Mon, 10 May 2021 03:41:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment