Attention is currently required from: Thomas Heijligen, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58883 )
Change subject: pci.h: move include into own wrapper
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File hwaccess.h:
https://review.coreboot.org/c/flashrom/+/58883/comment/0f799c1d_e1fa2523
PS1, Line 36: #define pci_mmio_writeb mmio_le_writeb
: #define pci_mmio_writew mmio_le_writew
: #define pci_mmio_writel mmio_le_writel
: #define pci_mmio_readb mmio_le_readb
: #define pci_mmio_readw mmio_le_readw
: #define pci_mmio_readl mmio_le_readl
Ok, I'll keep the pci_*** names for now.
Ack
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58883
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ibf00356f0ef5cc92e0ec99f8fe5cdda56f47b166
Gerrit-Change-Number: 58883
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 21 Dec 2021 16:58:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Gerrit-MessageType: comment
