23 Sep
2024
23 Sep
'24
10:12 a.m.
Attention is currently required from: Alexander Goncharov, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/77438?usp=email )
Change subject: doc: Add html_logo and html_title to sphinx config ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: I looked again at this patch... and I don't think it's needed at all. I am not sure about the logo (there are other comments discussing logo placement and alignment), and html_title is exactly the title we already have by default: https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-html_t...
Sorry for the noise! I will abandon this for now.
--
To view, visit https://review.coreboot.org/c/flashrom/+/77438?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I9a530f7143880393fffc2a97327416f2cd688586
Gerrit-Change-Number: 77438
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Alexander Goncharov chat@joursoir.net
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Alexander Goncharov chat@joursoir.net
Gerrit-Comment-Date: Mon, 23 Sep 2024 10:12:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No