- flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: meson: replace target_machine by host_machine
by Felix Singer (Code Review) 19 Jan '22

19 Jan '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Peter Marheine. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61197 ) Change subject: meson: replace target_machine by host_machine ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/61197/comment/746e3583_acd044fd PS1, Line 9: compiling compilers duplication? https://review.coreboot.org/c/flashrom/+/61197/comment/78328099_b1c7881b PS1, Line 10: onject o_b_ject https://review.coreboot.org/c/flashrom/+/61197/comment/db23676c_8e36abba PS1, Line 11: the build do you mean this? the to-be built binary. -- To view, visit https://review.coreboot.org/c/flashrom/+/61197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4a32c73052c3707607738c72256fb4366a2bf8ce Gerrit-Change-Number: 61197 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Wed, 19 Jan 2022 12:33:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: build hwaccess only on x86
by Nico Huber (Code Review) 19 Jan '22

19 Jan '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Peter Marheine. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61198 ) Change subject: meson: build hwaccess only on x86 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/61198 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iafabe8b4b2a95697773a739501dfc62d880d3f6d Gerrit-Change-Number: 61198 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Wed, 19 Jan 2022 12:27:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: build hwaccess only on x86
by Felix Singer (Code Review) 19 Jan '22

19 Jan '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Peter Marheine. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61198 ) Change subject: meson: build hwaccess only on x86 ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/61198/comment/7841498b_db90defa PS1, Line 9: Throw an error if an user tries to build a programmer which requires : hwaccess on nox-x86 platforms. Suggestion: hwaccess is only available for x86 platforms. Thus, guard the source files and throw an error on non-x86 platforms if flashrom should be built with a programmer requiring it. File meson.build: https://review.coreboot.org/c/flashrom/+/61198/comment/12d9fdfb_50a8f345 PS1, Line 357: need need_s_ -- To view, visit https://review.coreboot.org/c/flashrom/+/61198 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iafabe8b4b2a95697773a739501dfc62d880d3f6d Gerrit-Change-Number: 61198 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Wed, 19 Jan 2022 12:26:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: hwaccess: fix build on non-x86 targets
by Thomas Heijligen (Code Review) 19 Jan '22

19 Jan '22

Attention is currently required from: Edward O'Callaghan, Peter Marheine. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61194 ) Change subject: hwaccess: fix build on non-x86 targets ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: The hwaccess_x86 files should only get compiled on x86 platforms. So as the code which requires it. The Makefile handles this already correct and the bug is in the meson script. https://review.coreboot.org/c/flashrom/+/61198 fixes this for meson. -- To view, visit https://review.coreboot.org/c/flashrom/+/61194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I20f122679c30340b2c73afd7419e79644ddc3c4e Gerrit-Change-Number: 61194 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Wed, 19 Jan 2022 09:26:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: meson: build hwaccess only on x86
by Thomas Heijligen (Code Review) 19 Jan '22

19 Jan '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/61198 ) Change subject: meson: build hwaccess only on x86 ...................................................................... meson: build hwaccess only on x86 Throw an error if an user tries to build a programmer which requires hwaccess on nox-x86 platforms. Change-Id: Iafabe8b4b2a95697773a739501dfc62d880d3f6d Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson.build 1 file changed, 10 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/98/61198/1 diff --git a/meson.build b/meson.build index 66f6985..e76aef8 100644 --- a/meson.build +++ b/meson.build @@ -346,12 +346,16 @@ # raw memory, MSR or PCI port I/O access if need_raw_access - srcs += 'hwaccess.c' - srcs += 'hwaccess_x86_io.c' - srcs += 'hwaccess_x86_msr.c' - srcs += 'hwaccess_physmap.c' - cargs += '-DNEED_RAW_ACCESS=1' - cargs += '-D__FLASHROM_HAVE_OUTB__=1' + if host_machine.cpu_family() in ['x86', 'x86_64'] + srcs += 'hwaccess.c' + srcs += 'hwaccess_x86_io.c' + srcs += 'hwaccess_x86_msr.c' + srcs += 'hwaccess_physmap.c' + cargs += '-DNEED_RAW_ACCESS=1' + cargs += '-D__FLASHROM_HAVE_OUTB__=1' + else + error('RAW access is not available on non-x86 platforms. Disable the programmer which need it. Use meson build -Dpciutils=false -Dconfig_rayer_spi=false') + endif endif # raw serial IO -- To view, visit https://review.coreboot.org/c/flashrom/+/61198 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iafabe8b4b2a95697773a739501dfc62d880d3f6d Gerrit-Change-Number: 61198 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: meson: replace target_machine by host_machine
by Thomas Heijligen (Code Review) 19 Jan '22

19 Jan '22

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/61197 ) Change subject: meson: replace target_machine by host_machine ...................................................................... meson: replace target_machine by host_machine The target_machine object is only used for compiling compilers. The host_machine onject has the description of the execution environment of the build binary. https://mesonbuild.com/Cross-compilation.html Change-Id: I4a32c73052c3707607738c72256fb4366a2bf8ce Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M meson.build 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/97/61197/1 diff --git a/meson.build b/meson.build index b2e2d72..66f6985 100644 --- a/meson.build +++ b/meson.build @@ -225,7 +225,7 @@ srcs += 'chipset_enable.c' srcs += 'internal.c' srcs += 'processor_enable.c' - if target_machine.cpu_family() == 'x86' or target_machine.cpu_family() == 'x86_64' + if host_machine.cpu_family() == 'x86' or host_machine.cpu_family() == 'x86_64' srcs += 'amd_imc.c' srcs += 'dmi.c' srcs += 'ichspi.c' -- To view, visit https://review.coreboot.org/c/flashrom/+/61197 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I4a32c73052c3707607738c72256fb4366a2bf8ce Gerrit-Change-Number: 61197 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: hwaccess: fix build on non-x86 targets
by Paul Menzel (Code Review) 19 Jan '22

19 Jan '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Peter Marheine. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61194 ) Change subject: hwaccess: fix build on non-x86 targets ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/61194/comment/46d96fb6_d739558d PS1, Line 22: Change-Id: I20f122679c30340b2c73afd7419e79644ddc3c4e Missing Signed-off-by line? -- To view, visit https://review.coreboot.org/c/flashrom/+/61194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I20f122679c30340b2c73afd7419e79644ddc3c4e Gerrit-Change-Number: 61194 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Wed, 19 Jan 2022 07:16:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: hwaccess: fix build on non-x86 targets
by Peter Marheine (Code Review) 19 Jan '22

19 Jan '22

Peter Marheine has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/61194 ) Change subject: hwaccess: fix build on non-x86 targets ...................................................................... hwaccess: fix build on non-x86 targets The changes to hwaccess in https://review.coreboot.org/c/flashrom/+/60110 cause build failure on non-x86 systems because: * a new include file pulls in <sys/io.h> which only exists on x86 but the header may be used on other platforms * the new rget_io_perms function only works on x86 This change makes sys/io.h and rget_io_perms implementation only be included when building for x86 targets, which fixes the build on ARM. BUG=None TEST=meson build succeeds for both x86 and ARM targets Change-Id: I20f122679c30340b2c73afd7419e79644ddc3c4e --- M hwaccess_x86_io.c M hwaccess_x86_io.h 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/94/61194/1 diff --git a/hwaccess_x86_io.c b/hwaccess_x86_io.c index 3152bfe..7eee02a 100644 --- a/hwaccess_x86_io.c +++ b/hwaccess_x86_io.c @@ -33,7 +33,7 @@ int io_fd; #endif -#if !(defined(__DJGPP__) || defined(__LIBPAYLOAD__)) +#if defined(__i386__) || defined(__x86_64__) && !(defined(__DJGPP__) || defined(__LIBPAYLOAD__)) static int release_io_perms(void *p) { #if defined (__sun) @@ -79,7 +79,7 @@ #else /* DJGPP and libpayload environments have full PCI port I/O permissions by default. */ -/* PCI port I/O support is unimplemented on PPC/MIPS and unavailable on ARM. */ +/* PCI port I/O support is unimplemented on non-x86 platforms. */ int rget_io_perms(void) { return 0; diff --git a/hwaccess_x86_io.h b/hwaccess_x86_io.h index 0d16fdd..5cf151d 100644 --- a/hwaccess_x86_io.h +++ b/hwaccess_x86_io.h @@ -25,7 +25,7 @@ * that a Linux system's libc has a suitable sys/io.h or (on non-Linux) we depend on glibc to offer it. */ #if defined(__ANDROID__) #include <sys/glibc-syscalls.h> -#elif defined(__linux__) || defined(__GLIBC__) +#elif (defined(__i386__) || defined(__x86_64__)) && (defined(__linux__) || defined(__GLIBC__)) #include <sys/io.h> #endif -- To view, visit https://review.coreboot.org/c/flashrom/+/61194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I20f122679c30340b2c73afd7419e79644ddc3c4e Gerrit-Change-Number: 61194 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in flashrom[master]: tests: Upgrade linux_spi test to run probe lifecycle
by Anastasia Klimchuk (Code Review) 19 Jan '22

19 Jan '22

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59742 ) Change subject: tests: Upgrade linux_spi test to run probe lifecycle ...................................................................... Patch Set 4: (2 comments) This change is ready for review. File tests/lifecycle.c: https://review.coreboot.org/c/flashrom/+/59742/comment/9ec1c5db_a45d242e PS2, Line 336: W25Q128.V > Thank you so much for finding the problem! I missed the elephant in the room, forgot about caching I […] I fixed my epic fail :) I only have a question about spidev include (I added another comment). File tests/lifecycle.c: https://review.coreboot.org/c/flashrom/+/59742/comment/d61d5041_72f0f817 PS4, Line 18: #include <linux/spi/spidev.h> This include seems inevitable... is it ok? Do I need to guard it with anything? (like CONFIG_LINUX_SPI for example) -- To view, visit https://review.coreboot.org/c/flashrom/+/59742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I32d8e972d99b52c2b18f688aa6aeae75dd170f72 Gerrit-Change-Number: 59742 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 19 Jan 2022 03:23:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: test write protection
by Anastasia Klimchuk (Code Review) 19 Jan '22

19 Jan '22

Attention is currently required from: Nico Huber, Nikolai Artemiev, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59075 ) Change subject: tests: test write protection ...................................................................... Patch Set 26: (1 comment) Patchset: PS26: Sergii, there is a change happening at the moment: converting everything to call libflashrom API, and everything includes tests. Your tests are calling do_erase, so you need to update them as well. Good news: it will be really easy, and here is an example CB:61137 No rush, you can do at convenient time. Your chain will go chronologically after write-protect chain anyway. Thank you! -- To view, visit https://review.coreboot.org/c/flashrom/+/59075 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I49af7f6d173eb4c56c22d80b01a473b8c499c0f8 Gerrit-Change-Number: 59075 Gerrit-PatchSet: 26 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Tue, 18 Jan 2022 23:08:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit