Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Anastasia Klimchuk.
Hello build bot (Jenkins), Nico Huber, Thomas Heijligen, Angel Pons, Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68647
to look at the new patch set (#4).
Change subject: Makefile: Don't install git hooks automatically
......................................................................
Makefile: Don't install git hooks automatically
These specific git hooks are only needed when someone wants to push a
patch to upstream and so it's not needed to run it in every make call.
Beside that, we also don't know the environment in which this is
executed and it might not be wanted.
Thus, add a new make target `gitconfig` and move the install command to
it.
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: Ib83568c7ff149a8ec34ad7e92720c36a89def7bd
---
M Makefile
1 file changed, 21 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/68647/4
--
To view, visit https://review.coreboot.org/c/flashrom/+/68647
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib83568c7ff149a8ec34ad7e92720c36a89def7bd
Gerrit-Change-Number: 68647
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons.
Hello build bot (Jenkins), Nico Huber, Thomas Heijligen, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68647
to look at the new patch set (#3).
Change subject: Makefile: Don't install git hooks automatically
......................................................................
Makefile: Don't install git hooks automatically
These specific git hooks are only needed when someone wants to push a
patch to upstream and so it's not needed to run it in every make call.
Beside that, we also don't know the environment in which this is
executed and it might not be wanted.
Thus, add a new make target `gitconfig` and move the install command to
it.
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: Ib83568c7ff149a8ec34ad7e92720c36a89def7bd
---
M Makefile
1 file changed, 21 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/68647/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/68647
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib83568c7ff149a8ec34ad7e92720c36a89def7bd
Gerrit-Change-Number: 68647
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newpatchset
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68647 )
Change subject: Makefile: Don't install git hooks automatically
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/flashrom/+/68647
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib83568c7ff149a8ec34ad7e92720c36a89def7bd
Gerrit-Change-Number: 68647
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 21 Oct 2022 12:27:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68179 )
Change subject: flash.h: extend `struct tested` with .wp field
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS4:
> Sergii, would you mind rebasing this chain? it looks ready. […]
Rebased.
However, CB:68221 is probably better be abandoned. Without a reliable way of chip identification (e.g., by hashing SFDP) there can be no precise diagnostics on the status of WP for a chip as one chip record can cover unknown number of chips (including those that don't yet exist).
--
To view, visit https://review.coreboot.org/c/flashrom/+/68179
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I791400889159bc6f305fb05f3e2dd9a90dbe18a4
Gerrit-Change-Number: 68179
Gerrit-PatchSet: 5
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Fri, 21 Oct 2022 11:52:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68238 )
Change subject: rayer_spi.c: Roll up programmer type search logic into func
......................................................................
Patch Set 4:
(1 comment)
File rayer_spi.c:
https://review.coreboot.org/c/flashrom/+/68238/comment/12b0232c_6bb45e01
PS2, Line 276: const struct rayer_programmer rayer_spi_types[] = {
> Resolved?
Oh, thought it had been marked as resolved already. Sorry for the delay.
--
To view, visit https://review.coreboot.org/c/flashrom/+/68238
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id226ea61132ecc30fd8696e1d8ea50373e752cac
Gerrit-Change-Number: 68238
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Comment-Date: Fri, 21 Oct 2022 10:58:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Evan Benn.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68643 )
Change subject: flashrom_tester: Use Path type and tempdir for test data
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/68643/comment/57ed5ff3_f9a99a22
PS1, Line 10: Update many str to Path.
Can this be done separately from the tempdir stuff?
--
To view, visit https://review.coreboot.org/c/flashrom/+/68643
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4a0b25c8c70fa6dfd682fba3db7d3bf06b2eb7ac
Gerrit-Change-Number: 68643
Gerrit-PatchSet: 1
Gerrit-Owner: Evan Benn <evanbenn(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Evan Benn <evanbenn(a)google.com>
Gerrit-Comment-Date: Fri, 21 Oct 2022 09:25:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Thomas Heijligen, Edward O'Callaghan.
Hello build bot (Jenkins), Thomas Heijligen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68662
to look at the new patch set (#3).
Change subject: programmer: Add rget_io_perms programmer req framework
......................................................................
programmer: Add rget_io_perms programmer req framework
Some programmers require special i/o port access permissions.
Add a flag in the programmer entry to allow the programmer to
flag this requirement to the flashrom core logic rather than
each bespoke programmer init() calling rget_io_perms() in their
own ways.
This allows for flashrom core logic to assume and drop privileges
exactly where they are needed rather than for the entire life-time
of the program. It also deduplicates the assuming privilege code in
each driver.
Change-Id: I2be81995f8fe7e212a01008a5e7bdb49b1592ca2
Signed-off-by: Edward O'Callaghan <quasisec(a)google.com>
---
M flashrom.c
M include/programmer.h
2 files changed, 32 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/62/68662/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/68662
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2be81995f8fe7e212a01008a5e7bdb49b1592ca2
Gerrit-Change-Number: 68662
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Thomas Heijligen.
Hello build bot (Jenkins), Thomas Heijligen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68662
to look at the new patch set (#2).
Change subject: programmer: Add rget_io_perms programmer req framework
......................................................................
programmer: Add rget_io_perms programmer req framework
Some programmers require special i/o port access permissions.
Add a flag in the programmer entry to allow the programmer to
flag this requirement to the flashrom core logic rather than
each bespoke programmer init() calling rget_io_perms() in their
own ways.
This allows for flashrom core logic to assume and drop privileges
exactly where they are needed rather than for the entire life-time
of the program. It also deduplicates the assuming privilege code in
each driver.
Change-Id: I2be81995f8fe7e212a01008a5e7bdb49b1592ca2
Signed-off-by: Edward O'Callaghan <quasisec(a)google.com>
---
M flashrom.c
M include/programmer.h
2 files changed, 30 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/62/68662/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/68662
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2be81995f8fe7e212a01008a5e7bdb49b1592ca2
Gerrit-Change-Number: 68662
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-MessageType: newpatchset