- flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[main]: flashchips: add GD25F64F
by Anastasia Klimchuk (Code Review) 11 Oct '24

11 Oct '24

Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Victor Lim. Anastasia Klimchuk has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/84705?usp=email ) Change subject: flashchips: add GD25F64F ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/84705/comment/868ce68e_8f7cd4ed?us… : PS1, Line 10: Will send datasheet through email > All good, I will wait for you to send me and then review! Got the email, I did the review. You can remove this line from commit message. Thanks! -- To view, visit https://review.coreboot.org/c/flashrom/+/84705?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I07005f1589b76c8a61a1a744b16dc6b0c9020e11 Gerrit-Change-Number: 84705 Gerrit-PatchSet: 1 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Victor Lim <vlim(a)gigadevice.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 11 Oct 2024 06:53:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: flashchips: add GD25F256F
by Anastasia Klimchuk (Code Review) 11 Oct '24

11 Oct '24

Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Victor Lim. Anastasia Klimchuk has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/84090?usp=email ) Change subject: flashchips: add GD25F256F ...................................................................... Patch Set 2: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/84090/comment/e1ad1602_618f5733?us… : PS2, Line 8056: reg_bits > We should leave the srp bits out of reg_bits if the chip doesn't have them, but I'm not sure how the […] The exact definition in the datasheet for STATUS1 bit 7 is "Reserved". Does it mean the value in this bit can be any? Victor maybe you know, what happens when we read STATUS1, what will be in bit 7? Or, how this model handles Status register protection bit ? -- To view, visit https://review.coreboot.org/c/flashrom/+/84090?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ibbbbb8a55adbcbc2ee1785782c4eb3771d50c167 Gerrit-Change-Number: 84090 Gerrit-PatchSet: 2 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Victor Lim <vlim(a)gigadevice.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Fri, 11 Oct 2024 06:21:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nikolai Artemiev <nartemiev(a)google.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: erasure_layout: Add an option to sacrifice unchanged blocks for speed
by Bill XIE (Code Review) 11 Oct '24

11 Oct '24

Attention is currently required from: Aarya. Bill XIE has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/84721?usp=email ) Change subject: erasure_layout: Add an option to sacrifice unchanged blocks for speed ...................................................................... erasure_layout: Add an option to sacrifice unchanged blocks for speed Someone may prefer to sacrifice sub-blocks needless to change within a larger erase block for programming speed. These people who are okay to fry their chip sooner can set this option. If the percentage of sub-blocks needless to change within a larger erase block is lower than the given value, the whole larger erase block will be erased. Change-Id: I154e8a713f626c37dbbe118db700055b96d24803 Signed-off-by: persmule <persmule(a)hardenedlinux.org> --- M cli_classic.c M erasure_layout.c M include/flash.h 3 files changed, 25 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/84721/1 diff --git a/cli_classic.c b/cli_classic.c index 3343438..dc51259 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -45,6 +45,7 @@ OPTION_WP_DISABLE, OPTION_WP_LIST, OPTION_PROGRESS, + OPTION_SACRIFICE_RATIO, }; struct cli_options { @@ -73,6 +74,7 @@ char *logfile; char *referencefile; const char *chip_to_probe; + int sacrifice_ratio; }; static void cli_classic_usage(const char *name) @@ -119,6 +121,10 @@ " --flash-contents <ref-file> assume flash contents to be <ref-file>\n" " -L | --list-supported print supported devices\n" " --progress show progress percentage on the standard output\n" + " --sacrifice-ratio <ratio> The percentage of overall sub-blocks needless to\n" + " change within a larger erase block to be sacrificed\n" + " for programming speed, default 0, max 100\n" + " DANGEROUS! It wears your chip harder!\n" " -p | --programmer <name>[:<param>] specify the programmer device. One of\n"); list_programmers_linebreak(4, 80, 0); printf(".\n\nYou can specify one of -h, -R, -L, " @@ -810,6 +816,10 @@ case OPTION_PROGRESS: options->show_progress = true; break; + case OPTION_SACRIFICE_RATIO: + /* It is okay to convert invalid input to 0. */ + options->sacrifice_ratio = atoi(optarg); + break; default: cli_classic_abort_usage(NULL); break; @@ -879,6 +889,7 @@ {"version", 0, NULL, 'R'}, {"output", 1, NULL, 'o'}, {"progress", 0, NULL, OPTION_PROGRESS}, + {"sacrifice-ratio", 1, NULL, OPTION_SACRIFICE_RATIO}, {NULL, 0, NULL, 0}, }; @@ -1125,6 +1136,14 @@ goto out_shutdown; } + if (options.sacrifice_ratio) { + if (options.sacrifice_ratio > 100) { + msg_ginfo("Invalid input, use default.\n"); + options.sacrifice_ratio = 0; + } + fill_flash->sacrifice_ratio = options.sacrifice_ratio; + } + if (options.ifd && (flashrom_layout_read_from_ifd(&options.layout, fill_flash, NULL, 0) || process_include_args(options.layout, options.include_args))) { ret = 1; diff --git a/erasure_layout.c b/erasure_layout.c index 7f3bb46..56da450 100644 --- a/erasure_layout.c +++ b/erasure_layout.c @@ -249,9 +249,10 @@ } const int total_blocks = sub_block_end - sub_block_start + 1; - if (count == total_blocks) { - /* We are selecting one large block instead, so send opcode once - * instead of sending many smaller ones. + if (total_blocks - count <= total_blocks * flashctx->sacrifice_ratio / 100) { + /* Number of smaller blocks needless to change is lower than the + * sacrifice ratio, we are selecting one large block instead, so + * send opcode once instead of sending many smaller ones. */ if (ll->start_addr >= rstart && ll->end_addr <= rend) { /* Deselect all smaller blocks covering the same region. */ diff --git a/include/flash.h b/include/flash.h index d0e55af..90a9201 100644 --- a/include/flash.h +++ b/include/flash.h @@ -587,6 +587,8 @@ /* Progress reporting */ flashrom_progress_callback *progress_callback; struct flashrom_progress *progress_state; + /* Sacrifice ratio */ + int sacrifice_ratio; }; /* Timing used in probe routines. ZERO is -2 to differentiate between an unset -- To view, visit https://review.coreboot.org/c/flashrom/+/84721?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I154e8a713f626c37dbbe118db700055b96d24803 Gerrit-Change-Number: 84721 Gerrit-PatchSet: 1 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com>

1 0

[S] Change in flashrom[main]: erase/write: Deselect all smaller blocks when large block is selected
by Bill XIE (Code Review) 11 Oct '24

11 Oct '24

Attention is currently required from: Aarya, Anastasia Klimchuk, Bill XIE. Bill XIE has uploaded a new patch set (#3) to the change originally created by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/84686?usp=email ) The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: erase/write: Deselect all smaller blocks when large block is selected ...................................................................... erase/write: Deselect all smaller blocks when large block is selected Previously the logic which selected large block did deselect of smaller blocks, but only one level below. So some even smaller blocks could still remain selected, and this would result in duplicate erase. This patch deselects all smaller blocks of all levels below, down to the smallest size. If the area is covered by one large block, no other smaller blocks inside are needed. Change-Id: Icfc18d5c090b1dcb92ab157e2c139be71af59300 Spotted-by: persmule <persmule(a)hardenedlinux.org> Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Co-authored-by: persmule <persmule(a)hardenedlinux.org> --- M erasure_layout.c 1 file changed, 31 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/84686/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/84686?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Icfc18d5c090b1dcb92ab157e2c139be71af59300 Gerrit-Change-Number: 84686 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: erasure_layout: Erase larger block only when all sub-block need erase
by Peter Marheine (Code Review) 11 Oct '24

11 Oct '24

Attention is currently required from: Aarya, Bill XIE. Peter Marheine has posted comments on this change by Bill XIE. ( https://review.coreboot.org/c/flashrom/+/84614?usp=email ) Change subject: erasure_layout: Erase larger block only when all sub-block need erase ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/84614?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I9e10749186e395da67ec80e296119f33c3f83122 Gerrit-Change-Number: 84614 Gerrit-PatchSet: 2 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Oct 2024 02:49:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in flashrom[main]: flashchips: add GD25F256F
by Nikolai Artemiev (Code Review) 11 Oct '24

11 Oct '24

Attention is currently required from: Anastasia Klimchuk, Stefan Reinauer, Victor Lim. Nikolai Artemiev has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/84090?usp=email ) Change subject: flashchips: add GD25F256F ...................................................................... Patch Set 2: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/84090/comment/f79d76ff_cd198d4e?us… : PS2, Line 8056: reg_bits > Nikolai, I wanted to check with you, if srp is not defined in datasheet , is it fine to not define i […] We should leave the srp bits out of reg_bits if the chip doesn't have them, but I'm not sure how the chip would support write protection without the SRP0 bit. -- To view, visit https://review.coreboot.org/c/flashrom/+/84090?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ibbbbb8a55adbcbc2ee1785782c4eb3771d50c167 Gerrit-Change-Number: 84090 Gerrit-PatchSet: 2 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Victor Lim <vlim(a)gigadevice.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 11 Oct 2024 00:07:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: erasure_layout: Erase larger block only when all sub-block need erase
by Anastasia Klimchuk (Code Review) 10 Oct '24

10 Oct '24

Attention is currently required from: Aarya, Bill XIE, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Bill XIE. ( https://review.coreboot.org/c/flashrom/+/84614?usp=email ) Change subject: erasure_layout: Erase larger block only when all sub-block need erase ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS1: > In my opinion, this should be back ported to v1. […] Okay, we can start by merging this. Peter, it seems you also approve? if yes you can also approve the patch? Thank you! On your other point, we are planning another release soon-ish (think of in 1.5 month or so). Which will include everything done since July (and your work of course). I understand it's not the same as backport, but backport would create a new version number and tag anyway (and similar process to go through). -- To view, visit https://review.coreboot.org/c/flashrom/+/84614?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I9e10749186e395da67ec80e296119f33c3f83122 Gerrit-Change-Number: 84614 Gerrit-PatchSet: 2 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Thu, 10 Oct 2024 23:39:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Bill XIE <persmule(a)hardenedlinux.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[XS] Change in flashrom[main]: erasure_layout: Erase larger block only when all sub-block need erase
by Bill XIE (Code Review) 10 Oct '24

10 Oct '24

Attention is currently required from: Aarya, Anastasia Klimchuk, Peter Marheine. Bill XIE has posted comments on this change by Bill XIE. ( https://review.coreboot.org/c/flashrom/+/84614?usp=email ) Change subject: erasure_layout: Erase larger block only when all sub-block need erase ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > > For this patch, it's just the default? Which you also both agree that "safe", or 100%, should be d […] In my opinion, this should be back ported to v1.4 (along with CB:84253) after merging as soon as possible, in order to prevent more chips being fried. -- To view, visit https://review.coreboot.org/c/flashrom/+/84614?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I9e10749186e395da67ec80e296119f33c3f83122 Gerrit-Change-Number: 84614 Gerrit-PatchSet: 2 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Thu, 10 Oct 2024 14:49:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bill XIE <persmule(a)hardenedlinux.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[XS] Change in flashrom[main]: erasure_layout: Erase larger block only when all sub-block need erase
by Bill XIE (Code Review) 10 Oct '24

10 Oct '24

Attention is currently required from: Aarya, Anastasia Klimchuk, Peter Marheine. Bill XIE has posted comments on this change by Bill XIE. ( https://review.coreboot.org/c/flashrom/+/84614?usp=email ) Change subject: erasure_layout: Erase larger block only when all sub-block need erase ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > For this patch, it's just the default? Which you also both agree that "safe", or 100%, should be default? Yes, let's add that option later. > Someone might preferred that "quick" mode, and now boom it would be going away. What users of flashrom prefer most should always be programming the chip correctly, rather than frying their precious chip "quickly". We should realize that every erase reduces the lifetime of a flash chip, so never toy erase operation, which should be avoided as much as possible. Never impose a default that fries our precious chip soldered onboard "quickly" to us rational flashrom users, please. Besides, erase operations remain optimized when all sub-blocks of a block need erase. -- To view, visit https://review.coreboot.org/c/flashrom/+/84614?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I9e10749186e395da67ec80e296119f33c3f83122 Gerrit-Change-Number: 84614 Gerrit-PatchSet: 2 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Thu, 10 Oct 2024 14:42:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bill XIE <persmule(a)hardenedlinux.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

[XS] Change in flashrom[main]: erasure_layout: Erase larger block only when all sub-block need erase
by Anastasia Klimchuk (Code Review) 10 Oct '24

10 Oct '24

Attention is currently required from: Aarya, Bill XIE, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Bill XIE. ( https://review.coreboot.org/c/flashrom/+/84614?usp=email ) Change subject: erasure_layout: Erase larger block only when all sub-block need erase ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > > Making that a compile-time option seems like it's easy for a user to configure it to be quick-n-da […] Alright, if you both think command-line option is better, I am fine with this. I also just thought, there is an advantage of command-line option, such as it can be changed to different value without re-building flashrom. Not all users would be comfortable re-building. It can be percent value, or it can be like an enum, "safe" or "quick"? And also, seems like it can be a separate patch, to introduce new command-line option. For this patch, it's just the default? Which you also both agree that "safe", or 100%, should be default? I do think it's nice to give command-line option, but it's especially nice to give it if we are changing the default. Someone might preferred that "quick" mode, and now boom it would be going away. -- To view, visit https://review.coreboot.org/c/flashrom/+/84614?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I9e10749186e395da67ec80e296119f33c3f83122 Gerrit-Change-Number: 84614 Gerrit-PatchSet: 2 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Thu, 10 Oct 2024 12:17:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bill XIE <persmule(a)hardenedlinux.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit