- flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[master]: flashchips: add support for ISSI IS25LP016
by Anastasia Klimchuk (Code Review) 20 Nov '22

20 Nov '22

Attention is currently required from: Felix Singer, Nico Huber, Edward O'Callaghan, Angel Pons, Mario Kicherer. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68295 ) Change subject: flashchips: add support for ISSI IS25LP016 ...................................................................... Patch Set 2: Code-Review+1 (4 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/68295/comment/f93c53a3_a4605b6a PS1, Line 7: flashchips.c > just "flashchips" Done https://review.coreboot.org/c/flashrom/+/68295/comment/01da1934_71dac8b2 PS1, Line 10: Everything > Alternatively, list what has been tested and add "No issues found so far" or similar. To me current version looks fine ("Reading, erasing and writing works"). I am marking as resolved, but if you (Felix, Angel) disagree please tell! Patchset: PS2: Mario, I discovered that you have fixed the comments in your latest patchset, just haven't marked them as done :) When you are working on a patch, and uploading new patchset, you usually reply to the comments from your reviewers: either reply Done (if done) or ask for clarification if the comment is unclear, or you are not sure what to do with it. Otherwise I can be confusing, because patch has unresolved and unreplied comments - and reviewers might think that you are still working on it and it's not ready for next round of reviews. Thank you! For this patch: it needs rebasing, and also probably Felix and Angel would like to have another look after comments are resolved. File flashchips.c: https://review.coreboot.org/c/flashrom/+/68295/comment/4d26d611_2e6af0d5 PS1, Line 7381: > We use tabs to align the equals signs Done -- To view, visit https://review.coreboot.org/c/flashrom/+/68295 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iffd7c4284d4d96b30a94f5dee882b5403fdfc183 Gerrit-Change-Number: 68295 Gerrit-PatchSet: 2 Gerrit-Owner: Mario Kicherer Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Mario Kicherer Gerrit-Comment-Date: Sun, 20 Nov 2022 21:57:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: libpayload: Fix compiling bugs
by Nico Huber (Code Review) 20 Nov '22

20 Nov '22

Attention is currently required from: Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69831 ) Change subject: libpayload: Fix compiling bugs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/69831 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5062c5a62b90f7a189488f3f569dc357bd2cb85f Gerrit-Change-Number: 69831 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sun, 20 Nov 2022 12:42:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: stlinkv3_spi: Bug fix, Initialize uninitialized pointers
by Shreeyash (Code Review) 20 Nov '22

20 Nov '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons, Anastasia Klimchuk. Shreeyash has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66225 ) Change subject: stlinkv3_spi: Bug fix, Initialize uninitialized pointers ...................................................................... Patch Set 2: (1 comment) File stlinkv3_spi.c: https://review.coreboot.org/c/flashrom/+/66225/comment/caeaa6a2_4f0f5049 PS1, Line 501: stlinkv3_handle = usb_dev_get_by_vid_pid_serial(usb_ctx, > Shreeyash, […] You are right. I need to take a step back and re-assess what I am doing. I'll do that, thank you. -- To view, visit https://review.coreboot.org/c/flashrom/+/66225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7ce156a9f7455434ea461560320c84660c93c02f Gerrit-Change-Number: 66225 Gerrit-PatchSet: 2 Gerrit-Owner: Shreeyash <shreeyash335(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 20 Nov 2022 06:47:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Shreeyash <shreeyash335(a)gmail.com> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[XL] Change in flashrom[master]: flashrom/gui: Add GUI to Flashrom
by Iman Bingi (Code Review) 19 Nov '22

19 Nov '22

Attention is currently required from: Iman Bingi, Thomas Heijligen. Hello build bot (Jenkins), Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/69714 to look at the new patch set (#9). Change subject: flashrom/gui: Add GUI to Flashrom ...................................................................... flashrom/gui: Add GUI to Flashrom Flashrom Graphical User Interface Depends on: * gtk+ >=4 * adwaita >=1 Shortcomings: * Untested TODO: * Test on as many hardware/platforms as possible Change-Id: I130028b07e0465a2c877d5cbbdc2edd9ea5e8266 Signed-off-by: Ben Adu-Boahen <imanbingy(a)gmail.com> --- A gflashrom/Makefile A gflashrom/board_info.ui.xml A gflashrom/chartable.c A gflashrom/chartable.h A gflashrom/chipset_info.ui.xml A gflashrom/common_macros.h A gflashrom/common_ui.c A gflashrom/common_ui.h A gflashrom/config.h A gflashrom/configuration.c A gflashrom/configuration.h A gflashrom/context_menu.ui.xml A gflashrom/converter.c A gflashrom/converter.h A gflashrom/coreboot.Gflashrom.gschema.xml A gflashrom/data_buffer.c A gflashrom/data_buffer.h A gflashrom/device_info.c A gflashrom/device_info.h A gflashrom/find_dialog.ui.xml A gflashrom/find_options.ui.xml A gflashrom/findreplace.c A gflashrom/findreplace.h A gflashrom/flashchip_info.ui.xml A gflashrom/flashrom.c A gflashrom/gflashrom.c A gflashrom/gflashrom.css A gflashrom/gflashrom.gresource.xml A gflashrom/gflashrom.h A gflashrom/gflashrom_app_win.c A gflashrom/gflashrom_app_win.h A gflashrom/gflashrom_app_win.ui.xml A gflashrom/gflashrom_layout_manager.c A gflashrom/gflashrom_layout_manager.h A gflashrom/gflashrom_paste_data.c A gflashrom/gflashrom_paste_data.h A gflashrom/gflashrom_resources.c A gflashrom/help_overlay.ui.xml A gflashrom/hex_dialog.c A gflashrom/hex_dialog.h A gflashrom/hex_document.c A gflashrom/hex_document.h A gflashrom/hex_statusbar.c A gflashrom/hex_statusbar.h A gflashrom/jump_dialog.ui.xml A gflashrom/main.c A gflashrom/objects.c A gflashrom/objects.h A gflashrom/paste_special.c A gflashrom/paste_special.h A gflashrom/paste_special.ui.xml A gflashrom/preferences.c A gflashrom/preferences.h A gflashrom/preferences.ui.xml A gflashrom/print.c A gflashrom/print.h A gflashrom/replace_dialog.ui.xml 57 files changed, 17,916 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/14/69714/9 -- To view, visit https://review.coreboot.org/c/flashrom/+/69714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I130028b07e0465a2c877d5cbbdc2edd9ea5e8266 Gerrit-Change-Number: 69714 Gerrit-PatchSet: 9 Gerrit-Owner: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

[XL] Change in flashrom[master]: flashrom/gui: Add GUI to Flashrom
by Felix Singer (Code Review) 19 Nov '22

19 Nov '22

Attention is currently required from: Iman Bingi, Thomas Heijligen. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69714 ) Change subject: flashrom/gui: Add GUI to Flashrom ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: > I'm all for it. Whichever way is best to get it done. Alright. Thanks for your work! -- To view, visit https://review.coreboot.org/c/flashrom/+/69714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I130028b07e0465a2c877d5cbbdc2edd9ea5e8266 Gerrit-Change-Number: 69714 Gerrit-PatchSet: 8 Gerrit-Owner: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sat, 19 Nov 2022 22:54:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Iman Bingi <imanbingy(a)gmail.com> Gerrit-MessageType: comment

1 0

[XL] Change in flashrom[master]: flashrom/gui: Add GUI to Flashrom
by Iman Bingi (Code Review) 19 Nov '22

19 Nov '22

Attention is currently required from: Felix Singer, Thomas Heijligen. Iman Bingi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69714 ) Change subject: flashrom/gui: Add GUI to Flashrom ...................................................................... Patch Set 8: (2 comments) Patchset: PS2: > Hi Thomas, […] Hi Thomas, I think errors are fixed. Patchset: PS8: > Hi Ben, I think the project is big enough so that it deserves its own repository. […] I'm all for it. Whichever way is best to get it done. -- To view, visit https://review.coreboot.org/c/flashrom/+/69714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I130028b07e0465a2c877d5cbbdc2edd9ea5e8266 Gerrit-Change-Number: 69714 Gerrit-PatchSet: 8 Gerrit-Owner: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sat, 19 Nov 2022 22:46:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Iman Bingi <imanbingy(a)gmail.com> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

[XL] Change in flashrom[master]: flashrom/gui: Add GUI to Flashrom
by Felix Singer (Code Review) 19 Nov '22

19 Nov '22

Attention is currently required from: Iman Bingi, Thomas Heijligen. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69714 ) Change subject: flashrom/gui: Add GUI to Flashrom ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: Hi Ben, I think the project is big enough so that it deserves its own repository. What do you think? -- To view, visit https://review.coreboot.org/c/flashrom/+/69714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I130028b07e0465a2c877d5cbbdc2edd9ea5e8266 Gerrit-Change-Number: 69714 Gerrit-PatchSet: 8 Gerrit-Owner: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sat, 19 Nov 2022 22:30:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in flashrom[master]: flashrom/gui: Add GUI to Flashrom
by Iman Bingi (Code Review) 19 Nov '22

19 Nov '22

Attention is currently required from: Thomas Heijligen. Hello build bot (Jenkins), Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/69714 to look at the new patch set (#8). Change subject: flashrom/gui: Add GUI to Flashrom ...................................................................... flashrom/gui: Add GUI to Flashrom Flashrom Graphical User Interface Depends on: * gtk+ >=4 * adwaita >=1 Shortcomings: * Untested TODO: * Test on as many hardware/platforms as possible Change-Id: I130028b07e0465a2c877d5cbbdc2edd9ea5e8266 Signed-off-by: Ben Adu-Boahen <imanbingy(a)gmail.com> --- A gflashrom/Makefile A gflashrom/board_info.ui.xml A gflashrom/chartable.c A gflashrom/chartable.h A gflashrom/chipset_info.ui.xml A gflashrom/common_macros.h A gflashrom/common_ui.c A gflashrom/common_ui.h A gflashrom/config.h A gflashrom/configuration.c A gflashrom/configuration.h A gflashrom/context_menu.ui.xml A gflashrom/converter.c A gflashrom/converter.h A gflashrom/coreboot.Gflashrom.gschema.xml A gflashrom/data_buffer.c A gflashrom/data_buffer.h A gflashrom/device_info.c A gflashrom/device_info.h A gflashrom/find_dialog.ui.xml A gflashrom/find_options.ui.xml A gflashrom/findreplace.c A gflashrom/findreplace.h A gflashrom/flashchip_info.ui.xml A gflashrom/flashrom.c A gflashrom/gflashrom.c A gflashrom/gflashrom.css A gflashrom/gflashrom.gresource.xml A gflashrom/gflashrom.h A gflashrom/gflashrom_app_win.c A gflashrom/gflashrom_app_win.h A gflashrom/gflashrom_app_win.ui.xml A gflashrom/gflashrom_layout_manager.c A gflashrom/gflashrom_layout_manager.h A gflashrom/gflashrom_paste_data.c A gflashrom/gflashrom_paste_data.h A gflashrom/gflashrom_resources.c A gflashrom/help_overlay.ui.xml A gflashrom/hex_dialog.c A gflashrom/hex_dialog.h A gflashrom/hex_document.c A gflashrom/hex_document.h A gflashrom/hex_statusbar.c A gflashrom/hex_statusbar.h A gflashrom/jump_dialog.ui.xml A gflashrom/main.c A gflashrom/objects.c A gflashrom/objects.h A gflashrom/paste_special.c A gflashrom/paste_special.h A gflashrom/paste_special.ui.xml A gflashrom/preferences.c A gflashrom/preferences.h A gflashrom/preferences.ui.xml A gflashrom/print.c A gflashrom/print.h A gflashrom/replace_dialog.ui.xml 57 files changed, 17,656 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/14/69714/8 -- To view, visit https://review.coreboot.org/c/flashrom/+/69714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I130028b07e0465a2c877d5cbbdc2edd9ea5e8266 Gerrit-Change-Number: 69714 Gerrit-PatchSet: 8 Gerrit-Owner: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: libpayload: Fix compiling bugs
by Paul Menzel (Code Review) 19 Nov '22

19 Nov '22

Attention is currently required from: Nico Huber, Thomas Heijligen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69831 ) Change subject: libpayload: Fix compiling bugs ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/69831/comment/b1248e4a_89b83a15 PS1, Line 8: Please elaborate. -- To view, visit https://review.coreboot.org/c/flashrom/+/69831 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5062c5a62b90f7a189488f3f569dc357bd2cb85f Gerrit-Change-Number: 69831 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sat, 19 Nov 2022 21:21:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in flashrom[master]: flashrom/gui: Add GUI to Flashrom
by Iman Bingi (Code Review) 19 Nov '22

19 Nov '22

Attention is currently required from: Thomas Heijligen. Hello build bot (Jenkins), Thomas Heijligen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/69714 to look at the new patch set (#7). Change subject: flashrom/gui: Add GUI to Flashrom ...................................................................... flashrom/gui: Add GUI to Flashrom Flashrom Graphical User Interface Depends on: * gtk+ >=4 * adwaita >=1 Shortcomings: * Untested TODO: * Test on as many hardware/platforms as possible Change-Id: I130028b07e0465a2c877d5cbbdc2edd9ea5e8266 Signed-off-by: Ben Adu-Boahen <imanbingy(a)gmail.com> --- A gflashrom/Makefile A gflashrom/board_info.ui.xml A gflashrom/chartable.c A gflashrom/chartable.h A gflashrom/chipset_info.ui.xml A gflashrom/common_macros.h A gflashrom/common_ui.c A gflashrom/common_ui.h A gflashrom/config.h A gflashrom/configuration.c A gflashrom/configuration.h A gflashrom/context_menu.ui.xml A gflashrom/converter.c A gflashrom/converter.h A gflashrom/coreboot.Gflashrom.gschema.xml A gflashrom/data_buffer.c A gflashrom/data_buffer.h A gflashrom/device_info.c A gflashrom/device_info.h A gflashrom/find_dialog.ui.xml A gflashrom/find_options.ui.xml A gflashrom/findreplace.c A gflashrom/findreplace.h A gflashrom/flashchip_info.ui.xml A gflashrom/flashrom.c A gflashrom/gflashrom.c A gflashrom/gflashrom.css A gflashrom/gflashrom.gresource.xml A gflashrom/gflashrom.h A gflashrom/gflashrom_app_win.c A gflashrom/gflashrom_app_win.h A gflashrom/gflashrom_app_win.ui.xml A gflashrom/gflashrom_layout_manager.c A gflashrom/gflashrom_layout_manager.h A gflashrom/gflashrom_paste_data.c A gflashrom/gflashrom_paste_data.h A gflashrom/gflashrom_resources.c A gflashrom/help_overlay.ui.xml A gflashrom/hex_dialog.c A gflashrom/hex_dialog.h A gflashrom/hex_document.c A gflashrom/hex_document.h A gflashrom/hex_statusbar.c A gflashrom/hex_statusbar.h A gflashrom/jump_dialog.ui.xml A gflashrom/main.c A gflashrom/objects.c A gflashrom/objects.h A gflashrom/paste_special.c A gflashrom/paste_special.h A gflashrom/paste_special.ui.xml A gflashrom/preferences.c A gflashrom/preferences.h A gflashrom/preferences.ui.xml A gflashrom/print.c A gflashrom/print.h A gflashrom/replace_dialog.ui.xml 57 files changed, 17,474 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/14/69714/7 -- To view, visit https://review.coreboot.org/c/flashrom/+/69714 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I130028b07e0465a2c877d5cbbdc2edd9ea5e8266 Gerrit-Change-Number: 69714 Gerrit-PatchSet: 7 Gerrit-Owner: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit