Attention is currently required from: Thomas Heijligen.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73102 )
Change subject: cli_classic: include a fallback inplementation of getopt.
......................................................................
Patch Set 1:
(1 comment)
File include/cli_classic.h:
https://review.coreboot.org/c/flashrom/+/73102/comment/3a1b9144_50b46689
PS1, Line 5: __has_include
> This is an extension supported by GCC >=5, clang, Apple clang, MSVC 19.11 (Microsoft VS2017). […]
And DJGPP uses some GCC version, so it should work there as well
--
To view, visit https://review.coreboot.org/c/flashrom/+/73102
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6ebbde075014e3b45b0f9e04b34b72aa969e1197
Gerrit-Change-Number: 73102
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Comment-Date: Tue, 21 Feb 2023 16:30:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73102 )
Change subject: cli_classic: include a fallback inplementation of getopt.
......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1:
> Code style is completely different, is this intentional? Are there plans to keep this in sync with m […]
Not really. I just copied and tested it. I will adapt it
File cli_getopt.c:
https://review.coreboot.org/c/flashrom/+/73102/comment/f9207839_b86b1c56
PS1, Line 13: #if 0
> Hmmmm
Yea, this should be replaces by flashroms error message.
File include/cli_classic.h:
https://review.coreboot.org/c/flashrom/+/73102/comment/ed210e62_5c5c655f
PS1, Line 5: __has_include
> Interesting, is this standard in the C version we use?
This is an extension supported by GCC >=5, clang, Apple clang, MSVC 19.11 (Microsoft VS2017).
From c23 it is also in the standard.
I started to use it to make the headers simpler.
--
To view, visit https://review.coreboot.org/c/flashrom/+/73102
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6ebbde075014e3b45b0f9e04b34b72aa969e1197
Gerrit-Change-Number: 73102
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Tue, 21 Feb 2023 09:33:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Evan Benn.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73175 )
Change subject: MAINTAINERS: flashrom_tester: Change email
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File MAINTAINERS:
https://review.coreboot.org/c/flashrom/+/73175/comment/a71b664b_000ba2f9
PS1, Line 173: S: Supported
> This is probably still supported, but not by me
Edward, do you think someone else can take this? Thank you!
--
To view, visit https://review.coreboot.org/c/flashrom/+/73175
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic1a53ddbc38e7d63f7b15aa2b31c63a5b65746f9
Gerrit-Change-Number: 73175
Gerrit-PatchSet: 1
Gerrit-Owner: Evan Benn <evanbenn(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Evan Benn <evanbenn(a)gmail.com>
Gerrit-Comment-Date: Tue, 21 Feb 2023 06:34:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Evan Benn <evanbenn(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Anastasia Klimchuk.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73175 )
Change subject: MAINTAINERS: flashrom_tester: Change email
......................................................................
Patch Set 1:
(1 comment)
File MAINTAINERS:
https://review.coreboot.org/c/flashrom/+/73175/comment/5fcf1f6d_25a28db2
PS1, Line 173: S: Supported
This is probably still supported, but not by me
--
To view, visit https://review.coreboot.org/c/flashrom/+/73175
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic1a53ddbc38e7d63f7b15aa2b31c63a5b65746f9
Gerrit-Change-Number: 73175
Gerrit-PatchSet: 1
Gerrit-Owner: Evan Benn <evanbenn(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Tue, 21 Feb 2023 06:16:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment