Attention is currently required from: Anastasia Klimchuk.
Anastasia Klimchuk has uploaded a new patch set (#2) to the change originally created by Joseph Goh. ( https://review.coreboot.org/c/flashrom/+/68278?usp=email )
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: flashchips: add support for MX25V16066/KH25V16066
......................................................................
flashchips: add support for MX25V16066/KH25V16066
Change-Id: Ic5f0548f023fcd09a970148586497e00414ad1ae
Signed-off-by: Joseph Goh <josephgoh7(a)gmail.com>
Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org>
---
M flashchips.c
1 file changed, 38 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/68278/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/68278?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic5f0548f023fcd09a970148586497e00414ad1ae
Gerrit-Change-Number: 68278
Gerrit-PatchSet: 2
Gerrit-Owner: Joseph Goh <josephgoh7(a)gmail.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Angel Pons, Nikolai Artemiev, foss(a)volatilesystems.org.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69309?usp=email )
Change subject: flashchips: Add support for XMC XM25QH128A
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
Nikolai, may I ask you to check reg_bits in this chip definition? I checked the rest and replaced remaining fn pointers with enums.
Thank you!
--
To view, visit https://review.coreboot.org/c/flashrom/+/69309?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iced40403c6694a55fd648ea2785cdcba21712234
Gerrit-Change-Number: 69309
Gerrit-PatchSet: 3
Gerrit-Owner: foss(a)volatilesystems.org
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: foss(a)volatilesystems.org
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Fri, 16 Jun 2023 09:18:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, foss(a)volatilesystems.org.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69309?usp=email )
Change subject: flashchips: Add support for XMC XM25QH128A
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69309/comment/64e83d68_e2e3cd86 :
PS1, Line 8:
> > Has been read/write/erase tested. Is that sufficient and if not what other info should I provide? […]
Done
Commit Message:
https://review.coreboot.org/c/flashrom/+/69309/comment/824ddc79_c6e757cc :
PS2, Line 7: .
> Remove the dot. […]
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/69309?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iced40403c6694a55fd648ea2785cdcba21712234
Gerrit-Change-Number: 69309
Gerrit-PatchSet: 3
Gerrit-Owner: foss(a)volatilesystems.org
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: foss(a)volatilesystems.org
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 16 Jun 2023 09:13:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: foss(a)volatilesystems.org
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, foss(a)volatilesystems.org.
Anastasia Klimchuk has uploaded a new patch set (#3) to the change originally created by foss(a)volatilesystems.org. ( https://review.coreboot.org/c/flashrom/+/69309?usp=email )
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: flashchips: Add support for XMC XM25QH128A
......................................................................
flashchips: Add support for XMC XM25QH128A
Tested: read, write and erase.
Chip (and datasheet) have recenty been removed from XMC's website
but can still be retrieved through web archive:
https://web.archive.org/web/20221122191724/https://www.semiee.com/file/XMC/…
Signed-off-by: Stijn Segers <foss(a)volatilesystems.org>
Change-Id: Iced40403c6694a55fd648ea2785cdcba21712234
Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org>
---
M flashchips.c
M include/flashchips.h
2 files changed, 49 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/09/69309/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/69309?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iced40403c6694a55fd648ea2785cdcba21712234
Gerrit-Change-Number: 69309
Gerrit-PatchSet: 3
Gerrit-Owner: foss(a)volatilesystems.org
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: foss(a)volatilesystems.org
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: David Williams, Jean THOMAS, Peter Marheine, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75891?usp=email )
Change subject: Makefile: Fix DirtyJTAG build
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Patchset:
PS3:
Jean, thank you so much for your patch! I rebase it so that Jenkins re-runs and verifies the patch.
When only commit message is changed, Jenkins does not re-run (even though it failed because of commit message! :)).
--
To view, visit https://review.coreboot.org/c/flashrom/+/75891?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4b6bce24f34848d11731f4bc118a3052fb24e639
Gerrit-Change-Number: 75891
Gerrit-PatchSet: 3
Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: David Williams
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Williams
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Attention: Jean THOMAS <virgule(a)jeanthomas.me>
Gerrit-Comment-Date: Fri, 16 Jun 2023 01:19:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Jean THOMAS has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67878?usp=email )
Change subject: dirtyjtag: Add DirtyJTAG programmer
......................................................................
Patch Set 17:
(1 comment)
Patchset:
PS17:
> There's a typo in the Makefile. We should be adding to FEATURE_FLAGS not FEATURE_CFLAGS. […]
Taken care of in https://review.coreboot.org/c/flashrom/+/75891
--
To view, visit https://review.coreboot.org/c/flashrom/+/67878?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic43e9a014ed7d04e429e73b30c9dcfdde1a78913
Gerrit-Change-Number: 67878
Gerrit-PatchSet: 17
Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-CC: David Williams
Gerrit-Comment-Date: Thu, 15 Jun 2023 21:10:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Williams
Gerrit-MessageType: comment
Attention is currently required from: David Williams, Thomas Heijligen.
Jean THOMAS has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75891?usp=email )
Change subject: Makefile: Fix DirtyJTAG build
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Hi everyone,
Earlier this month David reported an issue with the Makefile which prevented DirtyJTAG from being used with flashrom when built using the Makefile. I think I missed this issue when I added support for DirtyJTAG as I was only testing builds with meson.
This patch fixes the typo and finally brings DirtyJTAG for Make enthusiasts.
Jean.
--
To view, visit https://review.coreboot.org/c/flashrom/+/75891?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4b6bce24f34848d11731f4bc118a3052fb24e639
Gerrit-Change-Number: 75891
Gerrit-PatchSet: 2
Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me>
Gerrit-Reviewer: David Williams
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Williams
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Comment-Date: Thu, 15 Jun 2023 21:04:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jean THOMAS, Thomas Heijligen.
Hello Thomas Heijligen, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/75891?usp=email
to look at the new patch set (#2).
Change subject: Makefile: Fix DirtyJTAG build
......................................................................
Makefile: Fix DirtyJTAG build
Fix typo where "FEATURE_FLAGS" is spelled "FEATURE_CFLAGS", preventing
the DirtyJTAG driver from being used.
Signed-off-by: Jean THOMAS <virgule(a)jeanthomas.me>
Change-Id: I4b6bce24f34848d11731f4bc118a3052fb24e639
---
M Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/75891/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/75891?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4b6bce24f34848d11731f4bc118a3052fb24e639
Gerrit-Change-Number: 75891
Gerrit-PatchSet: 2
Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Jean THOMAS <virgule(a)jeanthomas.me>
Gerrit-MessageType: newpatchset