Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77293?usp=email )
Change subject: doc: Fix nesting of About flashrom group of menu items
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/77293?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I595acc282a536a6d5fa26cf2f8d18dbe549f9716
Gerrit-Change-Number: 77293
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Wed, 30 Aug 2023 21:08:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/77288?usp=email )
Change subject: Makefile: Remove a bashism when searching for sphinx-build
......................................................................
Makefile: Remove a bashism when searching for sphinx-build
e.g. when the shell is dash and sphinx-build is not installed, HAS_SPHINXBUILD would be wrongly set to yes.
Change-Id: I4d89e24ec3401446acec857eae134928bc3064d2
Signed-off-by: Bart De Schuymer <bdschuym(a)artinalgorithms.be>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/77288
Reviewed-by: Peter Marheine <pmarheine(a)chromium.org>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Patrick Georgi <patrick(a)coreboot.org>
Reviewed-by: Jan Samek <jan.samek(a)siemens.com>
---
M Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Patrick Georgi: Looks good to me, approved
build bot (Jenkins): Verified
Peter Marheine: Looks good to me, approved
Jan Samek: Looks good to me, but someone else must approve
diff --git a/Makefile b/Makefile
index bc3eecb..bf01d0f 100644
--- a/Makefile
+++ b/Makefile
@@ -250,7 +250,7 @@
HAS_LINUX_SPI := $(call c_compile_test, Makefile.d/linux_spi_test.c)
HAS_LINUX_I2C := $(call c_compile_test, Makefile.d/linux_i2c_test.c)
HAS_SERIAL := $(strip $(if $(filter $(TARGET_OS), DOS libpayload), no, yes))
-HAS_SPHINXBUILD := $(shell command -v $(SPHINXBUILD) &>/dev/null && echo yes || echo no)
+HAS_SPHINXBUILD := $(shell command -v $(SPHINXBUILD) >/dev/null 2>/dev/null && echo yes || echo no)
EXEC_SUFFIX := $(strip $(if $(filter $(TARGET_OS), DOS MinGW), .exe))
override CFLAGS += -Iinclude
--
To view, visit https://review.coreboot.org/c/flashrom/+/77288?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4d89e24ec3401446acec857eae134928bc3064d2
Gerrit-Change-Number: 77288
Gerrit-PatchSet: 3
Gerrit-Owner: Bart De Schuymer <bdschuym(a)artinalgorithms.be>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Vasily Galkin.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77529?usp=email )
Change subject: spi25_statusreg: add verbose output on status registers read results
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Yes, logged only for super-verbose -VVV. [ā¦]
The verbosity is fine for -VVV, all good.
I would say, it's really good to add something to help "a person quite new to SPI flashing". This helped you, and might also help a hundred of other people in future. Thank you for contributing.
--
To view, visit https://review.coreboot.org/c/flashrom/+/77529?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ibc8e9229ab5d6578479564d11cc7aff9442e24ad
Gerrit-Change-Number: 77529
Gerrit-PatchSet: 1
Gerrit-Owner: Vasily Galkin
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Vasily Galkin
Gerrit-Comment-Date: Mon, 28 Aug 2023 10:25:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Vasily Galkin
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Anastasia Klimchuk.
Vasily Galkin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77529?usp=email )
Change subject: spi25_statusreg: add verbose output on status registers read results
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Just to check, this will log only for super verbose mode -VVV right? [ā¦]
Yes, logged only for super-verbose -VVV.
The less verbose -VV does not log it.
The count of produced lines depends on a chip. In general, say near 4 lines are produced (flashrom really rereads it several times).
Also, since WP registers are automatically touched by flashrom's "--write" operation - it is also displayed during --write. This was especially important: before it I thought that WP is not working, but it turned out that flashrom automatically disabled it. (after that I tested WP with an external tool talking directly to programmer at lower level and seen that the WP is really working)
BTW, if this is too verbose for flashrom standards - I'm fine with dropping this patch from a series. I'm seeing its usefulness only as "a person quite new to SPI flashing"
--
To view, visit https://review.coreboot.org/c/flashrom/+/77529?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ibc8e9229ab5d6578479564d11cc7aff9442e24ad
Gerrit-Change-Number: 77529
Gerrit-PatchSet: 1
Gerrit-Owner: Vasily Galkin
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Mon, 28 Aug 2023 08:19:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Vasily Galkin.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77529?usp=email )
Change subject: spi25_statusreg: add verbose output on status registers read results
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Just to check, this will log only for super verbose mode -VVV right?
How many lines it produces in the log, one line per WP operation, or more?
--
To view, visit https://review.coreboot.org/c/flashrom/+/77529?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ibc8e9229ab5d6578479564d11cc7aff9442e24ad
Gerrit-Change-Number: 77529
Gerrit-PatchSet: 1
Gerrit-Owner: Vasily Galkin
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Vasily Galkin
Gerrit-Comment-Date: Mon, 28 Aug 2023 04:25:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Bart De Schuymer, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77288?usp=email )
Change subject: Makefile: Remove a bashism when searching for sphinx-build
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> Bart, sorry I forgot to ask previously, did you have a chance to test run with both dash and bash? [ā¦]
Assuming that Bart tested with dash, I just tested with bash. It makes! :)
--
To view, visit https://review.coreboot.org/c/flashrom/+/77288?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4d89e24ec3401446acec857eae134928bc3064d2
Gerrit-Change-Number: 77288
Gerrit-PatchSet: 2
Gerrit-Owner: Bart De Schuymer <bdschuym(a)artinalgorithms.be>
Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Bart De Schuymer <bdschuym(a)artinalgorithms.be>
Gerrit-Comment-Date: Mon, 28 Aug 2023 02:12:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Bart De Schuymer, Thomas Heijligen.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77288?usp=email )
Change subject: Makefile: Remove a bashism when searching for sphinx-build
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/77288?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4d89e24ec3401446acec857eae134928bc3064d2
Gerrit-Change-Number: 77288
Gerrit-PatchSet: 2
Gerrit-Owner: Bart De Schuymer <bdschuym(a)artinalgorithms.be>
Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Bart De Schuymer <bdschuym(a)artinalgorithms.be>
Gerrit-Comment-Date: Sun, 27 Aug 2023 23:35:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Thomas Heijligen, Vasily Galkin, roman.stingler(a)gmail.com.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58179?usp=email )
Change subject: flashchips.c: Add support for IS25WQ040
......................................................................
Patch Set 6: Code-Review+2
(2 comments)
Patchset:
PS6:
> Thanks for review! [ā¦]
Yes, it's fine.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/58179/comment/3455c18c_2c22f345 :
PS5, Line 7793: /* QPI enable 0x35, disable 0xF5 */
> Removed this commands 0x35, 0xF5 are not mentioned in datasheet. [ā¦]
Oh yes I see there is Quad I/O , I missed it.
--
To view, visit https://review.coreboot.org/c/flashrom/+/58179?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I072c6b94d7931637d1c2721c3316205f2d57320e
Gerrit-Change-Number: 58179
Gerrit-PatchSet: 6
Gerrit-Owner: Vasily Galkin
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: roman.stingler(a)gmail.com
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Vasily Galkin
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: roman.stingler(a)gmail.com
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Sun, 27 Aug 2023 08:14:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Vasily Galkin
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment