- flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[main]: Add Idaville platform into chipset enable list and add update IRC reg...
by Kevin Yu (Code Review) 27 Nov '23

27 Nov '23

Attention is currently required from: Anastasia Klimchuk. Kevin Yu has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79287?usp=email ) Change subject: Add Idaville platform into chipset enable list and add update IRC region support ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/flashrom/+/79287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I15bb3bb368156b078547ce0bdea556c7ab87f729 Gerrit-Change-Number: 79287 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Yu <ykevin(a)celestica.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 27 Nov 2023 10:21:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[main]: Add support for updating the iRC region on the Idaville HCC platform
by Kevin Yu (Code Review) 27 Nov '23

27 Nov '23

Kevin Yu has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/79286?usp=email ) Change subject: Add support for updating the iRC region on the Idaville HCC platform ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/79286?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I2e30d750ae1bf56e2e4e17f09652433a983dddb2 Gerrit-Change-Number: 79286 Gerrit-PatchSet: 2 Gerrit-Owner: Kevin Yu <ykevin(a)celestica.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[main]: Add support for updating the iRC region on the Idaville HCC platform
by Kevin Yu (Code Review) 27 Nov '23

27 Nov '23

Kevin Yu has restored this change. ( https://review.coreboot.org/c/flashrom/+/79286?usp=email ) Change subject: Add support for updating the iRC region on the Idaville HCC platform ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/flashrom/+/79286?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I2e30d750ae1bf56e2e4e17f09652433a983dddb2 Gerrit-Change-Number: 79286 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Yu <ykevin(a)celestica.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: restore

1 0

[M] Change in flashrom[main]: Add support for updating the iRC region on the Idaville HCC platform
by Kevin Yu (Code Review) 27 Nov '23

27 Nov '23

Kevin Yu has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/79286?usp=email ) Change subject: Add support for updating the iRC region on the Idaville HCC platform ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/79286?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I2e30d750ae1bf56e2e4e17f09652433a983dddb2 Gerrit-Change-Number: 79286 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Yu <ykevin(a)celestica.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[main]: Add support for updating the iRC region on the Idaville HCC platform
by Kevin Yu (Code Review) 27 Nov '23

27 Nov '23

Kevin Yu has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79286?usp=email ) Change subject: Add support for updating the iRC region on the Idaville HCC platform ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/flashrom/+/79286?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I2e30d750ae1bf56e2e4e17f09652433a983dddb2 Gerrit-Change-Number: 79286 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Yu <ykevin(a)celestica.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 27 Nov 2023 09:20:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: serial: Fix sp_flush_incoming for serprog TCP connections
by Anastasia Klimchuk (Code Review) 27 Nov '23

27 Nov '23

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/79112?usp=email ) Change subject: serial: Fix sp_flush_incoming for serprog TCP connections ...................................................................... serial: Fix sp_flush_incoming for serprog TCP connections During the development of an esp32 serprog-compatible SPI programmer, and implementation of the TCP over Wi-Fi for serprog, I discovered that sp_flush_incoming() silently fails if the underlying sp_fd descriptor is a TCP socket. This patch adds a check for this case - tcflush returns ENOTTY, meaning tcflush is not supported for not terminal objects, in this case a fallback serialport_read_nonblock loop is used. TESTED=esp32-serprog, TCP-over-WiFi mode, ~90% connection attempts fail to synchronize without patch; no synchronization issues with patch applied. Signed-off-by: Stanislav Ponomarev <me(a)stasponomarev.com> Change-Id: I9724a2fcd4a41dede2c15f83877efa6c3b0b7fae Reviewed-on: https://review.coreboot.org/c/flashrom/+/79112 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M serial.c 1 file changed, 19 insertions(+), 3 deletions(-) Approvals: Anastasia Klimchuk: Looks good to me, approved build bot (Jenkins): Verified diff --git a/serial.c b/serial.c index 10d739a..577ccf4 100644 --- a/serial.c +++ b/serial.c @@ -377,10 +377,26 @@ #if IS_WINDOWS PurgeComm(sp_fd, PURGE_RXCLEAR); #else - /* FIXME: error handling */ - tcflush(sp_fd, TCIFLUSH); + if (!tcflush(sp_fd, TCIFLUSH)) + return; + + if (errno == ENOTTY) { // TCP socket case: sp_fd is not a terminal descriptor - tcflush is not supported + unsigned char c; + int ret; + + do { + ret = serialport_read_nonblock(&c, 1, 1, NULL); + } while (ret == 0); + + // positive error code indicates no data available immediately - similar to EAGAIN/EWOULDBLOCK + // i.e. all buffered data was read + // negative error code indicates a permanent error + if (ret < 0) + msg_perr("Could not flush serial port incoming buffer: read has failed"); + } else { // any other errno indicates an unrecoverable sp_fd state + msg_perr_strerror("Could not flush serial port incoming buffer: "); + } #endif - return; } int serialport_shutdown(void *data) -- To view, visit https://review.coreboot.org/c/flashrom/+/79112?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I9724a2fcd4a41dede2c15f83877efa6c3b0b7fae Gerrit-Change-Number: 79112 Gerrit-PatchSet: 5 Gerrit-Owner: Stanislav Ponomarev <me(a)stasponomarev.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[main]: Makefile: CONFIG_INTERNAL depends on raw mem access
by Fabrice Fontaine (Code Review) 27 Nov '23

27 Nov '23

Attention is currently required from: Alexander Goncharov, Thomas Heijligen. Fabrice Fontaine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78930?usp=email ) Change subject: Makefile: CONFIG_INTERNAL depends on raw mem access ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Just to confirm that I'm correctly understanding the motivation for this, you don't need the interna […] Yes, correct. -- To view, visit https://review.coreboot.org/c/flashrom/+/78930?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7610f5f7cc5b114ffa90d5752155acc8b6b7c9f7 Gerrit-Change-Number: 78930 Gerrit-PatchSet: 2 Gerrit-Owner: Fabrice Fontaine <fontaine.fabrice(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Mon, 27 Nov 2023 09:03:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Fabrice Fontaine <fontaine.fabrice(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: Add Idaville platform into chipset enable list
by Kevin Yu (Code Review) 27 Nov '23

27 Nov '23

Attention is currently required from: Anastasia Klimchuk. Kevin Yu has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79285?usp=email ) Change subject: Add Idaville platform into chipset enable list ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/flashrom/+/79285?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I3e77dab58e497ac6a1cbbb1c536c53544c1eef55 Gerrit-Change-Number: 79285 Gerrit-PatchSet: 1 Gerrit-Owner: Kevin Yu <ykevin(a)celestica.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 27 Nov 2023 08:26:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: docs: Add guideline about Gerrit display names
by Peter Marheine (Code Review) 27 Nov '23

27 Nov '23

Attention is currently required from: Anastasia Klimchuk, Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79250?usp=email ) Change subject: docs: Add guideline about Gerrit display names ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/79250?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I69b6f5c1c56a2798dd156582cb5fa246b2396ab3 Gerrit-Change-Number: 79250 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stanislav Ponomarev <me(a)stasponomarev.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 26 Nov 2023 22:23:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: Makefile: CONFIG_INTERNAL depends on raw mem access
by Peter Marheine (Code Review) 27 Nov '23

27 Nov '23

Attention is currently required from: Alexander Goncharov, Fabrice Fontaine, Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78930?usp=email ) Change subject: Makefile: CONFIG_INTERNAL depends on raw mem access ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS1: > We're not using meson.build to compile flashrom in buildroot but indeed it seems all good. Just to confirm that I'm correctly understanding the motivation for this, you don't need the internal programmer but it gets turned on by default even though it fails to build on sh4. Marking it as depending on raw memory access causes it to be default-disabled (on sh4), fixing the build. -- To view, visit https://review.coreboot.org/c/flashrom/+/78930?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7610f5f7cc5b114ffa90d5752155acc8b6b7c9f7 Gerrit-Change-Number: 78930 Gerrit-PatchSet: 2 Gerrit-Owner: Fabrice Fontaine <fontaine.fabrice(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Fabrice Fontaine <fontaine.fabrice(a)gmail.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Sun, 26 Nov 2023 22:22:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Fabrice Fontaine <fontaine.fabrice(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit