- flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[main]: dummyflasher: make RO status of SPI_SR_WEL explicit
by Sergii Dmytruk (Code Review) 03 Dec '23

03 Dec '23

Sergii Dmytruk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/60224?usp=email ) Change subject: dummyflasher: make RO status of SPI_SR_WEL explicit ...................................................................... Abandoned Doesn't affect functionality -- To view, visit https://review.coreboot.org/c/flashrom/+/60224?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I5dce77e22a1f9cd29f40ec0881d2b1238a985e97 Gerrit-Change-Number: 60224 Gerrit-PatchSet: 1 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in flashrom[main]: dummyflasher: Fix JEDEC_WRSR2 and JEDEC_WRSR3 emulation
by Sergii Dmytruk (Code Review) 03 Dec '23

03 Dec '23

Attention is currently required from: Anastasia Klimchuk. Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79390?usp=email ) Change subject: dummyflasher: Fix JEDEC_WRSR2 and JEDEC_WRSR3 emulation ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: Look, for example, at `spi_write_register()`: ```c write_cmd[0] = JEDEC_WRSR; write_cmd[1] = value; // ... write_cmd[0] = JEDEC_WRSR2; write_cmd[1] = value; // ... write_cmd[0] = JEDEC_WRSR3; write_cmd[1] = value; ``` Current code is correct. -- To view, visit https://review.coreboot.org/c/flashrom/+/79390?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia0e51a9b8dbd1f67cb947e3ec73f64b6d30cbb97 Gerrit-Change-Number: 79390 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 03 Dec 2023 13:29:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: programmer: Use C linkage when compiling with C++
by Anastasia Klimchuk (Code Review) 03 Dec '23

03 Dec '23

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/63001?usp=email ) Change subject: programmer: Use C linkage when compiling with C++ ...................................................................... Abandoned The patch looks abandoned with unresolved comments and no responses for >1yr. Patch can be restored later if needed. -- To view, visit https://review.coreboot.org/c/flashrom/+/63001?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7e12ead58dee07313d756f1afcc687ba12b6392b Gerrit-Change-Number: 63001 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Hughes <tomhughes(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in flashrom[main]: layout: space needed between literal and identifier
by Anastasia Klimchuk (Code Review) 03 Dec '23

03 Dec '23

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/63000?usp=email ) Change subject: layout: space needed between literal and identifier ...................................................................... Abandoned The patch looks abandoned with unresolved comments and no responses for >1yr. Patch can be restored later if needed. -- To view, visit https://review.coreboot.org/c/flashrom/+/63000?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I04f5572d6c2dc27b7c54ee6ee97874a7a1940229 Gerrit-Change-Number: 63000 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Hughes <tomhughes(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[main]: flash: move nested struct to top level
by Anastasia Klimchuk (Code Review) 03 Dec '23

03 Dec '23

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/62999?usp=email ) Change subject: flash: move nested struct to top level ...................................................................... Abandoned The patch looks abandoned with unresolved comments and no responses for >1yr. Patch can be restored later if needed. -- To view, visit https://review.coreboot.org/c/flashrom/+/62999?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I89988e4a6a7ca65866ba019320e480e491389d56 Gerrit-Change-Number: 62999 Gerrit-PatchSet: 1 Gerrit-Owner: Tom Hughes <tomhughes(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[XS] Change in flashrom[main]: dummyflasher: Fix JEDEC_WRSR2 and JEDEC_WRSR3 emulation
by Anastasia Klimchuk (Code Review) 03 Dec '23

03 Dec '23

Attention is currently required from: Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79390?usp=email ) Change subject: dummyflasher: Fix JEDEC_WRSR2 and JEDEC_WRSR3 emulation ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I am wondering, is it useful to have a test for this scenario? -- To view, visit https://review.coreboot.org/c/flashrom/+/79390?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia0e51a9b8dbd1f67cb947e3ec73f64b6d30cbb97 Gerrit-Change-Number: 79390 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Sun, 03 Dec 2023 09:19:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[main]: dummyflasher: make RO status of SPI_SR_WEL explicit
by Anastasia Klimchuk (Code Review) 03 Dec '23

03 Dec '23

Attention is currently required from: Angel Pons, Nico Huber, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/60224?usp=email ) Change subject: dummyflasher: make RO status of SPI_SR_WEL explicit ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Sergii, I found this old patch and I am not sure it's needed anymore, because the code has changed a lot since then. The only thing that might be need is test, although if yes it should go to a different file, `chip_wp.c` with other wp tests. If you think this patch is not needed anymore, them maybe mark it abandoned. Also while I was looking at the current code in the dummyflasher I made another patch CB:79390 maybe you can have a look. Thank you! -- To view, visit https://review.coreboot.org/c/flashrom/+/60224?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I5dce77e22a1f9cd29f40ec0881d2b1238a985e97 Gerrit-Change-Number: 60224 Gerrit-PatchSet: 1 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Sun, 03 Dec 2023 09:19:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: dummyflasher: Fix JEDEC_WRSR2 and JEDEC_WRSR3 emulation
by Anastasia Klimchuk (Code Review) 03 Dec '23

03 Dec '23

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/79390?usp=email ) Change subject: dummyflasher: Fix JEDEC_WRSR2 and JEDEC_WRSR3 emulation ...................................................................... dummyflasher: Fix JEDEC_WRSR2 and JEDEC_WRSR3 emulation JEDEC_WRSR already emulated STATUS1 and STATUS2 correctly, but JEDEC_WRSR2 and JEDEC_WRSR3 were handled by a different case branch. Change-Id: Ia0e51a9b8dbd1f67cb947e3ec73f64b6d30cbb97 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M dummyflasher.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/90/79390/1 diff --git a/dummyflasher.c b/dummyflasher.c index cf4ca03..efe5720 100644 --- a/dummyflasher.c +++ b/dummyflasher.c @@ -605,7 +605,7 @@ ro_bits = get_reg_ro_bit_mask(data, STATUS2); data->emu_status[1] &= ro_bits; - data->emu_status[1] |= (writearr[1] & ~ro_bits); + data->emu_status[1] |= (writearr[2] & ~ro_bits); msg_pdbg2("WRSR2 wrote 0x%02x.\n", data->emu_status[1]); @@ -621,7 +621,7 @@ ro_bits = get_reg_ro_bit_mask(data, STATUS3); data->emu_status[2] &= ro_bits; - data->emu_status[2] |= (writearr[1] & ~ro_bits); + data->emu_status[2] |= (writearr[3] & ~ro_bits); msg_pdbg2("WRSR3 wrote 0x%02x.\n", data->emu_status[2]); break; -- To view, visit https://review.coreboot.org/c/flashrom/+/79390?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia0e51a9b8dbd1f67cb947e3ec73f64b6d30cbb97 Gerrit-Change-Number: 79390 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[XS] Change in flashrom[main]: cli_output.c: Format progress output to show in single line
by Anastasia Klimchuk (Code Review) 03 Dec '23

03 Dec '23

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/64668?usp=email ) Change subject: cli_output.c: Format progress output to show in single line ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/flashrom/+/64668?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If982193f9857f0da47cd71706ce6cebaa60d4323 Gerrit-Change-Number: 64668 Gerrit-PatchSet: 3 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Evan Benn <evanbenn(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Richard Hughes <richard(a)hughsie.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: abandon

1 0

[XS] Change in flashrom[main]: cli_output.c: Format progress output to show in single line
by Anastasia Klimchuk (Code Review) 03 Dec '23

03 Dec '23

Attention is currently required from: Aarya, Daniel Campello. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64668?usp=email ) Change subject: cli_output.c: Format progress output to show in single line ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Hello Aarya and everyone, I am looking at this patch right now and I think to mark it abandoned. Firstly because it seems like it is indeed, but also because I am planning to change the progress indicator soon-ish (next year). I understand the idea of the patch, but I want to start from different side: for example I don't think the word "completed" needs to be repeated with every % , and same for operation name (it is enough to say READ started... READ completed, without repeating it with every %). After that maybe the issue this patch is trying to solve, will go away naturally. And in any case, thanks everyone for the effort <3 -- To view, visit https://review.coreboot.org/c/flashrom/+/64668?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If982193f9857f0da47cd71706ce6cebaa60d4323 Gerrit-Change-Number: 64668 Gerrit-PatchSet: 3 Gerrit-Owner: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Evan Benn <evanbenn(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Richard Hughes <richard(a)hughsie.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Comment-Date: Sun, 03 Dec 2023 07:48:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit