- flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: cli_classic: Remove layout-for-write-only
by build bot (Jenkins) (Code Review) 06 Apr '17

06 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19195 ) Change subject: cli_classic: Remove layout-for-write-only ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/80/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/96/ : SUCCESS -- To view, visit https://review.coreboot.org/19195 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If75d87c0625b48257aa65f1aa793f83b1d6ef2bc Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Kill doit()
by build bot (Jenkins) (Code Review) 06 Apr '17

06 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19193 ) Change subject: Kill doit() ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/78/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/94/ : SUCCESS -- To view, visit https://review.coreboot.org/19193 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e7befa18de955ad0ce16be4e4f21300ba4f3a42 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Make coreboot.org the upstream server
by build bot (Jenkins) (Code Review) 06 Apr '17

06 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19187 ) Change subject: Make coreboot.org the upstream server ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/72/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/88/ : SUCCESS -- To view, visit https://review.coreboot.org/19187 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9461dc4d2d461fff253392c4a1249a8835d5c9a4 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Give layouts their own type
by build bot (Jenkins) (Code Review) 06 Apr '17

06 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19188 ) Change subject: Give layouts their own type ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/73/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/89/ : SUCCESS -- To view, visit https://review.coreboot.org/19188 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic728fc9f64958f62a2e2f321f4ec440e8658c808 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add a convenient libflashrom interface
by build bot (Jenkins) (Code Review) 06 Apr '17

06 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19190 ) Change subject: Add a convenient libflashrom interface ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom_gerrit/91/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/75/ : SUCCESS -- To view, visit https://review.coreboot.org/19190 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd25aa58c165119a9f31ee9e9285bd793693d884 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add Doxyfile for libflashrom documentation
by build bot (Jenkins) (Code Review) 06 Apr '17

06 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19191 ) Change subject: Add Doxyfile for libflashrom documentation ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom_gerrit/92/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/76/ : SUCCESS -- To view, visit https://review.coreboot.org/19191 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38052378ab417727323ff36009304108b347c2b7 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add functions to read/erase/write/verify by layout
by build bot (Jenkins) (Code Review) 06 Apr '17

06 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19189 ) Change subject: Add functions to read/erase/write/verify by layout ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom_gerrit/90/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/74/ : SUCCESS -- To view, visit https://review.coreboot.org/19189 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I060d9c42d71c83c3f95a6189cd22dad8b1504784 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: This is a combination of 2 commits. The first commit's messa...
by build bot (Jenkins) (Code Review) 06 Apr '17

06 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19185 ) Change subject: This is a combination of 2 commits. The first commit's message is: ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom_gerrit/87/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/71/ : SUCCESS -- To view, visit https://review.coreboot.org/19185 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d3f54c3e87d3875b73a6f24c15d2ae43b84819f Gerrit-PatchSet: 2 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Whitelist Roda/RV11 laptop
by David Hendricks (Code Review) 06 Apr '17

06 Apr '17

Hello Nico Huber, I'd like you to do a code review. Please visit https://review.coreboot.org/19199 to review the following change. Change subject: Whitelist Roda/RV11 laptop ...................................................................... Whitelist Roda/RV11 laptop Change-Id: Id8e794f263d5fb5bc7e98437d17fc137ffd91e25 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M board_enable.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/99/19199/1 diff --git a/board_enable.c b/board_enable.c index 2f0c1c0..22e45b4 100644 --- a/board_enable.c +++ b/board_enable.c @@ -2457,6 +2457,7 @@ {0x10DE, 0x0360, 0x1462, 0x7250, 0x10DE, 0x0368, 0x1462, 0x7250, NULL, NULL, NULL, P3, "MSI", "MS-7250 (K9N SLI)", 0, OK, nvidia_mcp_gpio2_raise}, {0x1011, 0x0019, 0xaa55, 0xaa55, 0x8086, 0x7190, 0, 0, NULL, NULL, NULL, P3, "Nokia", "IP530", 0, OK, fdc37b787_gpio50_raise_3f0}, {0x8086, 0x3B30, 0x1025, 0x0379, 0x8086, 0x3B09, 0x1025, 0x0379, "^EasyNote LM85$", NULL, NULL, P2, "Packard Bell","EasyNote LM85", 0, OK, p2_whitelist_laptop}, + {0x8086, 0x0154, 0x8086, 0x0154, 0x8086, 0x1e55, 0x8086, 0x1e55, "RV11$", "Roda", "Lizard RV11", P2, "Roda", "RV11", 0, OK, p2_whitelist_laptop}, {0x8086, 0x24d3, 0x144d, 0xb025, 0x8086, 0x1050, 0x144d, 0xb025, NULL, NULL, NULL, P3, "Samsung", "Polaris 32", 0, OK, intel_ich_gpio21_raise}, {0x1106, 0x3099, 0, 0, 0x1106, 0x3074, 0, 0, NULL, "shuttle", "ak31", P3, "Shuttle", "AK31", 0, OK, w836xx_memw_enable_2e}, {0x1106, 0x3104, 0x1297, 0xa238, 0x1106, 0x3059, 0x1297, 0xc063, NULL, NULL, NULL, P3, "Shuttle", "AK38N", 256, OK, NULL}, -- To view, visit https://review.coreboot.org/19199 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id8e794f263d5fb5bc7e98437d17fc137ffd91e25 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[staging]: Enable writes with active ME
by David Hendricks (Code Review) 06 Apr '17

06 Apr '17

Hello Nico Huber, I'd like you to do a code review. Please visit https://review.coreboot.org/19200 to review the following change. Change subject: Enable writes with active ME ...................................................................... Enable writes with active ME At least with the -A,--noverify-all switch, this warning isn't true any more. Maybe we want to force -A in that case? Change-Id: I2245d40d67b1433784eeb79612daaf5e839b3c2b Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M flashrom.8.tmpl M ichspi.c 2 files changed, 1 insertion(+), 37 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/19200/1 diff --git a/flashrom.8.tmpl b/flashrom.8.tmpl index 02d79e3..c786a86 100644 --- a/flashrom.8.tmpl +++ b/flashrom.8.tmpl @@ -472,14 +472,7 @@ the ME firmware and so on respectively. The flash descriptor can also specify up to 5 so called "Protected Regions", which are freely chosen address ranges independent from the aforementioned "Flash Regions". All of them can be write -and/or read protected individually. If flashrom detects such a lock it will -disable write support unless the user forces it with the -.sp -.B " flashrom \-p internal:ich_spi_force=yes" -.sp -syntax. If this leads to erase or write accesses to the flash it would most -probably bring it into an inconsistent and unbootable state and we will not -provide any support in such a case. +and/or read protected individually. .sp If you have an Intel chipset with an ICH2 or later southbridge and if you want to set specific IDSEL values for a non-default flash chip or an embedded diff --git a/ichspi.c b/ichspi.c index e1395ee..6821b5d 100644 --- a/ichspi.c +++ b/ichspi.c @@ -1567,7 +1567,6 @@ uint16_t tmp2; uint32_t tmp; char *arg; - int ich_spi_force = 0; int ich_spi_rw_restricted = 0; int desc_valid = 0; struct ich_descriptors desc = {{ 0 }}; @@ -1639,22 +1638,6 @@ } free(arg); - arg = extract_programmer_param("ich_spi_force"); - if (arg && !strcmp(arg, "yes")) { - ich_spi_force = 1; - msg_pspew("ich_spi_force enabled.\n"); - } else if (arg && !strlen(arg)) { - msg_perr("Missing argument for ich_spi_force.\n"); - free(arg); - return ERROR_FATAL; - } else if (arg) { - msg_perr("Unknown argument for ich_spi_force: \"%s\" " - "(not \"yes\").\n", arg); - free(arg); - return ERROR_FATAL; - } - free(arg); - tmp2 = mmio_readw(ich_spibar + ICH9_REG_HSFS); msg_pdbg("0x04: 0x%04x (HSFS)\n", tmp2); prettyprint_ich9_reg_hsfs(tmp2); @@ -1702,18 +1685,6 @@ if (!ichspi_lock) ich9_set_pr(i, 0, 0); ich_spi_rw_restricted |= ich9_handle_pr(i); - } - - if (ich_spi_rw_restricted) { - if (!ich_spi_force) - programmer_may_write = 0; - msg_pinfo("Writes have been disabled for safety reasons. You can enforce write\n" - "support with the ich_spi_force programmer option, but you will most likely\n" - "harm your hardware! If you force flashrom you will get no support if\n" - "something breaks. On a few mainboards it is possible to enable write\n" - "access by setting a jumper (see its documentation or the board itself).\n"); - if (ich_spi_force) - msg_pinfo("Continuing with write support because the user forced us to!\n"); } tmp = mmio_readl(ich_spibar + ICH9_REG_SSFS); -- To view, visit https://review.coreboot.org/19200 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2245d40d67b1433784eeb79612daaf5e839b3c2b Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit