Nico Huber has posted comments on this change. ( https://review.coreboot.org/19436 )
Change subject: flashchips: Add untested Winbond W25Q128.W
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/19436/1/flashchips.c
File flashchips.c:
PS1, Line 14828: W25Q128.W
> FWIW, the W25Q128FV has the same model ID when operating in QPI mode (and a
Same for the smaller chips (according to comments in flashchips.h).
And we don't seem to worry about them.
--
To view, visit https://review.coreboot.org/19436
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34ce7f1bdd0d2fb1b065031e5a689bb16ffc70db
Gerrit-PatchSet: 2
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes
Hello David Hendricks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/19436
to look at the new patch set (#2).
Change subject: flashchips: Add untested Winbond W25Q128.W
......................................................................
flashchips: Add untested Winbond W25Q128.W
Only difference to its sibling W25Q128.V seems to be the supply voltage.
Change-Id: I34ce7f1bdd0d2fb1b065031e5a689bb16ffc70db
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M flashchips.c
M flashchips.h
2 files changed, 41 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/36/19436/2
--
To view, visit https://review.coreboot.org/19436
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I34ce7f1bdd0d2fb1b065031e5a689bb16ffc70db
Gerrit-PatchSet: 2
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at>
Gerrit-Reviewer: build bot (Jenkins)
David Hendricks has posted comments on this change. ( https://review.coreboot.org/19436 )
Change subject: flashchips: Add untested Winbond W25Q128.W
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/19436/1/flashchips.c
File flashchips.c:
PS1, Line 14828: W25Q128.W
FWIW, the W25Q128FV has the same model ID when operating in QPI mode (and a different model when in normal mode). I'm not sure if it's worth worrying about, though.
--
To view, visit https://review.coreboot.org/19436
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34ce7f1bdd0d2fb1b065031e5a689bb16ffc70db
Gerrit-PatchSet: 1
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes
Nico Huber has posted comments on this change. ( https://review.coreboot.org/17950 )
Change subject: cli_classic: Add option (-A, --noverify-all)
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/17950/7/cli_classic.c
File cli_classic.c:
PS7, Line 58: A
> Maybe we should decide that not every little configuration bit needs to be
I'd be fine with `-N`. IMHO, inverted logic isn't a bad thing
here. It emphasizes that we do as much verification as possible
by default.
--
To view, visit https://review.coreboot.org/17950
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40b5983f56d62821d17b827b88b73d1d41a30bd7
Gerrit-PatchSet: 7
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes
Stefan Tauner has posted comments on this change. ( https://review.coreboot.org/17950 )
Change subject: cli_classic: Add option (-A, --noverify-all)
......................................................................
Patch Set 11:
(1 comment)
Are there matching manpage changes?
https://review.coreboot.org/#/c/17950/7/cli_classic.c
File cli_classic.c:
PS7, Line 58: A
> Well, 'V' is already taken, obviously. Any other suggestions?
Maybe we should decide that not every little configuration bit needs to be changeable by single-character options and stop to try to find a suitable characters for new options?
In this case however... I'd use -N which would match the -n closely. It cements the status quo of inverted logic with these verify options though.
--
To view, visit https://review.coreboot.org/17950
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I40b5983f56d62821d17b827b88b73d1d41a30bd7
Gerrit-PatchSet: 11
Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes