- flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: .gitignore: Add Doxygen dir `libflashrom-doc/`
by David Hendricks (Code Review) 03 Sep '17

03 Sep '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/20811 ) Change subject: .gitignore: Add Doxygen dir `libflashrom-doc/` ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/20811 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Id25d05cdf6107cc7a99b94a8523e23bd8698c2d6 Gerrit-Change-Number: 20811 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 03 Sep 2017 20:17:35 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: ich_descriptors: Use MAX_NUM_FLREGS for entries[]
by David Hendricks (Code Review) 03 Sep '17

03 Sep '17

David Hendricks has submitted this change and it was merged. ( https://review.coreboot.org/21338 ) Change subject: ich_descriptors: Use MAX_NUM_FLREGS for entries[] ...................................................................... ich_descriptors: Use MAX_NUM_FLREGS for entries[] 5 regions made sense in 2013 when this bit of code was originally written. MAX_NUM_FLREGS is now used to keep track of the max number of flash regions and is >5 since Sunrise Point. Change-Id: Idb559e618369fecf930724a7c1c84765247f3e38 Signed-off-by: David Hendricks <dhendricks(a)fb.com> Reviewed-on: https://review.coreboot.org/21338 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M ich_descriptors.h 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/ich_descriptors.h b/ich_descriptors.h index 9a16031..db4d28f 100644 --- a/ich_descriptors.h +++ b/ich_descriptors.h @@ -568,7 +568,7 @@ struct ich_layout { struct flashrom_layout base; - struct romentry entries[5]; + struct romentry entries[MAX_NUM_FLREGS]; }; ssize_t ich_number_of_regions(enum ich_chipset cs, const struct ich_desc_content *content); -- To view, visit https://review.coreboot.org/21338 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: merged Gerrit-Change-Id: Idb559e618369fecf930724a7c1c84765247f3e38 Gerrit-Change-Number: 21338 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: Move ich_layout from layout.h to ich_descriptors.h
by David Hendricks (Code Review) 03 Sep '17

03 Sep '17

David Hendricks has submitted this change and it was merged. ( https://review.coreboot.org/21337 ) Change subject: Move ich_layout from layout.h to ich_descriptors.h ...................................................................... Move ich_layout from layout.h to ich_descriptors.h This moves the ich_layout declaration from one header to another. This will avoid a circular dependency when we update the entries[] member in the follow-up patch to use MAX_NUM_FLREGS which is defined in ich_descriptors.h. Change-Id: I08006f1f7c9ccdd17a9a6d74881ed2c8541d4de1 Signed-off-by: David Hendricks <dhendricks(a)fb.com> Reviewed-on: https://review.coreboot.org/21337 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M ich_descriptors.h M layout.h 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/ich_descriptors.h b/ich_descriptors.h index 4ddc710..9a16031 100644 --- a/ich_descriptors.h +++ b/ich_descriptors.h @@ -566,6 +566,11 @@ struct ich_desc_upper_map upper; }; +struct ich_layout { + struct flashrom_layout base; + struct romentry entries[5]; +}; + ssize_t ich_number_of_regions(enum ich_chipset cs, const struct ich_desc_content *content); ssize_t ich_number_of_masters(enum ich_chipset cs, const struct ich_desc_content *content); diff --git a/layout.h b/layout.h index c93d754..f32dc82 100644 --- a/layout.h +++ b/layout.h @@ -57,11 +57,6 @@ struct romentry entry; }; -struct ich_layout { - struct flashrom_layout base; - struct romentry entries[5]; -}; - struct flashrom_layout *get_global_layout(void); int process_include_args(struct flashrom_layout *); -- To view, visit https://review.coreboot.org/21337 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: merged Gerrit-Change-Id: I08006f1f7c9ccdd17a9a6d74881ed2c8541d4de1 Gerrit-Change-Number: 21337 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: ich_descriptors: Use MAX_NUM_FLREGS for entries[]
by Nico Huber (Code Review) 02 Sep '17

02 Sep '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21338 ) Change subject: ich_descriptors: Use MAX_NUM_FLREGS for entries[] ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/21338 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Idb559e618369fecf930724a7c1c84765247f3e38 Gerrit-Change-Number: 21338 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Sep 2017 13:01:20 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Move ich_layout from layout.h to ich_descriptors.h
by Nico Huber (Code Review) 02 Sep '17

02 Sep '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21337 ) Change subject: Move ich_layout from layout.h to ich_descriptors.h ...................................................................... Patch Set 1: Code-Review+2 Even without the dependency problem, this makes sense. Thank you! -- To view, visit https://review.coreboot.org/21337 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I08006f1f7c9ccdd17a9a6d74881ed2c8541d4de1 Gerrit-Change-Number: 21337 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Sep 2017 13:00:41 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: ich_descriptors: Use MAX_NUM_FLREGS for entries[]
by build bot (Jenkins) (Code Review) 02 Sep '17

02 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21338 ) Change subject: ich_descriptors: Use MAX_NUM_FLREGS for entries[] ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/529/ : SUCCESS -- To view, visit https://review.coreboot.org/21338 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Idb559e618369fecf930724a7c1c84765247f3e38 Gerrit-Change-Number: 21338 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Sep 2017 03:40:06 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: ich_descriptors: Use MAX_NUM_FLREGS for entries[]
by David Hendricks (Code Review) 02 Sep '17

02 Sep '17

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/21338 to look at the new patch set (#2). Change subject: ich_descriptors: Use MAX_NUM_FLREGS for entries[] ...................................................................... ich_descriptors: Use MAX_NUM_FLREGS for entries[] 5 regions made sense in 2013 when this bit of code was originally written. MAX_NUM_FLREGS is now used to keep track of the max number of flash regions and is >5 since Sunrise Point. Change-Id: Idb559e618369fecf930724a7c1c84765247f3e38 Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M ich_descriptors.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/38/21338/2 -- To view, visit https://review.coreboot.org/21338 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newpatchset Gerrit-Change-Id: Idb559e618369fecf930724a7c1c84765247f3e38 Gerrit-Change-Number: 21338 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: ich_descriptors: Use MAX_NUM_FLREGS for entries[]
by build bot (Jenkins) (Code Review) 02 Sep '17

02 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21338 ) Change subject: ich_descriptors: Use MAX_NUM_FLREGS for entries[] ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/528/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/481/ : SUCCESS -- To view, visit https://review.coreboot.org/21338 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Idb559e618369fecf930724a7c1c84765247f3e38 Gerrit-Change-Number: 21338 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Sep 2017 03:35:08 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Move ich_layout from layout.h to ich_descriptors.h
by build bot (Jenkins) (Code Review) 02 Sep '17

02 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21337 ) Change subject: Move ich_layout from layout.h to ich_descriptors.h ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/527/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/480/ : SUCCESS -- To view, visit https://review.coreboot.org/21337 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I08006f1f7c9ccdd17a9a6d74881ed2c8541d4de1 Gerrit-Change-Number: 21337 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 02 Sep 2017 03:35:04 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: ich_descriptors: Use MAX_NUM_FLREGS for entries[]
by David Hendricks (Code Review) 02 Sep '17

02 Sep '17

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/21338 Change subject: ich_descriptors: Use MAX_NUM_FLREGS for entries[] ...................................................................... ich_descriptors: Use MAX_NUM_FLREGS for entries[] 5 regions made sense in 2013 when this bit of code was originally written. MAX_NUM_FLREGS is now used to keep track of the max number of flash regions and is larger since Sunrise Point. Change-Id: Idb559e618369fecf930724a7c1c84765247f3e38 Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M ich_descriptors.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/38/21338/1 diff --git a/ich_descriptors.h b/ich_descriptors.h index 9a16031..db4d28f 100644 --- a/ich_descriptors.h +++ b/ich_descriptors.h @@ -568,7 +568,7 @@ struct ich_layout { struct flashrom_layout base; - struct romentry entries[5]; + struct romentry entries[MAX_NUM_FLREGS]; }; ssize_t ich_number_of_regions(enum ich_chipset cs, const struct ich_desc_content *content); -- To view, visit https://review.coreboot.org/21338 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newchange Gerrit-Change-Id: Idb559e618369fecf930724a7c1c84765247f3e38 Gerrit-Change-Number: 21338 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit