- flashrom-gerrit - mail.coreboot.org

Change in flashrom[stable]: Convert flashrom to git
by Nico Huber (Code Review) 01 Oct '17

01 Oct '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21776 ) Change subject: Convert flashrom to git ...................................................................... Patch Set 2: Code-Review-2 I do mind. It violates the topic. I don't want any functional changes, that were not tested on staging for some time, this close to the release. -- To view, visit https://review.coreboot.org/21776 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: comment Gerrit-Change-Id: I08a324ce1fd8afcc6f516ddfb6f09e05a67cdd17 Gerrit-Change-Number: 21776 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Oct 2017 08:41:28 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[stable]: Convert flashrom to git
by Stefan Tauner (Code Review) 01 Oct '17

01 Oct '17

Stefan Tauner has posted comments on this change. ( https://review.coreboot.org/21776 ) Change subject: Convert flashrom to git ...................................................................... Patch Set 2: I think you have missed some of the improvements of your own reviews in the rebase. This seemed to be a good opportunity to merge in my changes (without the version change) to make them reviewable - hope you don't mind the hijacking. -- To view, visit https://review.coreboot.org/21776 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: comment Gerrit-Change-Id: I08a324ce1fd8afcc6f516ddfb6f09e05a67cdd17 Gerrit-Change-Number: 21776 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Oct 2017 00:45:43 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[stable]: Convert flashrom to git
by build bot (Jenkins) (Code Review) 01 Oct '17

01 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21776 ) Change subject: Convert flashrom to git ...................................................................... Patch Set 2: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom-customrules/618/ : FAILURE https://qa.coreboot.org/job/flashrom_gerrit/563/ : SUCCESS -- To view, visit https://review.coreboot.org/21776 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: comment Gerrit-Change-Id: I08a324ce1fd8afcc6f516ddfb6f09e05a67cdd17 Gerrit-Change-Number: 21776 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 01 Oct 2017 00:42:20 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[stable]: Convert flashrom to git
by Stefan Tauner (Code Review) 01 Oct '17

01 Oct '17

Stefan Tauner has uploaded a new patch set (#2) to the change originally created by Nico Huber. ( https://review.coreboot.org/21776 ) Change subject: Convert flashrom to git ...................................................................... Convert flashrom to git - Drop support for Subversion in the getrevision script and Makefile. - Add .gitignore and .gitattributes file (the latter to limit exports). - Restore modification dates of the exported files from the SCM. - Stop exporting SCM log dumps to CHANGELOG. This makes no sense. - Export SCM metadata needed by the Makefile to Makefile.VCS - Do not export the pre-"compiled" manpage. It can be generated like anything else from the code dump with Makefile.VCS - Add some initial client-side git hooks that get installed automatically on make runs: * pre-commit: - test for white space errors via git diff-index --check * commit-msg: - Use the up to date hook from gerrit to add Change-Id tags. Unlike the upstream hook, add them to fixup/squash changes too to match our staging behavior. - Test for duplicate sign-offs. * When pushing to the upstream repository check mandatory rules: - existing signoffs and acks in all new commits - no deletions of branches - no branches other than stable, staging and versioned branches - do not rewrite history of branches, even if forced Original-Change-Id: I64eef21982cac0a0a7419bcd2c8a936672ae9cb2 Original-Reviewed-on: https://review.coreboot.org/19206 Original-Reviewed-by: Nico Huber <nico.h(a)gmx.de> Original-Reviewed-by: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Original-Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Change-Id: I08a324ce1fd8afcc6f516ddfb6f09e05a67cdd17 Signed-off-by: Stefan Tauner <stefan.tauner(a)gmx.at> Signed-off-by: David Hendricks <dhendricks(a)fb.com> Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- A .gitattributes A .gitignore M Makefile M flashrom.c M util/getrevision.sh A util/git-hooks/applypatch-msg A util/git-hooks/commit-msg A util/git-hooks/install.sh A util/git-hooks/pre-applypatch A util/git-hooks/pre-commit A util/git-hooks/pre-push A util/git-hooks/wrapper.sh 12 files changed, 437 insertions(+), 131 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/76/21776/2 -- To view, visit https://review.coreboot.org/21776 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: newpatchset Gerrit-Change-Id: I08a324ce1fd8afcc6f516ddfb6f09e05a67cdd17 Gerrit-Change-Number: 21776 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: Add modification date to manpage header instead of the section
by build bot (Jenkins) (Code Review) 01 Oct '17

01 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21822 ) Change subject: Add modification date to manpage header instead of the section ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom-customrules/617/ : FAILURE https://qa.coreboot.org/job/flashrom_gerrit/562/ : SUCCESS -- To view, visit https://review.coreboot.org/21822 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I45c5d6a2316c51a57a49fd010682dc3f0f915382 Gerrit-Change-Number: 21822 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Sep 2017 22:55:16 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add modification date to manpage header instead of the section
by Stefan Tauner (Code Review) 01 Oct '17

01 Oct '17

Stefan Tauner has uploaded this change for review. ( https://review.coreboot.org/21822 Change subject: Add modification date to manpage header instead of the section ...................................................................... Add modification date to manpage header instead of the section "System Manager's Manual" or similar is way less interesting. Change-Id: I45c5d6a2316c51a57a49fd010682dc3f0f915382 Signed-off-by: Stefan Tauner <stefan.tauner(a)gmx.at> --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/22/21822/1 diff --git a/Makefile b/Makefile index 6806e14..68b9e9c 100644 --- a/Makefile +++ b/Makefile @@ -1384,7 +1384,7 @@ $(PROGRAM).8: $(PROGRAM).8.tmpl @# Add the man page change date and version to the man page - @sed -e 's#.TH FLASHROM 8 ".*".*#.TH FLASHROM 8 "$(MAN_DATE)" "$(VERSION)"#' <$< >$@ + @sed -e 's#.TH FLASHROM 8 .*#.TH FLASHROM 8 "$(MAN_DATE)" "$(VERSION)" "$(MAN_DATE)"#' <$< >$@ install: $(PROGRAM)$(EXEC_SUFFIX) $(PROGRAM).8 mkdir -p $(DESTDIR)$(PREFIX)/sbin -- To view, visit https://review.coreboot.org/21822 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newchange Gerrit-Change-Id: I45c5d6a2316c51a57a49fd010682dc3f0f915382 Gerrit-Change-Number: 21822 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at>

1 0

Change in flashrom[stable]: ichspi: "Fix" access permission reporting for regions > 7
by build bot (Jenkins) (Code Review) 30 Sep '17

30 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21818 ) Change subject: ichspi: "Fix" access permission reporting for regions > 7 ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom-customrules/614/ : FAILURE https://qa.coreboot.org/job/flashrom_gerrit/559/ : SUCCESS -- To view, visit https://review.coreboot.org/21818 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: comment Gerrit-Change-Id: I59cce146c96e3c1f33b51265084c1352602ea5ac Gerrit-Change-Number: 21818 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Sep 2017 20:51:54 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[stable]: Move ich_layout from layout.h to ich_descriptors.h
by build bot (Jenkins) (Code Review) 30 Sep '17

30 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21820 ) Change subject: Move ich_layout from layout.h to ich_descriptors.h ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom-customrules/616/ : FAILURE https://qa.coreboot.org/job/flashrom_gerrit/561/ : SUCCESS -- To view, visit https://review.coreboot.org/21820 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: comment Gerrit-Change-Id: Ibcdf8ad694e88ffb14f70bb830ebd2a13d6cced8 Gerrit-Change-Number: 21820 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Sep 2017 20:51:53 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[stable]: chipset_enable: Add support for C620-series Lewisburg PCH
by build bot (Jenkins) (Code Review) 30 Sep '17

30 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21819 ) Change subject: chipset_enable: Add support for C620-series Lewisburg PCH ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom-customrules/613/ : FAILURE https://qa.coreboot.org/job/flashrom_gerrit/558/ : SUCCESS -- To view, visit https://review.coreboot.org/21819 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: comment Gerrit-Change-Id: Ia93f4616c9279173b5cd47be1999939aa2f02379 Gerrit-Change-Number: 21819 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Sep 2017 20:51:46 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[stable]: ich_descriptors: Use MAX_NUM_FLREGS for entries[]
by build bot (Jenkins) (Code Review) 30 Sep '17

30 Sep '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21821 ) Change subject: ich_descriptors: Use MAX_NUM_FLREGS for entries[] ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom-customrules/615/ : FAILURE https://qa.coreboot.org/job/flashrom_gerrit/560/ : SUCCESS -- To view, visit https://review.coreboot.org/21821 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: comment Gerrit-Change-Id: Ic6b658a1625620009ffd23e526093609a6b0baf8 Gerrit-Change-Number: 21821 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 30 Sep 2017 20:51:43 +0000 Gerrit-HasComments: No

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit