- flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: ichspi: Disable software sequencing by default for Skylake
by build bot (Jenkins) (Code Review) 01 Nov '17

01 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22274 ) Change subject: ichspi: Disable software sequencing by default for Skylake ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/712/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/806/ : SUCCESS -- To view, visit https://review.coreboot.org/22274 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I8a13fb9c3ca679b3f7d39ad1dc56d5efdc80045b Gerrit-Change-Number: 22274 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 01 Nov 2017 13:23:00 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: ichspi: Fix software sequencing for Skylake
by build bot (Jenkins) (Code Review) 01 Nov '17

01 Nov '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22273 ) Change subject: ichspi: Fix software sequencing for Skylake ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/711/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/805/ : SUCCESS -- To view, visit https://review.coreboot.org/22273 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I16eebcf37ab8ba39b02f33135535552e380b0b92 Gerrit-Change-Number: 22273 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 01 Nov 2017 13:22:47 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: ichspi: Disable software sequencing by default for Skylake
by Nico Huber (Code Review) 01 Nov '17

01 Nov '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/22274 Change subject: ichspi: Disable software sequencing by default for Skylake ...................................................................... ichspi: Disable software sequencing by default for Skylake Skylake is a mess, especially with coreboot. We have now a present and configured software sequencing interface with SCGO supposedly being readonly (Apollo Lake has that feature and a strap documented, Skylake behaviour might be the same). As we can't easily check if it's read- only, just enable hardware sequencing by default (even if the software sequencing interface seems usable). Change-Id: I8a13fb9c3ca679b3f7d39ad1dc56d5efdc80045b Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M ichspi.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/74/22274/1 diff --git a/ichspi.c b/ichspi.c index ec81628..859d55f 100644 --- a/ichspi.c +++ b/ichspi.c @@ -1951,6 +1951,11 @@ ich_spi_mode = ich_hwseq; } + if (ich_spi_mode == ich_auto && ich_gen == CHIPSET_100_SERIES_SUNRISE_POINT) { + msg_pdbg("Enabling hardware sequencing by default for 100 series PCH.\n"); + ich_spi_mode = ich_hwseq; + } + if (ich_spi_mode == ich_hwseq) { if (!desc_valid) { msg_perr("Hardware sequencing was requested " -- To view, visit https://review.coreboot.org/22274 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newchange Gerrit-Change-Id: I8a13fb9c3ca679b3f7d39ad1dc56d5efdc80045b Gerrit-Change-Number: 22274 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[staging]: ichspi: Fix software sequencing for Skylake
by Nico Huber (Code Review) 01 Nov '17

01 Nov '17

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/22273 Change subject: ichspi: Fix software sequencing for Skylake ...................................................................... ichspi: Fix software sequencing for Skylake Two occurences of ICH9_REG_OPMENU were overlooked and not replaced, rendering the software sequencing unusable on Skylake. Change-Id: I16eebcf37ab8ba39b02f33135535552e380b0b92 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M ichspi.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/73/22273/1 diff --git a/ichspi.c b/ichspi.c index 9d6b62b..ec81628 100644 --- a/ichspi.c +++ b/ichspi.c @@ -983,8 +983,8 @@ } /* Select opcode */ - opmenu = REGREAD32(ICH9_REG_OPMENU); - opmenu |= ((uint64_t)REGREAD32(ICH9_REG_OPMENU + 4)) << 32; + opmenu = REGREAD32(swseq_data.reg_opmenu); + opmenu |= ((uint64_t)REGREAD32(swseq_data.reg_opmenu + 4)) << 32; for (opcode_index = 0; opcode_index < 8; opcode_index++) { if ((opmenu & 0xff) == op.opcode) { -- To view, visit https://review.coreboot.org/22273 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newchange Gerrit-Change-Id: I16eebcf37ab8ba39b02f33135535552e380b0b92 Gerrit-Change-Number: 22273 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[staging]: vt_vx: check whether the chipset's MMIO range is configured
by Paul Menzel (Code Review) 01 Nov '17

01 Nov '17

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/22263 ) Change subject: vt_vx: check whether the chipset's MMIO range is configured ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/22263/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/22263/1//COMMIT_MSG@12 PS1, Line 12: Change-Id: I5d3a1ba695153e854e0979ae634f8ed97e6b6293 Is a line *Signed-off-by* needed? -- To view, visit https://review.coreboot.org/22263 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I5d3a1ba695153e854e0979ae634f8ed97e6b6293 Gerrit-Change-Number: 22263 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 01 Nov 2017 11:00:56 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: vt_vx: check whether the chipset's MMIO range is configured
by David Hendricks (Code Review) 01 Nov '17

01 Nov '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22263 ) Change subject: vt_vx: check whether the chipset's MMIO range is configured ...................................................................... Patch Set 1: Code-Review+1 Seems OK, but let's wait for others to chime in before applying +2 to this patch. -- To view, visit https://review.coreboot.org/22263 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I5d3a1ba695153e854e0979ae634f8ed97e6b6293 Gerrit-Change-Number: 22263 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 01 Nov 2017 05:51:02 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: vt_vx: check whether the chipset's MMIO range is configured
by build bot (Jenkins) (Code Review) 31 Oct '17

31 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22263 ) Change subject: vt_vx: check whether the chipset's MMIO range is configured ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/710/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/804/ : SUCCESS -- To view, visit https://review.coreboot.org/22263 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I5d3a1ba695153e854e0979ae634f8ed97e6b6293 Gerrit-Change-Number: 22263 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 31 Oct 2017 14:47:41 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: vt_vx: check whether the chipset's MMIO range is configured
by Lubomir Rintel (Code Review) 31 Oct '17

31 Oct '17

Lubomir Rintel has uploaded this change for review. ( https://review.coreboot.org/22263 Change subject: vt_vx: check whether the chipset's MMIO range is configured ...................................................................... vt_vx: check whether the chipset's MMIO range is configured Avoid attempting to read the SPI bases from the location 0x00000000, all zeroes mean that the chipset's MMIO area is not enabled. Change-Id: I5d3a1ba695153e854e0979ae634f8ed97e6b6293 --- M chipset_enable.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/63/22263/1 diff --git a/chipset_enable.c b/chipset_enable.c index 3437792..d8b579c 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1013,10 +1013,18 @@ switch(dev->device_id) { case 0x8353: /* VX800/VX820 */ spi0_mm_base = pci_read_long(dev, 0xbc) << 8; + if (spi0_mm_base == 0x0) { + msg_pdbg ("MMIO not enabled!\n"); + return ERROR_FATAL; + } break; case 0x8409: /* VX855/VX875 */ case 0x8410: /* VX900 */ mmio_base = pci_read_long(dev, 0xbc) << 8; + if (mmio_base == 0x0) { + msg_pdbg ("MMIO not enabled!\n"); + return ERROR_FATAL; + } mmio_base_physmapped = physmap("VIA VX MMIO register", mmio_base, SPI_CNTL_LEN); if (mmio_base_physmapped == ERROR_PTR) return ERROR_FATAL; -- To view, visit https://review.coreboot.org/22263 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: newchange Gerrit-Change-Id: I5d3a1ba695153e854e0979ae634f8ed97e6b6293 Gerrit-Change-Number: 22263 Gerrit-PatchSet: 1 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk>

1 0

Change in flashrom[staging]: Fix standalone ich_descriptor_tool compilation with MinGW and DJGPP
by Nico Huber (Code Review) 27 Oct '17

27 Oct '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21838 ) Change subject: Fix standalone ich_descriptor_tool compilation with MinGW and DJGPP ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/21838 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Id146f5ba06a0e510397c6f32a2bd7c819a405a25 Gerrit-Change-Number: 21838 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Oct 2017 22:25:22 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Fix standalone ich_descriptor_tool compilation with MinGW and DJGPP
by build bot (Jenkins) (Code Review) 26 Oct '17

26 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21838 ) Change subject: Fix standalone ich_descriptor_tool compilation with MinGW and DJGPP ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/709/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/803/ : SUCCESS -- To view, visit https://review.coreboot.org/21838 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Id146f5ba06a0e510397c6f32a2bd7c819a405a25 Gerrit-Change-Number: 21838 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 26 Oct 2017 16:46:01 +0000 Gerrit-HasComments: No

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit