- flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[main]: libflashrom: Allow getting the progress_state from the flashctx
by Peter Marheine (Code Review) 12 Nov '24

12 Nov '24

Attention is currently required from: Anastasia Klimchuk, Daniel Campello, Edward O'Callaghan, Nico Huber, Richard Hughes. Peter Marheine has posted comments on this change by Richard Hughes. ( https://review.coreboot.org/c/flashrom/+/64663?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: libflashrom: Allow getting the progress_state from the flashctx ...................................................................... Patch Set 5: (1 comment) File include/libflashrom.h: https://review.coreboot.org/c/flashrom/+/64663/comment/a9829e26_9bbb11df?us… : PS5, Line 108: struct flashrom_progress *flashrom_get_progress_state(struct flashrom_flashctx *flashctx); I wonder if this should be a `const struct flashrom_progress*` to indicate that we don't expect the caller to modify the progress information? It wouldn't be harmful if they did (at least with the current implementation), but I think it would be better to exclude mutability completely. -- To view, visit https://review.coreboot.org/c/flashrom/+/64663?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I322bf56ff92f7b4d0ffc92768e9f0cdf7cb82010 Gerrit-Change-Number: 64663 Gerrit-PatchSet: 5 Gerrit-Owner: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Daniel Campello <campello(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 12 Nov 2024 00:20:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: doc: Add few sections to recent development doc
by Anastasia Klimchuk (Code Review) 11 Nov '24

11 Nov '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/84954?usp=email ) Change subject: doc: Add few sections to recent development doc ...................................................................... doc: Add few sections to recent development doc Change-Id: Iedaca4a704c57c1db399c7888f743ad2961cbf9d Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/84954 Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M doc/release_notes/devel.rst 1 file changed, 78 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Peter Marheine: Looks good to me, approved diff --git a/doc/release_notes/devel.rst b/doc/release_notes/devel.rst index 02b4e24..7b21a99 100644 --- a/doc/release_notes/devel.rst +++ b/doc/release_notes/devel.rst @@ -77,6 +77,75 @@ It currently uses automatic feature detection through the corresponding sfdp page. +Programmer updates +=================== + +* ch347_spi: Add spi clock frequency selection ("spispeed" option) +* dummyflasher: Enable higher frequency emulation, add docs and tests +* ichspi: Change the opcode position for reprogramming on the fly 2->4 +* ichspi: Merge spi_master implementations for Intel ich + +Bugs fixed +========== + +* Modified bytes would sometimes not be verified after writing + + In some situations an off-by-one error would cause the last byte + of memory that was modified by an operation to not be verified. + This could prevent some erase or write errors from being detected, + or in other cases could make verification appear false-negative. + + Fixed by https://review.coreboot.org/c/flashrom/+/84078. + +* Possible crashes while preparing erase operations + + An out-of-bounds memory read was found in the algorithm that selects methods + to erase memory, which could cause flashrom to crash. This issue was first + introduced in release 1.4, and crashes were observed when running on OpenBSD. + + See https://ticket.coreboot.org/issues/555, and fixed by + https://review.coreboot.org/c/flashrom/+/84234. + +* Crash when attempting to erase FEATURE_NO_ERASE chips + + When attempting to erase a chip that doesn't need to be erased before + being written, flashrom could attempt to read through a null pointer + and crash. The only supported chip that is affected is the M95M02 + EEPROM. + + See https://ticket.coreboot.org/issues/553, and fixed by + https://review.coreboot.org/c/flashrom/+/84203. + +* install failures related to libcmocka + + In some configurations, the install target provided by the buildsystem (like + meson install) would fail to execute successfully due to a missing libcmocka + file. This is fixed by not installing libcmocka, because it is a third-party + library used by flashrom only for testing. + + See https://ticket.coreboot.org/issues/561, and fixed by + https://review.coreboot.org/c/flashrom/+/84557. + +* Excess erase of automatically-probed chips on Intel chipsets + + When erasing some chips using the ichspi programmer (for Intel ICH chipsets), + the entire chip would be erased and rewritten even when the hardware supported + erasing smaller blocks, causing operations to take longer to complete and + negatively impacting chip longevity. This issue was first introduced in version + 1.4. + + See https://ticket.coreboot.org/issues/556, and fixed by + https://review.coreboot.org/c/flashrom/+/84253. + +* Unnecessary erases + + When erasing parts of a memory, some blocks could be erased and rewritten + unnecessarily or erased multiple times which could hurt the longevity of + the memory chip. This behavior was introduced in version 1.4. + + Fixed by https://review.coreboot.org/c/flashrom/+/84614 and + https://review.coreboot.org/c/flashrom/+/84686. + Chipset support =============== @@ -124,3 +193,12 @@ * XM25QU256D * XM25QU512C * XM25QU512D + +Misc +========= + +* reduce DELAY_MINIMUM_SLEEP_US to 100 by default +* tests: Add assert for eraseblocks order of invocations for write op +* VERSION: Change name pattern to match tag name from now on +* writeprotect: Fix inaccurate return code +* erasure_layout: Fix unreachable error message -- To view, visit https://review.coreboot.org/c/flashrom/+/84954?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iedaca4a704c57c1db399c7888f743ad2961cbf9d Gerrit-Change-Number: 84954 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in flashrom[main]: doc: Add few sections to recent development doc
by Peter Marheine (Code Review) 11 Nov '24

11 Nov '24

Attention is currently required from: Anastasia Klimchuk. Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/84954?usp=email ) Change subject: doc: Add few sections to recent development doc ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/84954?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iedaca4a704c57c1db399c7888f743ad2961cbf9d Gerrit-Change-Number: 84954 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 11 Nov 2024 22:38:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in flashrom[main]: build script: Add rpmc option to always be enabled on Jenkins
by Stefan Reinauer (Code Review) 11 Nov '24

11 Nov '24

Attention is currently required from: Anastasia Klimchuk, Martin L Roth. Stefan Reinauer has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85097?usp=email ) Change subject: build script: Add rpmc option to always be enabled on Jenkins ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/85097?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib736386a34d184f696a47272957b665c8fe26c06 Gerrit-Change-Number: 85097 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matti Finder <matti.finder(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 11 Nov 2024 19:17:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: Rename cli_classic.h to a more adequate cli_getop.h
by Antonio Vázquez Blanco (Code Review) 11 Nov '24

11 Nov '24

Attention is currently required from: Anastasia Klimchuk. Antonio Vázquez Blanco has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/85072?usp=email ) Change subject: Rename cli_classic.h to a more adequate cli_getop.h ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: All done now! :) File cli_getopt.c: https://review.coreboot.org/c/flashrom/+/85072/comment/3443bfd8_766de37c?us… : PS2, Line 35: #include <flash.h> > Let's keep this line as it was […] Acknowledged -- To view, visit https://review.coreboot.org/c/flashrom/+/85072?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iaceeabedc26e93147d8122376d88e730aad1e355 Gerrit-Change-Number: 85072 Gerrit-PatchSet: 3 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 11 Nov 2024 14:47:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: Rename cli_classic.h to a more adequate cli_getop.h
by Antonio Vázquez Blanco (Code Review) 11 Nov '24

11 Nov '24

Attention is currently required from: Antonio Vázquez Blanco. Hello Anastasia Klimchuk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/85072?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: Rename cli_classic.h to a more adequate cli_getop.h ...................................................................... Rename cli_classic.h to a more adequate cli_getop.h The header only defines getop related stuff so it seems more intuitive this way. Change-Id: Iaceeabedc26e93147d8122376d88e730aad1e355 Signed-off-by: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> --- M cli_classic.c M cli_getopt.c R include/cli_getopt.h 3 files changed, 11 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/72/85072/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/85072?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iaceeabedc26e93147d8122376d88e730aad1e355 Gerrit-Change-Number: 85072 Gerrit-PatchSet: 3 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com>

1 0

[XS] Change in flashrom[main]: flashchips: Skip "WP untested" message for SFDP-capable chip
by Matti Finder (Code Review) 11 Nov '24

11 Nov '24

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Sergii Dmytruk, Stefan Reinauer. Matti Finder has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85075?usp=email ) Change subject: flashchips: Skip "WP untested" message for SFDP-capable chip ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Since the feature is not supported currently, I am wondering if maybe a test_state of NA (Not applicable) for the write protect feature is more representative of what we want it to mean. -- To view, visit https://review.coreboot.org/c/flashrom/+/85075?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7e945389895a8042df3aaae72bccf73405be8651 Gerrit-Change-Number: 85075 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Mon, 11 Nov 2024 14:33:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: sfdp: Update the message shown when SFDP-capable chip is detected
by Matti Finder (Code Review) 11 Nov '24

11 Nov '24

Attention is currently required from: Anastasia Klimchuk. Matti Finder has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85092?usp=email ) Change subject: sfdp: Update the message shown when SFDP-capable chip is detected ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/85092?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If1a480ae78f158cc4626e345149ea9025443f8a7 Gerrit-Change-Number: 85092 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matti Finder <matti.finder(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 11 Nov 2024 12:47:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: Rename cli_classic.h to a more adequate cli_getop.h
by Anastasia Klimchuk (Code Review) 11 Nov '24

11 Nov '24

Attention is currently required from: Antonio Vázquez Blanco. Anastasia Klimchuk has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/85072?usp=email ) Change subject: Rename cli_classic.h to a more adequate cli_getop.h ...................................................................... Patch Set 2: (2 comments) File cli_getopt.c: https://review.coreboot.org/c/flashrom/+/85072/comment/19c1e84f_e07deba2?us… : PS1, Line 28: #include "cli_getopt.h" > Sorry, this is even subconscious for me. I do this because cli_getopt. […] Thank you for explanation! This is useful for me. Agree to keep cli_getop.h line as you did. I mark this one resolved, I added one last comment below. File cli_getopt.c: https://review.coreboot.org/c/flashrom/+/85072/comment/9cd78fad_566b69c7?us… : PS2, Line 35: #include <flash.h> Let's keep this line as it was > #include "flash.h" Since this include is not related to the goal of the patch, let's not change this line. -- To view, visit https://review.coreboot.org/c/flashrom/+/85072?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iaceeabedc26e93147d8122376d88e730aad1e355 Gerrit-Change-Number: 85072 Gerrit-PatchSet: 2 Gerrit-Owner: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Gerrit-Comment-Date: Mon, 11 Nov 2024 10:24:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Antonio Vázquez Blanco <antoniovazquezblanco(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: flashchips: Update test status for Spansion S25FL256L
by Anastasia Klimchuk (Code Review) 11 Nov '24

11 Nov '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/85004?usp=email ) Change subject: flashchips: Update test status for Spansion S25FL256L ...................................................................... flashchips: Update test status for Spansion S25FL256L Tested probe, read, erase, write on S25FL256LAMF01 chip using linux_spi and dediprog (SF100) programmers. Change-Id: I9e934791cd8d96c2cb926fd310ec48ec2ab2d1e3 Signed-off-by: Anton Samsonov <devel(a)zxlab.ru> Reviewed-on: https://review.coreboot.org/c/flashrom/+/85004 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 742e017..73b4036 100644 --- a/flashchips.c +++ b/flashchips.c @@ -19165,7 +19165,7 @@ /* 4 x 256B Security Region (OTP) */ .feature_bits = FEATURE_WRSR_WREN | FEATURE_WRSR_EXT3 | FEATURE_OTP | FEATURE_4BA_ENTER | FEATURE_4BA_NATIVE, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = PROBE_SPI_RDID, .probe_timing = TIMING_ZERO, .block_erasers = -- To view, visit https://review.coreboot.org/c/flashrom/+/85004?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I9e934791cd8d96c2cb926fd310ec48ec2ab2d1e3 Gerrit-Change-Number: 85004 Gerrit-PatchSet: 2 Gerrit-Owner: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit