- flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: fixup! Convert flashrom to git
by Nico Huber (Code Review) 03 Oct '17

03 Oct '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/21834 ) Change subject: fixup! Convert flashrom to git ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/21834/1/util/git-hooks/pre-push File util/git-hooks/pre-push: https://review.coreboot.org/#/c/21834/1/util/git-hooks/pre-push@34 PS1, Line 34: $\([0-9]\+\.$\+$[0-9]\+$\)$ > Outer parentheses: because that's needed when using the matching expression Same paragraph mentions ^ is implicit and unclear what happens if you use it. So better leave it out. Shorter alternative: $\([0-9]\+\.$\{2,\}x\)$ -- To view, visit https://review.coreboot.org/21834 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I1d4b4a7ef2673cabee980ec4a7d7d5fbebdcaed1 Gerrit-Change-Number: 21834 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 03 Oct 2017 13:08:11 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: fixup! nicintel_eeprom: Support for I210 emulated EEprom
by David Hendricks (Code Review) 03 Oct '17

03 Oct '17

David Hendricks has submitted this change and it was merged. ( https://review.coreboot.org/21702 ) Change subject: fixup! nicintel_eeprom: Support for I210 emulated EEprom ...................................................................... fixup! nicintel_eeprom: Support for I210 emulated EEprom A couple of C99-style variable declarations within loops are causing compilation failures on some systems (gcc 4.9.2-10 on Raspbian). This moves them to make gcc happy. Change-Id: Ib7ad5a69244e462f84eae93df9e841716e089b31 Signed-off-by: David Hendricks <david.hendricks(a)gmail.com> Reviewed-on: https://review.coreboot.org/21702 Reviewed-by: Nico Huber <nico.h(a)gmx.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M nicintel_eeprom.c 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Nico Huber: Looks good to me, approved build bot (Jenkins): Verified diff --git a/nicintel_eeprom.c b/nicintel_eeprom.c index e2fb584..e4a91ef 100644 --- a/nicintel_eeprom.c +++ b/nicintel_eeprom.c @@ -211,7 +211,8 @@ pci_mmio_writel(eewr, nicintel_eebar + EEWR); programmer_delay(5); - for (int i = 0; i < MAX_ATTEMPTS; i++) + int i; + for (i = 0; i < MAX_ATTEMPTS; i++) if (pci_mmio_readl(nicintel_eebar + EEWR) & BIT(EEWR_DONE)) return 0; return -1; @@ -419,7 +420,8 @@ flup |= BIT(EE_FLUPD); pci_mmio_writel(flup, nicintel_eebar + EEC); - for (int i = 0; i < MAX_ATTEMPTS; i++) + int i; + for (i = 0; i < MAX_ATTEMPTS; i++) if (pci_mmio_readl(nicintel_eebar + EEC) & BIT(EE_FLUDONE)) return 0; -- To view, visit https://review.coreboot.org/21702 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: merged Gerrit-Change-Id: Ib7ad5a69244e462f84eae93df9e841716e089b31 Gerrit-Change-Number: 21702 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[staging]: fixup! Convert flashrom to git
by Stefan Tauner (Code Review) 03 Oct '17

03 Oct '17

Stefan Tauner has posted comments on this change. ( https://review.coreboot.org/21834 ) Change subject: fixup! Convert flashrom to git ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/21834/1/util/git-hooks/pre-push File util/git-hooks/pre-push: https://review.coreboot.org/#/c/21834/1/util/git-hooks/pre-push@34 PS1, Line 34: $\([0-9]\+\.$\+$[0-9]\+$\)$ > Why the outer-most parentheses? Why not start with ^ ? and didn't Outer parentheses: because that's needed when using the matching expression of expr: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/expr.html#tag_20_… ^ is a good idea, no idea why it's not already there. Not sure about the last question... that 'x' is a literal one i presume. Works for me... so this would be '$^\([0-9]\+\.$\+$[0-9]\+$\.x\)$' https://review.coreboot.org/#/c/21834/1/util/git-hooks/pre-push@51 PS1, Line 51: echo "Neither \"Signed-off-by\" nor \"Acked-by\" were found in commit $local_sha in " \ > Both Signed-off-by and Acked-by have to be present, don't they? this Right. Or to be more precise: this is a wrong intermediate wording from an earlier patch set of David. I should have left his last version as is, sorry. -- To view, visit https://review.coreboot.org/21834 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I1d4b4a7ef2673cabee980ec4a7d7d5fbebdcaed1 Gerrit-Change-Number: 21834 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Oct 2017 23:59:15 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: flashchips: Add ISSI IS25WP128
by build bot (Jenkins) (Code Review) 03 Oct '17

03 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19532 ) Change subject: flashchips: Add ISSI IS25WP128 ...................................................................... Patch Set 1: Build Failed https://qa.coreboot.org/job/flashrom_gerrit/642/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/698/ : SUCCESS -- To view, visit https://review.coreboot.org/19532 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ia31764f0bf3ba1ed609f83b95e21343d7c23a508 Gerrit-Change-Number: 19532 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Oct 2017 23:05:39 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: fixup! nicintel_eeprom: Support for I210 emulated EEprom
by build bot (Jenkins) (Code Review) 03 Oct '17

03 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21702 ) Change subject: fixup! nicintel_eeprom: Support for I210 emulated EEprom ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/640/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/696/ : SUCCESS -- To view, visit https://review.coreboot.org/21702 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ib7ad5a69244e462f84eae93df9e841716e089b31 Gerrit-Change-Number: 21702 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Oct 2017 23:05:39 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[stable]: Convert flashrom to git
by build bot (Jenkins) (Code Review) 03 Oct '17

03 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21776 ) Change subject: Convert flashrom to git ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/636/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/692/ : SUCCESS -- To view, visit https://review.coreboot.org/21776 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: comment Gerrit-Change-Id: I08a324ce1fd8afcc6f516ddfb6f09e05a67cdd17 Gerrit-Change-Number: 21776 Gerrit-PatchSet: 2 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Oct 2017 23:05:38 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add initial J-Link SPI programmer
by build bot (Jenkins) (Code Review) 03 Oct '17

03 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19994 ) Change subject: Add initial J-Link SPI programmer ...................................................................... Patch Set 4: Build Failed https://qa.coreboot.org/job/flashrom_gerrit/641/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/697/ : SUCCESS -- To view, visit https://review.coreboot.org/19994 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ie03a054a75457ec9e1cab36ea124bb53b10e8d7e Gerrit-Change-Number: 19994 Gerrit-PatchSet: 4 Gerrit-Owner: Marc Schink <flashrom-dev(a)marcschink.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Oct 2017 23:05:38 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[stable]: util: Add CH341a to z60_flashrom.rules
by build bot (Jenkins) (Code Review) 03 Oct '17

03 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21778 ) Change subject: util: Add CH341a to z60_flashrom.rules ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/639/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/695/ : SUCCESS -- To view, visit https://review.coreboot.org/21778 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: comment Gerrit-Change-Id: Id1ceebbf406f81a28bd6dae44acd6e569e0c834c Gerrit-Change-Number: 21778 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Oct 2017 23:05:38 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[stable]: Add iMac5, 2 to board_enable
by build bot (Jenkins) (Code Review) 03 Oct '17

03 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21779 ) Change subject: Add iMac5,2 to board_enable ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/638/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/694/ : SUCCESS -- To view, visit https://review.coreboot.org/21779 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: comment Gerrit-Change-Id: I618e27f8e726f40ab305b68af2bb31ffd7d96408 Gerrit-Change-Number: 21779 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Oct 2017 23:05:38 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[stable]: Remove djgpp-dos target
by build bot (Jenkins) (Code Review) 03 Oct '17

03 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21777 ) Change subject: Remove djgpp-dos target ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/637/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/693/ : SUCCESS -- To view, visit https://review.coreboot.org/21777 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: comment Gerrit-Change-Id: I81598358f85443d1d53c9fdf5c5ae705ef360c0d Gerrit-Change-Number: 21777 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Oct 2017 23:05:38 +0000 Gerrit-HasComments: No

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit