- flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: flashchips: Add ISSI IS25LP128 and IS25WP128
by David Hendricks (Code Review) 08 Dec '17

08 Dec '17

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/22783 to look at the new patch set (#2). Change subject: flashchips: Add ISSI IS25LP128 and IS25WP128 ...................................................................... flashchips: Add ISSI IS25LP128 and IS25WP128 IS25LP128 is the 3.3V variant, IS25WP128 is the 1.8V variant. Tested read, erase, and write using Dediprog SF600 on each. Change-Id: Ia31764f0bf3ba1ed609f83b95e21343d7c23a508 Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M flashchips.c M flashchips.h 2 files changed, 43 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/22783/2 -- To view, visit https://review.coreboot.org/22783 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia31764f0bf3ba1ed609f83b95e21343d7c23a508 Gerrit-Change-Number: 22783 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: flashchips: Add ISSI IS25LP128 IS25WP128
by build bot (Jenkins) (Code Review) 08 Dec '17

08 Dec '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22783 ) Change subject: flashchips: Add ISSI IS25LP128 IS25WP128 ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom_gerrit/799/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/912/ : SUCCESS -- To view, visit https://review.coreboot.org/22783 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia31764f0bf3ba1ed609f83b95e21343d7c23a508 Gerrit-Change-Number: 22783 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 08 Dec 2017 07:02:11 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[master]: flashchips: Add ISSI IS25LP128 IS25WP128
by David Hendricks (Code Review) 08 Dec '17

08 Dec '17

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/22783 Change subject: flashchips: Add ISSI IS25LP128 IS25WP128 ...................................................................... flashchips: Add ISSI IS25LP128 IS25WP128 IS25LP128 is the 3.3V variant, IS25WP128 is the 1.8V variant. Tested read, erase, and write using Dediprog SF600 on each. Change-Id: Ia31764f0bf3ba1ed609f83b95e21343d7c23a508 Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M flashchips.c M flashchips.h 2 files changed, 43 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/83/22783/1 diff --git a/flashchips.c b/flashchips.c index a1ad445..3d60a68 100644 --- a/flashchips.c +++ b/flashchips.c @@ -7082,6 +7082,47 @@ { .vendor = "ISSI", + .name = "IS25WP128", + .bustype = BUS_SPI, + .manufacture_id = ISSI_ID_SPI, + .model_id = ISSI_IS25WP128, + .total_size = 16384, + .page_size = 256, + /* OTP: 1024B total; read 0x48; write 0x42 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_UNBOUND_READ | FEATURE_OTP, + .tested = TEST_OK_PREWU, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 4096} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {4 * 1024, 4096} }, + .block_erase = spi_block_erase_d7, + }, { + .eraseblocks = { {32 * 1024, 512} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 256} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {1650, 1950}, + }, + + { + .vendor = "ISSI", .name = "IS29GL064B", .bustype = BUS_PARALLEL, .manufacture_id = ISSI_ID, diff --git a/flashchips.h b/flashchips.h index 62eb9a5..de9f3e7 100644 --- a/flashchips.h +++ b/flashchips.h @@ -452,6 +452,8 @@ #define SHARP_LH28F008SC 0xA6 /* Sharp chip, Intel Vendor ID */ #define ISSI_ID 0xD5 /* ISSI Integrated Silicon Solutions, see also PMC. */ +#define ISSI_ID_SPI 0x9D /* ISSI ID used for SPI flash, see also PMC_ID_NOPREFIX */ +#define ISSI_IS25WP128 0x7018 #define ISSI_PMC_IS29GL032B 0xF9 #define ISSI_PMC_IS29GL032T 0xF6 #define ISSI_PMC_IS29GL064B 0x7E1000 -- To view, visit https://review.coreboot.org/22783 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ia31764f0bf3ba1ed609f83b95e21343d7c23a508 Gerrit-Change-Number: 22783 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[staging]: Enable writes with active ME
by Stefan Reinauer (Code Review) 07 Dec '17

07 Dec '17

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/18740 ) Change subject: Enable writes with active ME ...................................................................... Patch Set 15: Code-Review+2 Did we ever come to a conclusion? -- To view, visit https://review.coreboot.org/18740 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I94a5e7074b845c227e43d76d04dd1a71082a1cef Gerrit-Change-Number: 18740 Gerrit-PatchSet: 15 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 19:37:37 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[stable]: dediprog: Fix bug where too many transfers would be queued
by Stefan Reinauer (Code Review) 07 Dec '17

07 Dec '17

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/21781 ) Change subject: dediprog: Fix bug where too many transfers would be queued ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21781 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: comment Gerrit-Change-Id: Ie0d516f0fb2923a772a0ca7020ca5118ab260dc5 Gerrit-Change-Number: 21781 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 19:34:19 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[stable]: Remove undefined behavior
by Stefan Reinauer (Code Review) 07 Dec '17

07 Dec '17

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/21782 ) Change subject: Remove undefined behavior ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21782 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: comment Gerrit-Change-Id: Ib8bb468622fa158d3bf5ef797049ecb549cc1f40 Gerrit-Change-Number: 21782 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 19:34:17 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[stable]: hwaccess: Constify `addr` argument of MMIO read functions
by Stefan Reinauer (Code Review) 07 Dec '17

07 Dec '17

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/21784 ) Change subject: hwaccess: Constify `addr` argument of MMIO read functions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21784 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: comment Gerrit-Change-Id: I9158e8a7b994fe84e71a39483db651843adcf892 Gerrit-Change-Number: 21784 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 19:34:15 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[stable]: Make image parameter of cb_check_image const
by Stefan Reinauer (Code Review) 07 Dec '17

07 Dec '17

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/21783 ) Change subject: Make image parameter of cb_check_image const ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21783 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: comment Gerrit-Change-Id: I605386b6e903acfce85b19ad1e029e62e88df839 Gerrit-Change-Number: 21783 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 19:34:13 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[stable]: Move register decodes into enable_flash_ich_handle_gcs()
by Stefan Reinauer (Code Review) 07 Dec '17

07 Dec '17

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/21785 ) Change subject: Move register decodes into enable_flash_ich_handle_gcs() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21785 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: comment Gerrit-Change-Id: Ia4b77af1b135ec0caee9405684f18f6314715722 Gerrit-Change-Number: 21785 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 19:34:10 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[stable]: Add a convenient libflashrom interface
by Stefan Reinauer (Code Review) 07 Dec '17

07 Dec '17

Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/21788 ) Change subject: Add a convenient libflashrom interface ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21788 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: stable Gerrit-MessageType: comment Gerrit-Change-Id: Ibe14c89c96e45ed7679332b0f5cf44b1c9f1d9ee Gerrit-Change-Number: 21788 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 07 Dec 2017 19:34:08 +0000 Gerrit-HasComments: No

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit