- flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: buspirate_spi: Add support for variable serial speeds
by Shawn Anastasio (Code Review) 21 Jan '18

21 Jan '18

Shawn Anastasio has posted comments on this change. ( https://review.coreboot.org/23057 ) Change subject: buspirate_spi: Add support for variable serial speeds ...................................................................... Patch Set 6: (3 comments) https://review.coreboot.org/#/c/23057/6/buspirate_spi.c File buspirate_spi.c: https://review.coreboot.org/#/c/23057/6/buspirate_spi.c@443 PS6, Line 443: 5.5 > Where is this written? This page talks about 5.2: […] Firmware versions 5.2-5.4 do support setting custom baud rates, but without the improved SPI mode in 5.5 you run into a lot of buffer overruns which slow down the read/write and defeat the purpose of increasing the baud rate. https://review.coreboot.org/#/c/23057/6/buspirate_spi.c@451 PS6, Line 451: " Continue at your own risk.\n"); > I did some research, v2 can work with the same firmware and uses the […] This repository which seems to contain the latest firmware states that only boards v3 and v4 are supported: https://github.com/BusPirate/Bus_Pirate. I could still remove the warning if you'd like, but I think leaving it there until someone with a v2 comes along and tests it isn't a bad idea. https://review.coreboot.org/#/c/23057/6/buspirate_spi.c@473 PS6, Line 473: sleep(1); > Is this specified somewhere? It seems incredibly long. It's really just a safe value. I could try to optimize it to the lowest value that works on my v3 but I'm not sure if it's worth it, especially if it causes breakage on other models. -- To view, visit https://review.coreboot.org/23057 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3706f17a94fdf056063f2ad4a5f0a219665cdcbf Gerrit-Change-Number: 23057 Gerrit-PatchSet: 6 Gerrit-Owner: Shawn Anastasio <shawnanastasio(a)yahoo.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Shawn Anastasio <shawnanastasio(a)yahoo.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 21 Jan 2018 22:37:49 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: [NOTFORMERGE] Do not try to map SPI flash chips
by build bot (Jenkins) (Code Review) 21 Jan '18

21 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23344 ) Change subject: [NOTFORMERGE] Do not try to map SPI flash chips ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1060/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/906/ : SUCCESS -- To view, visit https://review.coreboot.org/23344 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I57350f65211b4c0ae2a285ee1b1151a6e6bfa031 Gerrit-Change-Number: 23344 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 21 Jan 2018 14:19:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: [NOTFORMERGE] Do not try to map SPI flash chips
by Nico Huber (Code Review) 21 Jan '18

21 Jan '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/23344 Change subject: [NOTFORMERGE] Do not try to map SPI flash chips ...................................................................... [NOTFORMERGE] Do not try to map SPI flash chips Trying to map SPI chips seems superfluous and might not work at all. Though, it would require a very deep investigation to find out if this is always the case for all programmers. If somebody has the time for that, it's probably better spent on (re)moving the mapping stuff altogether. Change-Id: I57350f65211b4c0ae2a285ee1b1151a6e6bfa031 Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M flashrom.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/44/23344/1 diff --git a/flashrom.c b/flashrom.c index ac987fd..a8bef3a 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1111,6 +1111,10 @@ void unmap_flash(struct flashctx *flash) { + /* FIXME: The whole (un)mapping should be handled at programmer level. */ + if ((flash->chip->bustype & BUS_NONSPI) == 0) + return; + if (flash->virtual_registers != (chipaddr)ERROR_PTR) { programmer_unmap_flash_region((void *)flash->virtual_registers, flash->chip->total_size * 1024); flash->physical_registers = 0; @@ -1126,6 +1130,10 @@ int map_flash(struct flashctx *flash) { + /* FIXME: The whole (un)mapping should be handled at programmer level. */ + if ((flash->chip->bustype & BUS_NONSPI) == 0) + return 0; + /* Init pointers to the fail-safe state to distinguish them later from legit values. */ flash->virtual_memory = (chipaddr)ERROR_PTR; flash->virtual_registers = (chipaddr)ERROR_PTR; -- To view, visit https://review.coreboot.org/23344 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I57350f65211b4c0ae2a285ee1b1151a6e6bfa031 Gerrit-Change-Number: 23344 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: layout: Add -i <region>[:<file>] support.
by David Hendricks (Code Review) 21 Jan '18

21 Jan '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/23021 ) Change subject: layout: Add -i <region>[:<file>] support. ...................................................................... Patch Set 7: (3 comments) https://review.coreboot.org/#/c/23021/5/flashrom.c File flashrom.c: https://review.coreboot.org/#/c/23021/5/flashrom.c@1379 PS5, Line 1379: > I could think of a future use that might be useful if/once fmap support is implemented: if you use a […] More specifically, to make sure that the include args for write operations don't overlap. For reading it should be fine. https://review.coreboot.org/#/c/23021/7/flashrom.c File flashrom.c: https://review.coreboot.org/#/c/23021/7/flashrom.c@1380 PS7, Line 1380: if (!entry->included || !entry->file) : continue; > Optionally: […] Actually, I don't think we should check for entry->file here. Doing so will require that all included entries have a file specified which is not always desirable. The higher-level logic should check if an argument to -w was specified to decide what to do here: - If a file is specified for -w, then we do not need a file specified for each -i arg. - If a file is not specified for -w, then we need a file specified for each -i arg. Removing the check here will also obviate the need for my get_num_include_args_with_files() hack in PS11. https://review.coreboot.org/#/c/23021/11/layout.c File layout.c: https://review.coreboot.org/#/c/23021/11/layout.c@174 PS11, Line 174: Use the -l/--layout parameter to specify\n" : "a layout file. We should probably clarify this comment or get rid of the latter half since the layout can come from a few different sources (layout file, IFD, and soon FMAP). -- To view, visit https://review.coreboot.org/23021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99 Gerrit-Change-Number: 23021 Gerrit-PatchSet: 7 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 21 Jan 2018 09:00:11 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[staging]: util/getrevision.sh: Change version string
by David Hendricks (Code Review) 21 Jan '18

21 Jan '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/20263 ) Change subject: util/getrevision.sh: Change version string ...................................................................... Patch Set 1: No longer needed. -- To view, visit https://review.coreboot.org/20263 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Id6de60be4c751c070d4da648825a7e7b70e4a759 Gerrit-Change-Number: 20263 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 21 Jan 2018 07:38:59 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[staging]: Make coreboot.org the upstream server
by David Hendricks (Code Review) 21 Jan '18

21 Jan '18

David Hendricks has abandoned this change. ( https://review.coreboot.org/19187 ) Change subject: Make coreboot.org the upstream server ...................................................................... Abandoned No longer needed. -- To view, visit https://review.coreboot.org/19187 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: abandon Gerrit-Change-Id: I9461dc4d2d461fff253392c4a1249a8835d5c9a4 Gerrit-Change-Number: 19187 Gerrit-PatchSet: 5 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: layout: Add -i <region>[:<file>] support.
by David Hendricks (Code Review) 21 Jan '18

21 Jan '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/23021 ) Change subject: layout: Add -i <region>[:<file>] support. ...................................................................... Patch Set 11: (2 comments) https://review.coreboot.org/#/c/23021/7/flashrom.c File flashrom.c: https://review.coreboot.org/#/c/23021/7/flashrom.c@2647 PS7, Line 2647: if (read_buf_from_file(newcontents, flash_size, filename, "the flash chip's size")) > Looking back, this seems to have been messed up in translation. My fault. […] Fixed in subsequent patch sets by removing the else and reading files from '-i' args if specified. https://review.coreboot.org/#/c/23021/11/flashrom.c File flashrom.c: https://review.coreboot.org/#/c/23021/11/flashrom.c@2683 PS11, Line 2683: get_num_include_args_with_files(get_layout I needed to add this to avoid 'Error: No image file given for region ...' in read_buf_from_include_args(). -- To view, visit https://review.coreboot.org/23021 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99 Gerrit-Change-Number: 23021 Gerrit-PatchSet: 11 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006(a)gmx.net> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicola Corna <nicola(a)corna.info> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 21 Jan 2018 02:51:16 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Copy test_v2 directory from chromiumos branch
by build bot (Jenkins) (Code Review) 21 Jan '18

21 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23023 ) Change subject: Copy test_v2 directory from chromiumos branch ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1058/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/904/ : SUCCESS -- To view, visit https://review.coreboot.org/23023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41bef98d32df61af400ecac46ea9571e722b2ac6 Gerrit-Change-Number: 23023 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 21 Jan 2018 02:32:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: test_v2.sh: Copy layout to local tempdir in local-layout mode
by build bot (Jenkins) (Code Review) 21 Jan '18

21 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23024 ) Change subject: test_v2.sh: Copy layout to local tempdir in local-layout mode ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1059/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/905/ : SUCCESS -- To view, visit https://review.coreboot.org/23024 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2328d367ee3df5ac1c481c16e4502a81d69fd98 Gerrit-Change-Number: 23024 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 21 Jan 2018 02:32:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Hack up test_v2.sh to work better with upstream
by build bot (Jenkins) (Code Review) 21 Jan '18

21 Jan '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23025 ) Change subject: Hack up test_v2.sh to work better with upstream ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1057/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/903/ : SUCCESS -- To view, visit https://review.coreboot.org/23025 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ace99fdb8d779804fe1887fe49f6409f8aff02e Gerrit-Change-Number: 23025 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 21 Jan 2018 02:32:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit