- flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: ch341a_spi: Avoid deprecated libusb functions
by Paul Menzel (Code Review) 15 Apr '18

15 Apr '18

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/25681 ) Change subject: ch341a_spi: Avoid deprecated libusb functions ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://review.coreboot.org/#/c/25681/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/25681/1//COMMIT_MSG@9 PS1, Line 9: libusb 1.0.22 marked libusb_set_debug as deprecated. Use : libusb_set_option instead for newer versions of libusb. Please use the full line length of 72 characters. -- To view, visit https://review.coreboot.org/25681 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib71ebe812316eaf49136979a942a946ef9e4d487 Gerrit-Change-Number: 25681 Gerrit-PatchSet: 1 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 15 Apr 2018 12:00:00 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: ch341a_spi: Avoid deprecated libusb functions
by build bot (Jenkins) (Code Review) 14 Apr '18

14 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25681 ) Change subject: ch341a_spi: Avoid deprecated libusb functions ...................................................................... Patch Set 1: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/1035/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1247/ : SUCCESS -- To view, visit https://review.coreboot.org/25681 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib71ebe812316eaf49136979a942a946ef9e4d487 Gerrit-Change-Number: 25681 Gerrit-PatchSet: 1 Gerrit-Owner: Alex James <theracermaster(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 15 Apr 2018 04:01:10 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: ch341a_spi: Avoid deprecated libusb functions
by Alex James (Code Review) 14 Apr '18

14 Apr '18

Alex James has uploaded this change for review. ( https://review.coreboot.org/25681 Change subject: ch341a_spi: Avoid deprecated libusb functions ...................................................................... ch341a_spi: Avoid deprecated libusb functions libusb 1.0.22 marked libusb_set_debug as deprecated. Use libusb_set_option instead for newer versions of libusb. Change-Id: Ib71ebe812316eaf49136979a942a946ef9e4d487 Signed-off-by: Alex James <theracermaster(a)gmail.com> --- M ch341a_spi.c 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/25681/1 diff --git a/ch341a_spi.c b/ch341a_spi.c index 2253e43..ce159b3 100644 --- a/ch341a_spi.c +++ b/ch341a_spi.c @@ -445,7 +445,12 @@ return -1; } - libusb_set_debug(NULL, 3); // Enable information, warning and error messages (only). + /* Enable information, warning, and error messages (only). */ +#if LIBUSB_API_VERSION < 0x01000106 + libusb_set_debug(NULL, 3); +#else + libusb_set_option(NULL, LIBUSB_OPTION_LOG_LEVEL, LIBUSB_LOG_LEVEL_INFO); +#endif uint16_t vid = devs_ch341a_spi[0].vendor_id; uint16_t pid = devs_ch341a_spi[0].device_id; -- To view, visit https://review.coreboot.org/25681 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib71ebe812316eaf49136979a942a946ef9e4d487 Gerrit-Change-Number: 25681 Gerrit-PatchSet: 1 Gerrit-Owner: Alex James <theracermaster(a)gmail.com>

1 0

Change in flashrom[master]: Fix whitespace errors
by Elyes HAOUAS (Code Review) 02 Apr '18

02 Apr '18

Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/25380 ) Change subject: Fix whitespace errors ...................................................................... Patch Set 3: I' m also confused, as I didn't changed any thing related to EOL to buspirate_spi.c. I've just removed white spaces ... -- To view, visit https://review.coreboot.org/25380 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2d3bb9d8581a0471a8568a130f893b34dddf113 Gerrit-Change-Number: 25380 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 02 Apr 2018 21:13:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Remove address from GPLv2 headers
by build bot (Jenkins) (Code Review) 02 Apr '18

02 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25381 ) Change subject: Remove address from GPLv2 headers ...................................................................... Patch Set 5: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom_gerrit/1034/ : SUCCESS https://qa.coreboot.org/job/flashrom-customrules/1246/ : SUCCESS -- To view, visit https://review.coreboot.org/25381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7bfc339673cbf5ee2d2ff7564c4db04ca088d0a4 Gerrit-Change-Number: 25381 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 02 Apr 2018 21:10:02 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Remove address from GPLv2 headers
by Elyes HAOUAS (Code Review) 02 Apr '18

02 Apr '18

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25381 to look at the new patch set (#5). Change subject: Remove address from GPLv2 headers ...................................................................... Remove address from GPLv2 headers Change-Id: I7bfc339673cbf5ee2d2ff7564c4db04ca088d0a4 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M 82802ab.c M Makefile M amd_imc.c M at45db.c M atahpt.c M atapromise.c M atavia.c M bitbang_spi.c M board_enable.c M buspirate_spi.c M cbtable.c M ch341a_spi.c M chipdrivers.h M chipset_enable.c M cli_classic.c M cli_common.c M cli_output.c M coreboot_tables.h M custom_baud.c M custom_baud.h M dediprog.c M dmi.c M drkaiser.c M dummyflasher.c M en29lv640b.c M flash.h M flashchips.c M flashchips.h M flashrom.c M ft2232_spi.c M gfxnvidia.c M helpers.c M hwaccess.c M hwaccess.h M ich_descriptors.c M ich_descriptors.h M ichspi.c M internal.c M it8212.c M it85spi.c M it87spi.c M jedec.c M layout.c M layout.h M libflashrom.c M libflashrom.h M linux_spi.c M mcp6x_spi.c M mstarddc_spi.c M nic3com.c M nicintel.c M nicintel_eeprom.c M nicintel_spi.c M nicnatsemi.c M nicrealtek.c M ogp_spi.c M opaque.c M os.h M pcidev.c M physmap.c M pickit2_spi.c M platform.h M pony_spi.c M print.c M print_wiki.c M processor_enable.c M programmer.c M programmer.h M rayer_spi.c M satamv.c M satasii.c M sb600spi.c M serial.c M serprog.c M sfdp.c M spi.c M spi.h M spi25.c M spi25_statusreg.c M sst28sf040.c M sst49lfxxxc.c M sst_fwhub.c M stm50.c M udelay.c M usbblaster_spi.c M util/flashrom_partial_write_test.sh M util/getrevision.sh M util/ich_descriptors_tool/ich_descriptors_tool.c M util/z60_flashrom.rules M w29ee011.c M w39.c M wbsio_spi.c 92 files changed, 1 insertion(+), 369 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/25381/5 -- To view, visit https://review.coreboot.org/25381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7bfc339673cbf5ee2d2ff7564c4db04ca088d0a4 Gerrit-Change-Number: 25381 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: Remove address from GPLv2 headers
by Nico Huber (Code Review) 02 Apr '18

02 Apr '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/25381 ) Change subject: Remove address from GPLv2 headers ...................................................................... Patch Set 4: (1 comment) https://review.coreboot.org/#/c/25381/4/COPYING File COPYING: PS4: Please don't change this file, it's not what it says in the title any more if you do. -- To view, visit https://review.coreboot.org/25381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7bfc339673cbf5ee2d2ff7564c4db04ca088d0a4 Gerrit-Change-Number: 25381 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 02 Apr 2018 12:59:11 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Remove address from GPLv2 headers
by build bot (Jenkins) (Code Review) 02 Apr '18

02 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25381 ) Change subject: Remove address from GPLv2 headers ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1245/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1033/ : SUCCESS -- To view, visit https://review.coreboot.org/25381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7bfc339673cbf5ee2d2ff7564c4db04ca088d0a4 Gerrit-Change-Number: 25381 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 02 Apr 2018 09:24:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Remove address from GPLv2 headers
by Elyes HAOUAS (Code Review) 02 Apr '18

02 Apr '18

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/25381 to look at the new patch set (#4). Change subject: Remove address from GPLv2 headers ...................................................................... Remove address from GPLv2 headers Change-Id: I7bfc339673cbf5ee2d2ff7564c4db04ca088d0a4 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M 82802ab.c M COPYING M Makefile M amd_imc.c M at45db.c M atahpt.c M atapromise.c M atavia.c M bitbang_spi.c M board_enable.c M buspirate_spi.c M cbtable.c M ch341a_spi.c M chipdrivers.h M chipset_enable.c M cli_classic.c M cli_common.c M cli_output.c M coreboot_tables.h M custom_baud.c M custom_baud.h M dediprog.c M dmi.c M drkaiser.c M dummyflasher.c M en29lv640b.c M flash.h M flashchips.c M flashchips.h M flashrom.c M ft2232_spi.c M gfxnvidia.c M helpers.c M hwaccess.c M hwaccess.h M ich_descriptors.c M ich_descriptors.h M ichspi.c M internal.c M it8212.c M it85spi.c M it87spi.c M jedec.c M layout.c M layout.h M libflashrom.c M libflashrom.h M linux_spi.c M mcp6x_spi.c M mstarddc_spi.c M nic3com.c M nicintel.c M nicintel_eeprom.c M nicintel_spi.c M nicnatsemi.c M nicrealtek.c M ogp_spi.c M opaque.c M os.h M pcidev.c M physmap.c M pickit2_spi.c M platform.h M pony_spi.c M print.c M print_wiki.c M processor_enable.c M programmer.c M programmer.h M rayer_spi.c M satamv.c M satasii.c M sb600spi.c M serial.c M serprog.c M sfdp.c M spi.c M spi.h M spi25.c M spi25_statusreg.c M sst28sf040.c M sst49lfxxxc.c M sst_fwhub.c M stm50.c M udelay.c M usbblaster_spi.c M util/flashrom_partial_write_test.sh M util/getrevision.sh M util/ich_descriptors_tool/ich_descriptors_tool.c M util/z60_flashrom.rules M w29ee011.c M w39.c M wbsio_spi.c 93 files changed, 1 insertion(+), 374 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/25381/4 -- To view, visit https://review.coreboot.org/25381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7bfc339673cbf5ee2d2ff7564c4db04ca088d0a4 Gerrit-Change-Number: 25381 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: Remove address from GPLv2 headers
by build bot (Jenkins) (Code Review) 02 Apr '18

02 Apr '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25381 ) Change subject: Remove address from GPLv2 headers ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/flashrom-customrules/1244/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1032/ : SUCCESS -- To view, visit https://review.coreboot.org/25381 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7bfc339673cbf5ee2d2ff7564c4db04ca088d0a4 Gerrit-Change-Number: 25381 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 02 Apr 2018 09:19:51 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit