- flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: Add support to get layout from fmap (e.g. coreboot rom)
by Arthur Heymans (Code Review) 14 Jun '18

14 Jun '18

Hello Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23203 to look at the new patch set (#9). Change subject: Add support to get layout from fmap (e.g. coreboot rom) ...................................................................... Add support to get layout from fmap (e.g. coreboot rom) Using the --fmap argument one can give flashrom a layout in fmap binary format like is found of coreboot roms (it will also look for this on coreboot roms). An example of how to use: "flashrom -p programmer --fmap coreboot.rom -w coreboot.rom -i COREBOOT" to only flash the COREBOOT fmap region. The fmap functions are mostly copied from cbfstool. Currently it is made mutually exclusive with --ifd while still allowing --layout until we are more clever about this input. Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Makefile M cli_classic.c M flashrom.8.tmpl A fmap.c A fmap.h M layout.c 6 files changed, 251 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/23203/9 -- To view, visit https://review.coreboot.org/23203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Gerrit-Change-Number: 23203 Gerrit-PatchSet: 9 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Add support to get layout from a file (e.g. coreboot rom)
by build bot (Jenkins) (Code Review) 14 Jun '18

14 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23203 ) Change subject: Add support to get layout from a file (e.g. coreboot rom) ...................................................................... Patch Set 8: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1336/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1105/ : SUCCESS -- To view, visit https://review.coreboot.org/23203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Gerrit-Change-Number: 23203 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Jun 2018 22:57:09 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Add support to get layout from a file (e.g. coreboot rom)
by Arthur Heymans (Code Review) 14 Jun '18

14 Jun '18

Hello Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23203 to look at the new patch set (#8). Change subject: Add support to get layout from a file (e.g. coreboot rom) ...................................................................... Add support to get layout from a file (e.g. coreboot rom) Using the --fmap argument one can give flashrom a layout in fmap binary format like is found of coreboot roms (it will also look for this on coreboot roms). An example of how to use: "flashrom -p programmer --fmap coreboot.rom -w coreboot.rom -i COREBOOT" to only flash the COREBOOT fmap region. The fmap functions are mostly copied from cbfstool. Currently it is made mutually exclusive with --ifd while still allowing --layout until we are more clever about this input. Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Makefile M cli_classic.c M flashrom.8.tmpl A fmap.c A fmap.h M layout.c 6 files changed, 251 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/23203/8 -- To view, visit https://review.coreboot.org/23203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Gerrit-Change-Number: 23203 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: [WIP]Add support to get layout from a file (e.g. coreboot rom)
by build bot (Jenkins) (Code Review) 14 Jun '18

14 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23203 ) Change subject: [WIP]Add support to get layout from a file (e.g. coreboot rom) ...................................................................... Patch Set 7: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1335/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1104/ : SUCCESS -- To view, visit https://review.coreboot.org/23203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Gerrit-Change-Number: 23203 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Jun 2018 21:51:00 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: [WIP]Add support to get layout from a file (e.g. coreboot rom)
by Arthur Heymans (Code Review) 14 Jun '18

14 Jun '18

Hello Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23203 to look at the new patch set (#7). Change subject: [WIP]Add support to get layout from a file (e.g. coreboot rom) ...................................................................... [WIP]Add support to get layout from a file (e.g. coreboot rom) Mostly copied from cbfstool. This is mutually exclusive with using a layoutfile or fetching the layout from ifd. Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Makefile M cli_classic.c M flashrom.8.tmpl A fmap.c A fmap.h M layout.c 6 files changed, 243 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/23203/7 -- To view, visit https://review.coreboot.org/23203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Gerrit-Change-Number: 23203 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: [WIP]Add support to get layout from a file (e.g. coreboot rom)
by build bot (Jenkins) (Code Review) 14 Jun '18

14 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23203 ) Change subject: [WIP]Add support to get layout from a file (e.g. coreboot rom) ...................................................................... Patch Set 6: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1334/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1103/ : SUCCESS -- To view, visit https://review.coreboot.org/23203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Gerrit-Change-Number: 23203 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Jun 2018 21:32:39 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: [WIP]Add support to get layout from a file (e.g. coreboot rom)
by Arthur Heymans (Code Review) 14 Jun '18

14 Jun '18

Hello Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/23203 to look at the new patch set (#6). Change subject: [WIP]Add support to get layout from a file (e.g. coreboot rom) ...................................................................... [WIP]Add support to get layout from a file (e.g. coreboot rom) This is mutually exclusive with using a layoutfile or fetching the layout from ifd. Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M Makefile M cli_classic.c M flashrom.8.tmpl A fmap.c A fmap.h M layout.c 6 files changed, 296 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/23203/6 -- To view, visit https://review.coreboot.org/23203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Gerrit-Change-Number: 23203 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: [WIP]layout.c: Use a linked lists for layout
by build bot (Jenkins) (Code Review) 14 Jun '18

14 Jun '18

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27106 ) Change subject: [WIP]layout.c: Use a linked lists for layout ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/1333/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/1102/ : SUCCESS -- To view, visit https://review.coreboot.org/27106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7f48ac613da1590f30247bee979034cf1f74e9e Gerrit-Change-Number: 27106 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Jun 2018 17:56:24 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: [WIP]layout.c: Use a linked lists for layout
by Arthur Heymans (Code Review) 14 Jun '18

14 Jun '18

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/27106 to look at the new patch set (#3). Change subject: [WIP]layout.c: Use a linked lists for layout ...................................................................... [WIP]layout.c: Use a linked lists for layout This uses sys/queue.h to use a linked list for the struct flashrom_layout instead of using an fix sized array. This also removes the global variable in the layout.c file. Change-Id: Id7f48ac613da1590f30247bee979034cf1f74e9e Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M cli_classic.c M flash.h M flashrom.c M ich_descriptors.c M ich_descriptors.h M layout.c M layout.h M libflashrom.c 8 files changed, 121 insertions(+), 103 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/27106/3 -- To view, visit https://review.coreboot.org/27106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id7f48ac613da1590f30247bee979034cf1f74e9e Gerrit-Change-Number: 27106 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: [WIP]layout.c: Use a linked lists for layout
by Arthur Heymans (Code Review) 14 Jun '18

14 Jun '18

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/27106 ) Change subject: [WIP]layout.c: Use a linked lists for layout ...................................................................... Patch Set 2: (3 comments) https://review.coreboot.org/#/c/27106/2/cli_classic.c File cli_classic.c: https://review.coreboot.org/#/c/27106/2/cli_classic.c@556 PS2, Line 556: /* if (layoutfile) { */ : /* layout = get_global_layout(); */ : /* } else */ to remove https://review.coreboot.org/#/c/27106/2/flashrom.c File flashrom.c: https://review.coreboot.org/#/c/27106/2/flashrom.c@a2222 PS2, Line 2222: does no longer exist... so does the normalize_romentries still make sense? https://review.coreboot.org/#/c/27106/2/flashrom.c@2226 PS2, Line 2226: lash->layout when doing --ifd this is unintialised... -- To view, visit https://review.coreboot.org/27106 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7f48ac613da1590f30247bee979034cf1f74e9e Gerrit-Change-Number: 27106 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 14 Jun 2018 17:52:57 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit