- flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: vt_vx: check whether the chipset's MMIO range is configured
by Nico Huber (Code Review) 18 Aug '18

18 Aug '18

Nico Huber has abandoned this change. ( https://review.coreboot.org/22263 ) Change subject: vt_vx: check whether the chipset's MMIO range is configured ...................................................................... Abandoned picked to master long ago and staging is abandoned -- To view, visit https://review.coreboot.org/22263 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: abandon Gerrit-Change-Id: I5d3a1ba695153e854e0979ae634f8ed97e6b6293 Gerrit-Change-Number: 22263 Gerrit-PatchSet: 2 Gerrit-Owner: Lubomir Rintel <lkundrak(a)v3.sk> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Remove empty line at EOF
by Nico Huber (Code Review) 18 Aug '18

18 Aug '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28207 ) Change subject: Remove empty line at EOF ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28207 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6063cb5d406d7139abf7fcdf2ae265363640f9f Gerrit-Change-Number: 28207 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 18 Aug 2018 11:06:58 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Remove empty line at EOF
by Nico Huber (Code Review) 18 Aug '18

18 Aug '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28207 ) Change subject: Remove empty line at EOF ...................................................................... Patch Set 1: (1 comment) https://review.coreboot.org/#/c/28207/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/28207/1//COMMIT_MSG@7 PS1, Line 7: line line*s*, actually -- To view, visit https://review.coreboot.org/28207 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6063cb5d406d7139abf7fcdf2ae265363640f9f Gerrit-Change-Number: 28207 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sat, 18 Aug 2018 11:06:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Fix typos
by Nico Huber (Code Review) 18 Aug '18

18 Aug '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28206 ) Change subject: Fix typos ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/28206 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20745d5f30f9577622e27abf2f45220f026f65ac Gerrit-Change-Number: 28206 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 18 Aug 2018 11:05:46 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Mark GigaDevice GD25Q512 as tested
by Stefan Tauner (Code Review) 18 Aug '18

18 Aug '18

Stefan Tauner has posted comments on this change. ( https://review.coreboot.org/28209 ) Change subject: flashchips: Mark GigaDevice GD25Q512 as tested ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/28209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id3928e3790ddac34645959535e646d552ce5328e Gerrit-Change-Number: 28209 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 18 Aug 2018 10:49:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: flashchips: Mark GigaDevice GD25Q512 as tested
by Nico Huber (Code Review) 18 Aug '18

18 Aug '18

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/28209 Change subject: flashchips: Mark GigaDevice GD25Q512 as tested ...................................................................... flashchips: Mark GigaDevice GD25Q512 as tested As reported by `nvflash` on IRC. Change-Id: Id3928e3790ddac34645959535e646d552ce5328e Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/09/28209/1 diff --git a/flashchips.c b/flashchips.c index 17cb1b4..9b45c33 100644 --- a/flashchips.c +++ b/flashchips.c @@ -6054,7 +6054,7 @@ .total_size = 64, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, - .tested = TEST_UNTESTED, + .tested = TEST_OK_PREW, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = { -- To view, visit https://review.coreboot.org/28209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id3928e3790ddac34645959535e646d552ce5328e Gerrit-Change-Number: 28209 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[master]: Fix typos
by Elyes HAOUAS (Code Review) 18 Aug '18

18 Aug '18

Hello Paul Menzel, build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/28206 to look at the new patch set (#3). Change subject: Fix typos ...................................................................... Fix typos Change-Id: I20745d5f30f9577622e27abf2f45220f026f65ac Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M atapromise.c M buspirate_spi.c M ch341a_spi.c M flashchips.c M mstarddc_spi.c M physmap.c M platform.h M serial.c 8 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/28206/3 -- To view, visit https://review.coreboot.org/28206 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I20745d5f30f9577622e27abf2f45220f026f65ac Gerrit-Change-Number: 28206 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Change in flashrom[master]: Remove empty line at EOF
by Elyes HAOUAS (Code Review) 18 Aug '18

18 Aug '18

Elyes HAOUAS has uploaded this change for review. ( https://review.coreboot.org/28207 Change subject: Remove empty line at EOF ...................................................................... Remove empty line at EOF Change-Id: Id6063cb5d406d7139abf7fcdf2ae265363640f9f Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M cli_common.c M jedec.c M print_wiki.c M sst_fwhub.c 4 files changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/07/28207/1 diff --git a/cli_common.c b/cli_common.c index 2ccfe07..9375859 100644 --- a/cli_common.c +++ b/cli_common.c @@ -76,4 +76,3 @@ "Thanks for your help!\n"); } } - diff --git a/jedec.c b/jedec.c index 3343e99..54b7da7 100644 --- a/jedec.c +++ b/jedec.c @@ -751,4 +751,3 @@ (const struct unlockblock *)flash->chip->block_erasers[1].eraseblocks; return regspace2_walk_unlockblocks(flash, unlockblocks, &unlock_regspace2_block_generic); } - diff --git a/print_wiki.c b/print_wiki.c index 95158f7..ea8c4d7 100644 --- a/print_wiki.c +++ b/print_wiki.c @@ -450,4 +450,3 @@ #endif print_supported_devs_wiki(); } - diff --git a/sst_fwhub.c b/sst_fwhub.c index 306415c..398b01b 100644 --- a/sst_fwhub.c +++ b/sst_fwhub.c @@ -88,4 +88,3 @@ } return ret; } - -- To view, visit https://review.coreboot.org/28207 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Id6063cb5d406d7139abf7fcdf2ae265363640f9f Gerrit-Change-Number: 28207 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr>

1 0

Change in flashrom[master]: Fix typo
by Paul Menzel (Code Review) 18 Aug '18

18 Aug '18

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/28206 ) Change subject: Fix typo ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://review.coreboot.org/#/c/28206/2//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/28206/2//COMMIT_MSG@7 PS2, Line 7: Fix typo Fix typos -- To view, visit https://review.coreboot.org/28206 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20745d5f30f9577622e27abf2f45220f026f65ac Gerrit-Change-Number: 28206 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 18 Aug 2018 07:19:49 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Fix typo
by Elyes HAOUAS (Code Review) 18 Aug '18

18 Aug '18

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/28206 to look at the new patch set (#2). Change subject: Fix typo ...................................................................... Fix typo Change-Id: I20745d5f30f9577622e27abf2f45220f026f65ac Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M atapromise.c M buspirate_spi.c M ch341a_spi.c M flashchips.c M mstarddc_spi.c M physmap.c M platform.h M serial.c 8 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/28206/2 -- To view, visit https://review.coreboot.org/28206 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I20745d5f30f9577622e27abf2f45220f026f65ac Gerrit-Change-Number: 28206 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes HAOUAS <ehaouas(a)noos.fr> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit