- flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: Add CLI option to include a numeric range
by David Hendricks (Code Review) 19 Sep '18

19 Sep '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/28685 ) Change subject: Add CLI option to include a numeric range ...................................................................... Patch Set 1: Code-Review-1 Implementing a feature request from a user at OSFC. Adding -1 since at the very least it needs a man page entry, but hopefully the rest looks decent. Suggestions for a better option name and/or single-character option are welcome. -- To view, visit https://review.coreboot.org/28685 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2691051984bdeac128354c09bbe72aa05ef7401 Gerrit-Change-Number: 28685 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 19 Sep 2018 15:38:23 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Add CLI option to include a numeric range
by David Hendricks (Code Review) 19 Sep '18

19 Sep '18

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/28685 Change subject: Add CLI option to include a numeric range ...................................................................... Add CLI option to include a numeric range This adds an option, --range, which allows the user to specify a numeric range directly on the command-line. Change-Id: Ie2691051984bdeac128354c09bbe72aa05ef7401 Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M cli_classic.c M flash.h M layout.c 3 files changed, 49 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/85/28685/1 diff --git a/cli_classic.c b/cli_classic.c index 119c6f8..b98be48 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -55,6 +55,7 @@ " -l | --layout <layoutfile> read ROM layout from <layoutfile>\n" " --ifd read layout from an Intel Firmware Descriptor\n" " -i | --image <name> only flash image <name> from flash layout\n" + " --range <start:end> include numeric range\n" " -o | --output <logfile> log output to <logfile>\n" " --flash-contents <ref-file> assume flash contents to be <ref-file>\n" " -L | --list-supported print supported devices\n" @@ -97,7 +98,7 @@ struct flashctx *fill_flash; const char *name; int namelen, opt, i, j; - int startchip = -1, chipcount = 0, option_index = 0, force = 0, ifd = 0; + int startchip = -1, chipcount = 0, option_index = 0, force = 0, ifd = 0, include_range = 0; #if CONFIG_PRINT_WIKI == 1 int list_supported_wiki = 0; #endif @@ -108,6 +109,7 @@ enum { OPTION_IFD = 0x0100, OPTION_FLASH_CONTENTS, + OPTION_INCLUDE_RANGE, }; int ret = 0; @@ -125,6 +127,7 @@ {"layout", 1, NULL, 'l'}, {"ifd", 0, NULL, OPTION_IFD}, {"image", 1, NULL, 'i'}, + {"range", 1, NULL, OPTION_INCLUDE_RANGE}, {"flash-contents", 1, NULL, OPTION_FLASH_CONTENTS}, {"list-supported", 0, NULL, 'L'}, {"list-supported-wiki", 0, NULL, 'z'}, @@ -239,6 +242,14 @@ } ifd = 1; break; + case OPTION_INCLUDE_RANGE: + tempstr = strdup(optarg); + if (include_numeric_range(get_global_layout(), tempstr)) { + free(tempstr); + cli_classic_abort_usage(); + } + include_range = 1; + break; case 'i': tempstr = strdup(optarg); if (register_include_arg(tempstr)) { @@ -552,7 +563,7 @@ goto out_shutdown; } - if (layoutfile) { + if (layoutfile || include_range) { layout = get_global_layout(); } else if (ifd && (flashrom_layout_read_from_ifd(&layout, fill_flash, NULL, 0) || process_include_args(layout))) { diff --git a/flash.h b/flash.h index 01ff5cd..735cd21 100644 --- a/flash.h +++ b/flash.h @@ -388,6 +388,7 @@ /* layout.c */ int register_include_arg(char *name); int read_romlayout(const char *name); +int include_numeric_range(struct flashrom_layout *const l, const char *str); int normalize_romentries(const struct flashctx *flash); void layout_cleanup(void); diff --git a/layout.c b/layout.c index fa66238..49dcba0 100644 --- a/layout.c +++ b/layout.c @@ -101,6 +101,41 @@ } #endif +int include_numeric_range(struct flashrom_layout *const l, const char *str) +{ + char *tstr1, *tstr2; + char *orig = strdup(str); + int ret = 1; + + if (num_include_args >= MAX_ROMLAYOUT) { + msg_gerr("Maximum number of ROM images (%i) in layout " + "file reached.\n", MAX_ROMLAYOUT); + goto free_ret; + } + + tstr1 = strtok((char *)str, ":"); + tstr2 = strtok(NULL, ":"); + if (!tstr1 || !tstr2) { + msg_gerr("Error parsing included range argument: \"%s\"\n", str); + goto free_ret; + } + + l->entries[l->num_entries].start = strtol(tstr1, (char **)NULL, 16); + l->entries[l->num_entries].end = strtol(tstr2, (char **)NULL, 16); + l->entries[l->num_entries].included = 1; + + memset(l->entries[l->num_entries].name, 0, sizeof(l->entries[l->num_entries].name)); + strncpy(l->entries[l->num_entries].name, orig, sizeof(l->entries[l->num_entries].name)); + msg_gdbg("romlayout %08x - %08x named %s\n", l->entries[l->num_entries].start, + l->entries[l->num_entries].end, l->entries[l->num_entries].name); + + l->num_entries++; + ret = 0; +free_ret: + free(orig); + return ret; +} + /* returns the index of the entry (or a negative value if it is not found) */ static int find_include_arg(const char *const name) { -- To view, visit https://review.coreboot.org/28685 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ie2691051984bdeac128354c09bbe72aa05ef7401 Gerrit-Change-Number: 28685 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>

1 0

Change in flashrom[master]: Add support to get layout from fmap (e.g. coreboot rom)
by David Hendricks (Code Review) 17 Sep '18

17 Sep '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/23203 ) Change subject: Add support to get layout from fmap (e.g. coreboot rom) ...................................................................... Patch Set 24: (17 comments) I had some time to hack on this some more and test using a Chromebook using --fmap-file (linear search), --fmap with the fmap offset at a weird location (try bsearch and fall back to linear search), and --fmap with the fmap at a bsearchable offset. I'm not sure what to do about the man page... The line break seems weird. https://review.coreboot.org/#/c/23203/22/cli_classic.c File cli_classic.c: https://review.coreboot.org/#/c/23203/22/cli_classic.c@619 PS22, Line 619: out > out_shutdown Done https://review.coreboot.org/#/c/23203/22/cli_classic.c@642 PS22, Line 642: && (flashrom_ > I stared at this for a moment, now I'm sure the `!fmapfile` is […] OK. I think it helps with readability since it flows nicely with the above `fmap && fmapfile`, but I don't have a strong preference. https://review.coreboot.org/#/c/23203/22/flashrom.8.tmpl File flashrom.8.tmpl: https://review.coreboot.org/#/c/23203/22/flashrom.8.tmpl@52 PS22, Line 52: \-\-fmap\fR|\fB\-\-fmap-file\fR <file>) \ > This line is unnecessarily long now. Please break before the […] Yeah, it's not the longest line but it is quite long. I don't understand why you want to break before the `-n` though. The spacing doesn't make much sense to me, is there a standard or some general guidelines? I just took a guess. https://review.coreboot.org/#/c/23203/22/flashrom.8.tmpl@202 PS22, Line 202: hrom suppo > par*ti*tioning Done https://review.coreboot.org/#/c/23203/22/flashrom.8.tmpl@217 PS22, Line 217: hrom suppo > partitioning Done https://review.coreboot.org/#/c/23203/22/flashrom.8.tmpl@219 PS22, Line 219: used to generate the layout. > leftover oops, done. https://review.coreboot.org/#/c/23203/22/fmap.h File fmap.h: https://review.coreboot.org/#/c/23203/22/fmap.h@3 PS22, Line 3: -present > I know it has been discussed already. But this is incredibly […] Nah, I kinda like it actually. It just says explicitly what we already assume, and prevents issues with people updating copyright notices needlessly to match the present year whenever they touch a file. In any case our non-lawyer opinions are irrelevant, so no point in arguing. https://review.coreboot.org/#/c/23203/22/fmap.h@45 PS22, Line 45: #define FMAP_VER_MINOR 1 /* this header's FMAP minor version */ > Didn't check earlier versions, but now this is unused? shouldn't […] Sure. FWIW, the only difference IIRC between 1.0 and 1.1 was that 1.1 required alignment to a 64-byte boundary so that bsearch wouldn't be too expensive on the hardware we had available at the time. We fallback to doing brute-force linear search on all bytes anyway so it doesn't matter too much, it was intended more as a guideline for implementation. https://review.coreboot.org/#/c/23203/22/fmap.h@67 PS22, Line 67: int fmap_read_from_buffer(struct fmap **fmap_out, const uint8_t *buf, size_t len); > nit, could be static now Done https://review.coreboot.org/#/c/23203/22/fmap.c File fmap.c: https://review.coreboot.org/#/c/23203/22/fmap.c@1 PS22, Line 1: > nit, missing initial line break Done https://review.coreboot.org/#/c/23203/22/fmap.c@153 PS22, Line 153: int ret = -1; : uint8_t *b > Redundant, probably leftover? Done https://review.coreboot.org/#/c/23203/22/fmap.c@203 PS22, Line 203: } > leaking `fmap` moved above malloc https://review.coreboot.org/#/c/23203/22/fmap.c@260 PS22, Line 260: if (fmap_found) : break; : } : : if (!fmap_found) : goto _free_ret; : : fmap_len = fmap_size(fmap); : struct fmap *tmp = fmap; : fmap = realloc(fmap, fmap_len); : if (!fmap) { : msg_gerr("Failed to realloc.\n"); : free(tmp); : goto _free_ret; : } : : if (flashctx->chip->read(flashctx, (uint8_t *)fmap + sizeof(*fmap), : offset + sizeof(*fmap), fmap_len - sizeof(*fmap))) { : msg_cerr("Cannot read %zu bytes at offset %06zx\n", : fmap_len - sizeof(*fmap), offset + sizeof(*fmap)); : /* Treat read failure to be fatal since this : * should be a valid, usable fmap. */ : goto _free_ret; : } : > This path is flawed a little. At least it's missing an unconditional […] The break seems to have been lost during refactoring :-/ Sigh. I like the idea of doing more stuff outside of the inner loop. I don't think we should ever hit the realloc() a second time, and it should be fine to treat those error paths as fatal. I suppose one could make an argument that if we see a valid fmap header but can't read the whole thing then we should continue trying to find another fmap. But I think in practice that is indicative of a hardware failure or error in the way the firmware ROM is laid out and it's useful to treat it as fatal. Maybe we should return a different code to the caller to indicate this and avoid doing the linear search. https://review.coreboot.org/#/c/23203/22/fmap.c@292 PS22, Line 292: ret = 0; > This would still be set after a read failure, for instance. So it's […] agreed https://review.coreboot.org/#/c/23203/22/fmap.c@321 PS22, Line 321: an fma > How do you pronounce it? Is it `*a* fmap` or `*an* eff-map`? I say "an" in my head. Usually 'a' is used before a noun beginning with a consonant, but that sounds awkward to me in this case so I've updated the comment. https://review.coreboot.org/#/c/23203/22/libflashrom.c File libflashrom.c: https://review.coreboot.org/#/c/23203/22/libflashrom.c@433 PS22, Line 433: struct flashctx *const flashctx, off_t offset, size_t len) > Ugly, but as we were too lazy for proper deserialization again, […] done https://review.coreboot.org/#/c/23203/22/libflashrom.c@468 PS22, Line 468: * 3 if fmap parsing isn't implemented for the host, > Same guard here. Done -- To view, visit https://review.coreboot.org/23203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Gerrit-Change-Number: 23203 Gerrit-PatchSet: 24 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Mon, 17 Sep 2018 14:39:42 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add support to get layout from fmap (e.g. coreboot rom)
by David Hendricks (Code Review) 17 Sep '18

17 Sep '18

David Hendricks has uploaded a new patch set (#24) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/23203 ) Change subject: Add support to get layout from fmap (e.g. coreboot rom) ...................................................................... Add support to get layout from fmap (e.g. coreboot rom) Flashmap, or simply fmap, is a binary data format for describing region offsets, sizes, and certain attributes and is widely used by coreboot. This patch adds support for the fmap data format version 1.1 and adds --fmap and --fmap-file arguments. Using --fmap will make flashrom to search the ROM content for fmap data. Using --fmap-file will make flashrom search a supplied file for fmap data. An example of how to update the COREBOOT region of a ROM: flashrom -p programmer --fmap -w coreboot.rom -i COREBOOT flashrom -p programmer --fmap-file coreboot.rom -w coreboot.rom -i COREBOOT The fmap functions are mostly copied from cbfstool. Currently it is made mutually exclusive with other layout options until we are more clever about this input. Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M Makefile M cli_classic.c M flashrom.8.tmpl A fmap.c A fmap.h M libflashrom.c M libflashrom.h 7 files changed, 651 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/23203/24 -- To view, visit https://review.coreboot.org/23203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Gerrit-Change-Number: 23203 Gerrit-PatchSet: 24 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com>

1 0

Change in flashrom[master]: Add support to get layout from fmap (e.g. coreboot rom)
by David Hendricks (Code Review) 17 Sep '18

17 Sep '18

David Hendricks has uploaded a new patch set (#23) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/23203 ) Change subject: Add support to get layout from fmap (e.g. coreboot rom) ...................................................................... Add support to get layout from fmap (e.g. coreboot rom) Flashmap, or simply fmap, is a binary data format for describing region offsets, sizes, and certain attributes and is widely used by coreboot. This patch adds support for the fmap data format version 1.1 and adds --fmap and --fmap-file arguments. Using --fmap will make flashrom to search the ROM content for fmap data. Using --fmap-file will make flashrom search a supplied file for fmap data. An example of how to update the COREBOOT region of a ROM: flashrom -p programmer --fmap -w coreboot.rom -i COREBOOT flashrom -p programmer --fmap-file coreboot.rom -w coreboot.rom -i COREBOOT The fmap functions are mostly copied from cbfstool. Currently it is made mutually exclusive with other layout options until we are more clever about this input. Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Signed-off-by: David Hendricks <dhendricks(a)fb.com> --- M Makefile M cli_classic.c M flashrom.8.tmpl A fmap.c A fmap.h M libflashrom.c M libflashrom.h 7 files changed, 652 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/23203/23 -- To view, visit https://review.coreboot.org/23203 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12 Gerrit-Change-Number: 23203 Gerrit-PatchSet: 23 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com>

1 0

Change in flashrom[master]: Add initial support for Dediprog SF200.
by Nico Huber (Code Review) 11 Sep '18

11 Sep '18

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/28272 ) Change subject: Add initial support for Dediprog SF200. ...................................................................... Add initial support for Dediprog SF200. Change-Id: I025d1533e249f6a75b6d9015a18a6abf350456b6 Signed-off-by: Jay Thompson <thompson.jay.thomas(a)gmail.com> Signed-off-by: David Hendricks <dhendricks(a)fb.com> Reviewed-on: https://review.coreboot.org/28272 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: David Hendricks <david.hendricks(a)gmail.com> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M dediprog.c 1 file changed, 14 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved Nico Huber: Looks good to me, approved diff --git a/dediprog.c b/dediprog.c index 1a469a7..58f1d43 100644 --- a/dediprog.c +++ b/dediprog.c @@ -51,6 +51,7 @@ enum dediprog_devtype { DEV_UNKNOWN = 0, DEV_SF100 = 100, + DEV_SF200 = 200, DEV_SF600 = 600, }; @@ -152,7 +153,7 @@ }; const struct dev_entry devs_dediprog[] = { - {0x0483, 0xDADA, OK, "Dediprog", "SF100/SF600"}, + {0x0483, 0xDADA, OK, "Dediprog", "SF100/SF200/SF600"}, {0}, }; @@ -181,6 +182,7 @@ /* Firmware version < 5.0.0 is handled explicitly in some cases. */ switch (dediprog_devicetype) { case DEV_SF100: + case DEV_SF200: if (dediprog_firmwareversion < FIRMWARE_VERSION(5, 5, 0)) return PROTOCOL_V1; else @@ -756,10 +758,12 @@ msg_pdbg("Found a %s\n", buf); if (memcmp(buf, "SF100", 0x5) == 0) dediprog_devicetype = DEV_SF100; + else if (memcmp(buf, "SF200", 0x5) == 0) + dediprog_devicetype = DEV_SF200; else if (memcmp(buf, "SF600", 0x5) == 0) dediprog_devicetype = DEV_SF600; else { - msg_perr("Device not a SF100 or SF600!\n"); + msg_perr("Device not a SF100, SF200, or SF600!\n"); return 1; } @@ -1091,12 +1095,17 @@ return 1; } - /* SF100 only has 1 endpoint for in/out, SF600 uses two separate endpoints instead. */ + /* SF100/SF200 uses one in/out endpoint, SF600 uses separate in/out endpoints */ dediprog_in_endpoint = 2; - if (dediprog_devicetype == DEV_SF100) + switch (dediprog_devicetype) { + case DEV_SF100: + case DEV_SF200: dediprog_out_endpoint = 2; - else + break; + default: dediprog_out_endpoint = 1; + break; + } /* Set all possible LEDs as soon as possible to indicate activity. * Because knowing the firmware version is required to set the LEDs correctly we need to this after -- To view, visit https://review.coreboot.org/28272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I025d1533e249f6a75b6d9015a18a6abf350456b6 Gerrit-Change-Number: 28272 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>

1 0

Change in flashrom[master]: Add initial support for Dediprog SF200.
by Nico Huber (Code Review) 11 Sep '18

11 Sep '18

Nico Huber has posted comments on this change. ( https://review.coreboot.org/28272 ) Change subject: Add initial support for Dediprog SF200. ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/28272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I025d1533e249f6a75b6d9015a18a6abf350456b6 Gerrit-Change-Number: 28272 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 11 Sep 2018 12:30:17 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Add initial J-Link SPI programmer
by Martin Roth (Code Review) 06 Sep '18

06 Sep '18

Martin Roth has posted comments on this change. ( https://review.coreboot.org/28087 ) Change subject: Add initial J-Link SPI programmer ...................................................................... Patch Set 7: I'll try to work on getting the builders updated tonight. -- To view, visit https://review.coreboot.org/28087 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie03a054a75457ec9e1cab36ea124bb53b10e8d7e Gerrit-Change-Number: 28087 Gerrit-PatchSet: 7 Gerrit-Owner: Marc Schink <flashrom-dev(a)marcschink.de> Gerrit-Reviewer: Marc Schink <flashrom-dev(a)marcschink.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 06 Sep 2018 18:29:07 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No

1 0

Change in flashrom[master]: Add initial support for Dediprog SF200.
by David Hendricks (Code Review) 01 Sep '18

01 Sep '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/28272 ) Change subject: Add initial support for Dediprog SF200. ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/28272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I025d1533e249f6a75b6d9015a18a6abf350456b6 Gerrit-Change-Number: 28272 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 02 Sep 2018 01:52:43 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes

1 0

Change in flashrom[master]: Add initial support for Dediprog SF200.
by David Hendricks (Code Review) 01 Sep '18

01 Sep '18

David Hendricks has posted comments on this change. ( https://review.coreboot.org/28272 ) Change subject: Add initial support for Dediprog SF200. ...................................................................... Patch Set 2: (1 comment) There were some whitespace issues that I went ahead and fixed, too. https://review.coreboot.org/#/c/28272/1/dediprog.c File dediprog.c: https://review.coreboot.org/#/c/28272/1/dediprog.c@1146 PS1, Line 1146: case DEV_SF200: > Should this comment be updated? Yes. I also updated this to use a switch statement since we're dealing with three programmers, two of which are nearly identical. -- To view, visit https://review.coreboot.org/28272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I025d1533e249f6a75b6d9015a18a6abf350456b6 Gerrit-Change-Number: 28272 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 02 Sep 2018 01:50:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit