Nico Huber has posted comments on this change. ( https://review.coreboot.org/23865 )
Change subject: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another non XP Windows build environments too.
......................................................................
Patch Set 1:
(7 comments)
https://review.coreboot.org/#/c/23865/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/23865/1//COMMIT_MSG@7
PS1, Line 7:
> Sure: […]
Maybe prefix with `Makefile: `, line length should be <=55 chars,
65 maximum.
https://review.coreboot.org/#/c/23865/1/Makefile
File Makefile:
https://review.coreboot.org/#/c/23865/1/Makefile@101
PS1, Line 101: enviroment
enviro*n*ment
https://review.coreboot.org/#/c/23865/1/Makefile@102
PS1, Line 102: # uname returns MINGW32_NT-5.1 on XP, MINGW32_NT-6.1 on Windows 7
missing full-stop
https://review.coreboot.org/#/c/23865/1/Makefile@103
PS1, Line 103: # the regexp should support 64 bit variant of mingw if exists
Please write a complete sentence, starting in upper-case, ending
with a full-stop.
https://review.coreboot.org/#/c/23865/1/Makefile@104
PS1, Line 104: else echo no;
no need for the `echo no`
https://review.coreboot.org/#/c/23865/1/Makefile@104
PS1, Line 104: ifeq ($(shell if [[ $$(uname) =~ ^MINGW[0-9]{0,2}_NT-[0-9]{1,2}.[0-9]{1,2}$$ ]]; then echo yes; else echo no; fi), yes)
> Kind of. It is a regexp check inspired by this: […]
Can we assume that bash is always available in MinGW/MSYS? If so,
we should redirect stderr at least (`2>/dev/null` maybe? please test
with MinGW).
https://review.coreboot.org/#/c/23865/1/Makefile@104
PS1, Line 104: $$(uname)
you could use "$(HOST_OS)" instead of $$(uname)
--
To view, visit https://review.coreboot.org/23865
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f856dc4847c4ca9197b1935b7a9b9071b46c70a
Gerrit-Change-Number: 23865
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Márton Miklós <martonmiklosqdev(a)gmail.com>
Gerrit-Comment-Date: Wed, 07 Mar 2018 13:29:15 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Nico Huber has posted comments on this change. ( https://review.coreboot.org/23802 )
Change subject: dmi: Don't print dmidecode shell error
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/23802/2/dmi.c
File dmi.c:
https://review.coreboot.org/#/c/23802/2/dmi.c@296
PS2, Line 296: #if IS_WINDOWS
Updated this to use IS_WINDOWS (probably didn't exist when the
original commit was written).
--
To view, visit https://review.coreboot.org/23802
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ded8e1bad14b5e809185a79c4e3a17329b1ecb9
Gerrit-Change-Number: 23802
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 07 Mar 2018 13:00:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
Hello Stefan Tauner, Stefan Reinauer, David Hendricks, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/23802
to look at the new patch set (#3).
Change subject: dmi: Don't print dmidecode shell error
......................................................................
dmi: Don't print dmidecode shell error
Don't print the error "sh: dmidecode: not found" if dmidecode is not there.
Uses stderr redirection to /dev/null (or NUL on Windows).
Change-Id: I3ded8e1bad14b5e809185a79c4e3a17329b1ecb9
Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at>
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M dmi.c
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/02/23802/3
--
To view, visit https://review.coreboot.org/23802
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3ded8e1bad14b5e809185a79c4e3a17329b1ecb9
Gerrit-Change-Number: 23802
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello Stefan Tauner, Stefan Reinauer, David Hendricks, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/23802
to look at the new patch set (#2).
Change subject: dmi: Don't print dmidecode shell error
......................................................................
dmi: Don't print dmidecode shell error
Don't print the error "sh: dmidecode: not found" if dmidecode is not there.
Uses stderr redirection to /dev/null (or NUL on win32).
Change-Id: I3ded8e1bad14b5e809185a79c4e3a17329b1ecb9
Signed-off-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Signed-off-by: Stefan Tauner <stefan.tauner(a)student.tuwien.ac.at>
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M dmi.c
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/02/23802/2
--
To view, visit https://review.coreboot.org/23802
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3ded8e1bad14b5e809185a79c4e3a17329b1ecb9
Gerrit-Change-Number: 23802
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>