Paul Menzel has posted comments on this change. ( https://review.coreboot.org/23701 )
Change subject: flashchips: Add Zettadevice ZD25D40
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/23701/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/23701/2//COMMIT_MSG@14
PS2, Line 14:
Remove the blank line, and move the Change-Id even above the Signed-off-by line.
--
To view, visit https://review.coreboot.org/23701
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0400b059ddacdf166d1b77f619becec3a250cece
Gerrit-Change-Number: 23701
Gerrit-PatchSet: 2
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 12 Feb 2018 13:16:53 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
David Hendricks has posted comments on this change. ( https://review.coreboot.org/23701 )
Change subject: flashchips: Add Zettadevice ZD25D40
......................................................................
Patch Set 2:
The original author's PR was titled "Added W25P16 (tested) and ZD25D40 (untested)"
However W25P16 support wasn't really added - There seemed to be some confusion about what the author was intending to add support for.
The ZD25D40 part looked good so I split that out. I also added ZD25D20 support in the follow-up in my own patch.
--
To view, visit https://review.coreboot.org/23701
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0400b059ddacdf166d1b77f619becec3a250cece
Gerrit-Change-Number: 23701
Gerrit-PatchSet: 2
Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 12 Feb 2018 02:49:27 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No