Attention is currently required from: Angel Pons, Brian Norris, Thomas Heijligen.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82083?usp=email )
Change subject: flashrom_tester: Correct "WP screw" message
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> I guess "open" and "close" mean that the screw acts like a switch (which can be open or closed).
To provide more references, let's explore what the "WP screw" looks like in ChromeOS:
1. Please refer to the following external links, which include pictures of the WP screw in ChromeOS:
https://superuser.com/questions/936731/where-is-the-hardware-write-protect-…https://www.collabora.com/news-and-blog/blog/2017/03/08/quick-hack-removing…
2. Additionally, the official ChromeOS documentation provides information on the WP screw:
https://chromium.googlesource.com/chromiumos/docs/+/master/write_protection…
```
...Locate and remove the write protect screw on the motherboard.
```
While "remove" is often used to describe opening the WP screw, I couldn't find an official reference for its opposite action.
--
To view, visit https://review.coreboot.org/c/flashrom/+/82083?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I45f06db51e92e68bf724b13bdf5b31bba511d270
Gerrit-Change-Number: 82083
Gerrit-PatchSet: 5
Gerrit-Owner: Brian Norris <briannorris(a)chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Evan Benn <evanbenn(a)gmail.com>
Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Brian Norris <briannorris(a)chromium.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Tue, 30 Apr 2024 02:59:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hsuan-ting Chen <roccochen(a)google.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Brian Norris, Hsuan-ting Chen, Thomas Heijligen.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82083?usp=email )
Change subject: flashrom_tester: Correct "WP screw" message
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> Thank you for the updates! Yes, they did look incorrect. My apologies for the delayed review. […]
I guess "open" and "close" mean that the screw acts like a switch (which can be open or closed).
--
To view, visit https://review.coreboot.org/c/flashrom/+/82083?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I45f06db51e92e68bf724b13bdf5b31bba511d270
Gerrit-Change-Number: 82083
Gerrit-PatchSet: 5
Gerrit-Owner: Brian Norris <briannorris(a)chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Evan Benn <evanbenn(a)gmail.com>
Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Brian Norris <briannorris(a)chromium.org>
Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Comment-Date: Mon, 29 Apr 2024 12:00:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Brian Norris, Thomas Heijligen.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82083?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: flashrom_tester: Correct "WP screw" message
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Thank you for the updates! Yes, they did look incorrect. My apologies for the delayed review.
I also did some internal research and confirmed no other tools rely on this wording currently. We should be safe to change it without breaking anything.
While we're at it, why not change the wording to make it clearer? For instance, we could use "remove/restore the WP screw", "unscrew/screw the WP screw", or "open/lock the WP screw".
What do you think? Would that be clearer?
--
To view, visit https://review.coreboot.org/c/flashrom/+/82083?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I45f06db51e92e68bf724b13bdf5b31bba511d270
Gerrit-Change-Number: 82083
Gerrit-PatchSet: 5
Gerrit-Owner: Brian Norris <briannorris(a)chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Evan Benn <evanbenn(a)gmail.com>
Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Brian Norris <briannorris(a)chromium.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Comment-Date: Mon, 29 Apr 2024 11:48:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: DZ, Nikolai Artemiev, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81838?usp=email )
Change subject: flashchips: Add support for MXIC MX25R4035F
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
This is currently in "Merge conflict" state (you can see in the left top corner). You need to rebase on head, but since there is another patch soon to be submitted CB:81836 , maybe you can wait until CB:81836 is submitted and then rebase this one.
--
To view, visit https://review.coreboot.org/c/flashrom/+/81838?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I91dbc4735bf232e0b1dce72c7f06be967d35ebfb
Gerrit-Change-Number: 81838
Gerrit-PatchSet: 3
Gerrit-Owner: DZ <danielzhang(a)mxic.com.cn>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: DZ <danielzhang(a)mxic.com.cn>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Mon, 29 Apr 2024 09:55:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: DZ, Nikolai Artemiev, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81839?usp=email )
Change subject: flashchips: Add support for MXIC MX25R2035F
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
Patchset:
PS6:
This is currently in "Merge conflict" state (you can see in the left top corner). You need to rebase on head, but since there is another patch soon to be submitted CB:81836 , maybe you can wait until CB:81836 is submitted and then rebase this one.
--
To view, visit https://review.coreboot.org/c/flashrom/+/81839?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I00e76ef942976e3e102cf71fe695c6287b392b64
Gerrit-Change-Number: 81839
Gerrit-PatchSet: 6
Gerrit-Owner: DZ <danielzhang(a)mxic.com.cn>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: DZ <danielzhang(a)mxic.com.cn>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Mon, 29 Apr 2024 09:55:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: DZ, Nikolai Artemiev, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81836?usp=email )
Change subject: flashchips: Add support for MXIC MX25L1633E
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/flashrom/+/81836?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I63ee0182ad6e62b7408136285aa0e927d53f7bc8
Gerrit-Change-Number: 81836
Gerrit-PatchSet: 5
Gerrit-Owner: DZ <danielzhang(a)mxic.com.cn>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: DZ <danielzhang(a)mxic.com.cn>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Mon, 29 Apr 2024 09:45:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
DZ has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81838?usp=email )
Change subject: flashchips: Add support for MXIC MX25R4035F
......................................................................
Patch Set 3:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/81838/comment/22da2585_c58e9801 :
PS1, Line 10216: .name = "MX25R4035F",
> The entries are sorted by name, so I think this one goes between R32 and R64
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/81838?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I91dbc4735bf232e0b1dce72c7f06be967d35ebfb
Gerrit-Change-Number: 81838
Gerrit-PatchSet: 3
Gerrit-Owner: DZ <danielzhang(a)mxic.com.cn>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Mon, 29 Apr 2024 02:51:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment