Peter Marheine has submitted this change. ( https://review.coreboot.org/c/flashrom/+/82212?usp=email )
Change subject: dos/meson: add a hint for setting sys_root
......................................................................
dos/meson: add a hint for setting sys_root
I found that cross-compiling with GCC 12.2.0 targeting DJGPP from Linux
on x86_64 that meson used my system include directory
(/usr/include/x86_64-linux-gnu/) and pulled in include files that are
incompatible with DJGPP. Setting sys_root prevents meson from assuming
they're compatible between the build and host systems, fixing those
compile-time errors.
TEST=meson setup --cross-file meson_cross/i586_djgpp_dos.txt; ninja
libflashrom.h no longer causes "features.h: No such file or
directory" errors via /usr/include/x86_64-linux-gnu/sys/types.h
Change-Id: Ib9cf70f6f94782c5303fb232aaf4a46192907f66
Signed-off-by: Peter Marheine <pmarheine(a)chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/82212
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org>
---
M meson_cross/i586_djgpp_dos.txt
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Anastasia Klimchuk: Looks good to me, approved
diff --git a/meson_cross/i586_djgpp_dos.txt b/meson_cross/i586_djgpp_dos.txt
index 66d5ed0..3d97aab 100644
--- a/meson_cross/i586_djgpp_dos.txt
+++ b/meson_cross/i586_djgpp_dos.txt
@@ -5,6 +5,11 @@
# Make sure pkg-config can find your self compiles libpci
# or add the path of your libpci.pc as 'pkg_config_libdir'
# under [properies] below.
+#
+# If cross-compiling, you may need to set sys_root in the [properties]
+# section because meson otherwise assumes the same sysroot as the
+# system on which you're building and will get the wrong include files
+# (from /usr/include/x86_64 for example) among other possible issues.
[binaries]
c = 'i586-pc-msdosdjgpp-gcc'
@@ -27,3 +32,4 @@
ich_descriptors_tool = 'disabled'
[properties]
+sys_root = '/usr/local/djgpp'
--
To view, visit https://review.coreboot.org/c/flashrom/+/82212?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ib9cf70f6f94782c5303fb232aaf4a46192907f66
Gerrit-Change-Number: 82212
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Anastasia Klimchuk, J. Neuschäfer, Riku Viitanen, Thomas Heijligen.
Sydney has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82229?usp=email )
Change subject: Add documentation for pico-serprog
......................................................................
Patch Set 3:
(1 comment)
File doc/supported_hw/supported_prog/serprog/overview.rst:
https://review.coreboot.org/c/flashrom/+/82229/comment/8df4e581_d6b6fba8 :
PS2, Line 95: etter performance
> I'm not sure it's actually more performant since stacksmashing's fork seems to have made performance […]
I am not aware of any exiting benchmarks. I removed the statement about performance differences until this can be backed by tests/data. Thanks for pointing this out.
--
To view, visit https://review.coreboot.org/c/flashrom/+/82229?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I457dfec52f89997f64b6c276c50b329359d61b77
Gerrit-Change-Number: 82229
Gerrit-PatchSet: 3
Gerrit-Owner: Sydney <git(a)funkeleinhorn.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: J. Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Reviewer: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Attention: J. Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Wed, 08 May 2024 16:20:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Anastasia Klimchuk, J. Neuschäfer, Sydney, Thomas Heijligen.
Hello Anastasia Klimchuk, J. Neuschäfer, Riku Viitanen, Thomas Heijligen, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/82229?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: Add documentation for pico-serprog
......................................................................
Add documentation for pico-serprog
This commit adds documentation for pico-serprog by stacksmashing:
https://github.com/stacksmashing/pico-serprog
and its fork by Riku_V: https://codeberg.org/Riku_V/pico-serprog
to the serprog overview page.
Change-Id: I457dfec52f89997f64b6c276c50b329359d61b77
Signed-off-by: Funkeleinhorn <git(a)funkeleinhorn.com>
---
M doc/supported_hw/supported_prog/serprog/overview.rst
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/29/82229/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/82229?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I457dfec52f89997f64b6c276c50b329359d61b77
Gerrit-Change-Number: 82229
Gerrit-PatchSet: 3
Gerrit-Owner: Sydney <git(a)funkeleinhorn.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: J. Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Reviewer: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: J. Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Sydney <git(a)funkeleinhorn.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Anastasia Klimchuk, J. Neuschäfer, Sydney, Thomas Heijligen.
Riku Viitanen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82229?usp=email )
Change subject: Add documentation for pico-serprog
......................................................................
Patch Set 2:
(1 comment)
File doc/supported_hw/supported_prog/serprog/overview.rst:
https://review.coreboot.org/c/flashrom/+/82229/comment/bef88de4_2c2c51f2 :
PS2, Line 95: etter performance
I'm not sure it's actually more performant since stacksmashing's fork seems to have made performance improvements as well. Has anyone benchmarked these implementations? The PIOs are pretty impressive.
--
To view, visit https://review.coreboot.org/c/flashrom/+/82229?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I457dfec52f89997f64b6c276c50b329359d61b77
Gerrit-Change-Number: 82229
Gerrit-PatchSet: 2
Gerrit-Owner: Sydney <git(a)funkeleinhorn.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: J. Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Reviewer: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: J. Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Sydney <git(a)funkeleinhorn.com>
Gerrit-Comment-Date: Wed, 08 May 2024 15:01:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Anastasia Klimchuk, J. Neuschäfer, Riku Viitanen, Thomas Heijligen.
Sydney has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82229?usp=email )
Change subject: Add documentation for pico-serprog
......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS1:
> Hi, thanks for writing this :)
Thanks for your feedback. I addressed the suggested changes. Please have a look again.
File doc/supported_hw/supported_prog/serprog/overview.rst:
https://review.coreboot.org/c/flashrom/+/82229/comment/74471bfd_3dc92483 :
PS1, Line 90: is an bigger existing
> 1. typo, → "a bigger" […]
Done
https://review.coreboot.org/c/flashrom/+/82229/comment/c04c8cec_17ee5f57 :
PS1, Line 91: Notable differences are:
> To make this paragraph easier to extend, and perhaps also easier to read, I'd reorganize it a bit: […]
I like the suggested structure and restructured the paragraph accordingly. Thanks for the suggestion.
--
To view, visit https://review.coreboot.org/c/flashrom/+/82229?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I457dfec52f89997f64b6c276c50b329359d61b77
Gerrit-Change-Number: 82229
Gerrit-PatchSet: 2
Gerrit-Owner: Sydney <git(a)funkeleinhorn.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: J. Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Reviewer: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Attention: J. Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Wed, 08 May 2024 13:12:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: J. Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-MessageType: comment
Attention is currently required from: Anastasia Klimchuk, Riku Viitanen, Sydney, Thomas Heijligen.
Hello Anastasia Klimchuk, J. Neuschäfer, Riku Viitanen, Thomas Heijligen, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/82229?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: Add documentation for pico-serprog
......................................................................
Add documentation for pico-serprog
This commit adds documentation for pico-serprog by stacksmashing:
https://github.com/stacksmashing/pico-serprog
and its fork by Riku_V: https://codeberg.org/Riku_V/pico-serprog
to the serprog overview page.
Change-Id: I457dfec52f89997f64b6c276c50b329359d61b77
Signed-off-by: Funkeleinhorn <git(a)funkeleinhorn.com>
---
M doc/supported_hw/supported_prog/serprog/overview.rst
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/29/82229/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/82229?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I457dfec52f89997f64b6c276c50b329359d61b77
Gerrit-Change-Number: 82229
Gerrit-PatchSet: 2
Gerrit-Owner: Sydney <git(a)funkeleinhorn.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: J. Neuschäfer <j.neuschaefer(a)gmx.net>
Gerrit-Reviewer: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Sydney <git(a)funkeleinhorn.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
DZ has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81835?usp=email )
Change subject: flashchips: Add support for MXIC MX25L1636E
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/flashrom/+/81835?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I415e2d6c89d3d59ba44e22753001c6f69421c39d
Gerrit-Change-Number: 81835
Gerrit-PatchSet: 5
Gerrit-Owner: DZ <danielzhang(a)mxic.com.cn>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Wed, 08 May 2024 10:27:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
DZ has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81838?usp=email )
Change subject: flashchips: Add support for MXIC MX25R4035F
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/flashrom/+/81838?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I91dbc4735bf232e0b1dce72c7f06be967d35ebfb
Gerrit-Change-Number: 81838
Gerrit-PatchSet: 5
Gerrit-Owner: DZ <danielzhang(a)mxic.com.cn>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Comment-Date: Wed, 08 May 2024 10:17:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment