Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54854 )
Change subject: dummyflasher.c: Replace atoi() with strtoul()
......................................................................
Patch Set 3:
(1 comment)
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/54854/comment/7e36d786_cc759264
PS3, Line 715: free(tmp);
> Sigh, this introduces a use-after-free bug... CB:46551 and CB:54909 fixed the same kind of thing. […]
damm it. thanks Angle fixed here https://review.coreboot.org/c/flashrom/+/55014
I do want to not get too much in the way of Anastasia project though, I just wanted to unblock a couple of things.
Thanks again so much.
--
To view, visit https://review.coreboot.org/c/flashrom/+/54854
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib9e66016a2f4ce2d13b833c261f900cab80916b7
Gerrit-Change-Number: 54854
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Sam McNally <sammc(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Thu, 27 May 2021 12:41:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54854 )
Change subject: dummyflasher.c: Replace atoi() with strtoul()
......................................................................
Patch Set 3:
(1 comment)
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/54854/comment/a848741b_d7567fd3
PS3, Line 715: free(tmp);
Sigh, this introduces a use-after-free bug... CB:46551 and CB:54909 fixed the same kind of thing.
This strtoul() pattern repeats itself a lot. Why isn't it a helper function?
--
To view, visit https://review.coreboot.org/c/flashrom/+/54854
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib9e66016a2f4ce2d13b833c261f900cab80916b7
Gerrit-Change-Number: 54854
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Sam McNally <sammc(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Comment-Date: Thu, 27 May 2021 10:42:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54994 )
Change subject: mcp6x_spi.c: Refactor singleton states into reentrant pattern
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File mcp6x_spi.c:
https://review.coreboot.org/c/flashrom/+/54994/comment/dc53e92c_faf2f831
PS1, Line 42: uint8_t mcp_gpiostate;
I'd rename the struct members to drop the `mcp6x` and `mcp` prefixes. Since this patch already touches the code, one might as well do it as part of this commit.
--
To view, visit https://review.coreboot.org/c/flashrom/+/54994
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia02c1cb9d36fb7b15bb7e09b769d8969c08c2bd5
Gerrit-Change-Number: 54994
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Thu, 27 May 2021 10:24:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment