Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/52945
to look at the new patch set (#3).
Change subject: programmer_table: convert entries to pointers
......................................................................
programmer_table: convert entries to pointers
Change-Id: Ifbb0ee4db5a85b1cd2afeafe4dca838579f79878
Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de>
---
M cli_classic.c
M flashrom.c
M libflashrom.c
M print.c
M print_wiki.c
M programmer.h
M programmer_table.c
7 files changed, 567 insertions(+), 411 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/45/52945/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/52945
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifbb0ee4db5a85b1cd2afeafe4dca838579f79878
Gerrit-Change-Number: 52945
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Xiang W <wxjstz(a)126.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Thomas Heijligen.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/52946
to look at the new patch set (#4).
Change subject: programmer_table: move each entry to the associated programmer source
......................................................................
programmer_table: move each entry to the associated programmer source
Change-Id: I3d02bd789f0299e936eb86819b3b15b5ea2bb921
Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de>
---
M atahpt.c
M atapromise.c
M atavia.c
M buspirate_spi.c
M ch341a_spi.c
M dediprog.c
M developerbox_spi.c
M digilent_spi.c
M drkaiser.c
M dummyflasher.c
M ene_lpc.c
M ft2232_spi.c
M gfxnvidia.c
M internal.c
M it8212.c
M jlink_spi.c
M linux_mtd.c
M linux_spi.c
M lspcon_i2c_spi.c
M mec1308.c
M mstarddc_spi.c
M ni845x_spi.c
M nic3com.c
M nicintel.c
M nicintel_eeprom.c
M nicintel_spi.c
M nicnatsemi.c
M nicrealtek.c
M ogp_spi.c
M pickit2_spi.c
M pony_spi.c
M programmer.h
M programmer_table.c
M raiden_debug_spi.c
M rayer_spi.c
M realtek_mst_i2c_spi.c
M satamv.c
M satasii.c
M serprog.c
M stlinkv3_spi.c
M usbblaster_spi.c
41 files changed, 483 insertions(+), 593 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/46/52946/4
--
To view, visit https://review.coreboot.org/c/flashrom/+/52946
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3d02bd789f0299e936eb86819b3b15b5ea2bb921
Gerrit-Change-Number: 52946
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Xiang W <wxjstz(a)126.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-MessageType: newpatchset
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/52944
to look at the new patch set (#3).
Change subject: programmer_table: move array content to an own file
......................................................................
programmer_table: move array content to an own file
Change-Id: I8e6d704e845ee4152c8676dd19dff0934fff007b
Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de>
---
M Makefile
M flashrom.c
M meson.build
A programmer_table.c
4 files changed, 482 insertions(+), 479 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/44/52944/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/52944
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8e6d704e845ee4152c8676dd19dff0934fff007b
Gerrit-Change-Number: 52944
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Xiang W <wxjstz(a)126.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Thomas Heijligen.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/55118
to look at the new patch set (#3).
Change subject: programmer_table: print.c use fixed fixed name instead of reference
......................................................................
programmer_table: print.c use fixed fixed name instead of reference
Change-Id: If2cf95c71425efdd864457e213dd34b929fe8805
Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de>
---
M print.c
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/18/55118/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/55118
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If2cf95c71425efdd864457e213dd34b929fe8805
Gerrit-Change-Number: 55118
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Xiang W <wxjstz(a)126.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Thomas Heijligen.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/55121
to look at the new patch set (#5).
Change subject: programmer_init: use struct programmer_entry*
......................................................................
programmer_init: use struct programmer_entry*
Change-Id: Iacf0f25abc94a84c5d52c8d69a3e8640817b060a
Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.de>
---
M cli_classic.c
M flashrom.c
M libflashrom.c
M programmer.h
M tests/init_shutdown.c
5 files changed, 13 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/55121/5
--
To view, visit https://review.coreboot.org/c/flashrom/+/55121
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iacf0f25abc94a84c5d52c8d69a3e8640817b060a
Gerrit-Change-Number: 55121
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Xiang W <wxjstz(a)126.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Xiang W, Thomas Heijligen, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55115 )
Change subject: programmer_table: remove NULL termination
......................................................................
Patch Set 1: Code-Review+2
(6 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/55115/comment/3f2975e8_27e58026
PS1, Line 7: NULL
lower case `null`, it's not a NULL pointer.
https://review.coreboot.org/c/flashrom/+/55115/comment/e2f0d45a_0a0b3fa0
PS1, Line 9: Object
lower case `object`
https://review.coreboot.org/c/flashrom/+/55115/comment/ec19f1dd_ad1c41c6
PS1, Line 9: correspond
missing singular s: corresponds
https://review.coreboot.org/c/flashrom/+/55115/comment/ff5cffeb_f7224aab
PS1, Line 10: to PROGRAMMER_INVALID has no use in currend code
last but not least, missing full stop
https://review.coreboot.org/c/flashrom/+/55115/comment/1c491a59_f89f475d
PS1, Line 10: currend
current with t
Patchset:
PS1:
Not easy to prove, but I've looked through `git grep -24 programmer_table`:
For most references the index is explicitly guarded. In some cases the
global `programmer` index is used. However, these would dereference
actual NULL pointers inside the programmer struct if `programmer ==
PROGRAMMER_INVALID`. So no trouble there.
--
To view, visit https://review.coreboot.org/c/flashrom/+/55115
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib63c2d2941f23a0788e26e5a5feb25d8669acb42
Gerrit-Change-Number: 55115
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Xiang W <wxjstz(a)126.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Xiang W <wxjstz(a)126.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Sat, 05 Jun 2021 20:18:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55106 )
Change subject: nic3com.c: Refactor singleton states into reentrant pattern
......................................................................
Patch Set 1:
(2 comments)
File nic3com.c:
https://review.coreboot.org/c/flashrom/+/55106/comment/d74a640c_32cfbd83
PS1, Line 144: msg_perr("Unable to allocate space for PAR master data\n");
Shouldn't we do what nic3com_shutdown() does, here? (or call it
with a locally declared struct nic3com_data instead of the three
individual variables)
https://review.coreboot.org/c/flashrom/+/55106/comment/c65ac3f6_44464d8e
PS1, Line 152: free(data);
Same here? (although this path was already wrong before)
--
To view, visit https://review.coreboot.org/c/flashrom/+/55106
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1c3e4836760cc9f4f9a0bd4294e8d2407b150566
Gerrit-Change-Number: 55106
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Sat, 05 Jun 2021 16:49:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment