- flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[main]: ch347_spi: Add driver support for CH347F packaging
by Nicholas Chin (Code Review) 12 May '24

12 May '24

Attention is currently required from: Paul Menzel, ZhiYuanNJ. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82193?usp=email ) Change subject: ch347_spi: Add driver support for CH347F packaging ...................................................................... Patch Set 7: (1 comment) File ch347_spi.c: PS2: > Done Yes, please move the code for the device speed settings to a new commit and push another patch to Gerrit. -- To view, visit https://review.coreboot.org/c/flashrom/+/82193?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I693baf1a0d9dc20757f56fba626b5f5ad20f71dd Gerrit-Change-Number: 82193 Gerrit-PatchSet: 7 Gerrit-Owner: ZhiYuanNJ Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: ZhiYuanNJ Gerrit-Comment-Date: Sun, 12 May 2024 17:26:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ZhiYuanNJ Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: flashrom_udev.rules: Add rule for CH347
by Nicholas Chin (Code Review) 12 May '24

12 May '24

Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82162?usp=email ) Change subject: flashrom_udev.rules: Add rule for CH347 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Nicholas, just wanted to check, is this patch ready, can I submit? Yes, this patch can be submitted. -- To view, visit https://review.coreboot.org/c/flashrom/+/82162?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia83fa08f6d7c2f449b1a5c0c387c6d4368b99e3a Gerrit-Change-Number: 82162 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 12 May 2024 15:59:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: flashchips: Add (or update) chip models <list models>
by Anastasia Klimchuk (Code Review) 12 May '24

12 May '24

Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Victor Lim. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82332?usp=email ) Change subject: flashchips: Add (or update) chip models <list models> ...................................................................... Patch Set 1: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/82332/comment/a4cc4023_cc188528 : PS1, Line 7: Add (or update) chip models <list models> For this commit you can be more specific, because you know what model you adding. So instead the title (title is first line) should be: `flashchips: Add support for GD25LF128E` The rest of commit message is all good, keep it. Patchset: PS1: Great, you are getting closer, this patch is almost there! I added two comments what you need to do. If you have questions, you can reply to comments (Reply button on the comment and then Reply blue button on the top). File flashchips.c: https://review.coreboot.org/c/flashrom/+/82332/comment/5af4ddef_435fc060 : PS1, Line 6506: .model_id = GIGADEVICE_GD25LF128E, This macro should be added in the same patch as chip definition. So you need to add to this commit a change in include/flashchips.h , one line adding this macro for this model ID. I can see you made CB:82190 with all the model IDs added, but you will need to add IDs in the same patch where the chip definition is added. As an example, if you remember the other patch that was discussed on the mailing list: CB:58025. It's an example, but you can see it adds two chip definitions in flashchips.c, and two model IDs in flashchips.h. In this patch, you will have one definition and one new model ID for it. -- To view, visit https://review.coreboot.org/c/flashrom/+/82332?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I71fdc7ea1aea69d14db6af3bac2da3e7bee8abbe Gerrit-Change-Number: 82332 Gerrit-PatchSet: 1 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Victor Lim <vlim(a)gigadevice.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Sun, 12 May 2024 13:33:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[staging]: Add a generic 27C256 definition (32k UV EPROM)
by Anastasia Klimchuk (Code Review) 12 May '24

12 May '24

Attention is currently required from: Urja Rannikko. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/19616?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: Add a generic 27C256 definition (32k UV EPROM) ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Is anyone still interested in this patch? (and it's on staging branch) -- To view, visit https://review.coreboot.org/c/flashrom/+/19616?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Change-Id: Ie726ff252bc398d78e76bfb5ed01359341b734f3 Gerrit-Change-Number: 19616 Gerrit-PatchSet: 1 Gerrit-Owner: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Philippe Mathieu-Daudé <f4bug(a)amsat.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Comment-Date: Sun, 12 May 2024 11:27:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[staging]: flashchips: use 4BA direct erase functions for MX25L256
by Anastasia Klimchuk (Code Review) 12 May '24

12 May '24

Attention is currently required from: David Hendricks. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/19859?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: flashchips: use 4BA direct erase functions for MX25L256 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Is anyone still interested in this patch? (and it's on staging branch) -- To view, visit https://review.coreboot.org/c/flashrom/+/19859?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Change-Id: Ib3694eee96b5c082924fd3a9f63ea92830f896ce Gerrit-Change-Number: 19859 Gerrit-PatchSet: 1 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Comment-Date: Sun, 12 May 2024 11:26:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[main]: flashchips: Add support for MXIC MX25R2035F
by Anastasia Klimchuk (Code Review) 12 May '24

12 May '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/81839?usp=email ) Change subject: flashchips: Add support for MXIC MX25R2035F ...................................................................... flashchips: Add support for MXIC MX25R2035F The MX25R2035F has been tested by ch341a programmer : read, write, erase and wp. We have tested --wp-enable, --wp-disable, --wp-list and --wp-range commands for write-protect feature. MX25R2035F datasheet is available at the following URL: https://www.macronix.com/Lists/Datasheet/Attachments/8696/MX25R2035F,%20Wid… Change-Id: I00e76ef942976e3e102cf71fe695c6287b392b64 Signed-off-by: DanielZhang <danielzhang(a)mxic.com.cn> Reviewed-on: https://review.coreboot.org/c/flashrom/+/81839 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashchips.c M include/flashchips.h 2 files changed, 49 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/flashchips.c b/flashchips.c index 041ac40..13024de 100644 --- a/flashchips.c +++ b/flashchips.c @@ -10334,6 +10334,53 @@ { .vendor = "Macronix", + .name = "MX25R2035F", + .bustype = BUS_SPI, + .manufacture_id = MACRONIX_ID, + .model_id = MACRONIX_MX25R2035F, + .total_size = 256, + .page_size = 256, + /* OTP: 1024B total; enter 0xB1, exit 0xC1 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_CFGR, + .tested = TEST_OK_PREWB, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 64} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 8} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 4} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {1 * 256 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {1 * 256 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, /* bit 6 is quad enable */ + .unlock = SPI_DISABLE_BLOCKPROTECT_BP3_SRWD, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, /* Fast read (0x0B) and multi I/O supported */ + .voltage = {1650, 3600}, + .reg_bits = + { + .srp = {STATUS1, 7, RW}, + .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}, {STATUS1, 5, RW}}, + .tb = {CONFIG, 3, OTP} + }, + + .decode_range = DECODE_RANGE_SPI25, + }, + + { + .vendor = "Macronix", .name = "MX25R3235F", .bustype = BUS_SPI, .manufacture_id = MACRONIX_ID, diff --git a/include/flashchips.h b/include/flashchips.h index 6008ad1..1e30e84 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -541,7 +541,8 @@ #define MACRONIX_MX25R1635F 0x2815 #define MACRONIX_MX25R3235F 0x2816 #define MACRONIX_MX25R6435F 0x2817 -#define MACRONIX_MX25R8035F 0x2814 +#define MACRONIX_MX25R2035F 0x2812 +#define MACRONIX_MX25R8035F 0x2814 #define MACRONIX_MX29F001B 0x19 #define MACRONIX_MX29F001T 0x18 -- To view, visit https://review.coreboot.org/c/flashrom/+/81839?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I00e76ef942976e3e102cf71fe695c6287b392b64 Gerrit-Change-Number: 81839 Gerrit-PatchSet: 11 Gerrit-Owner: DZ <danielzhang(a)mxic.com.cn> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in flashrom[main]: flashrom-tester: Include flashrom/src/cmd.rs tests in Cargo workspace
by Anastasia Klimchuk (Code Review) 12 May '24

12 May '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/82231?usp=email ) Change subject: flashrom-tester: Include flashrom/src/cmd.rs tests in Cargo workspace ...................................................................... flashrom-tester: Include flashrom/src/cmd.rs tests in Cargo workspace Ensure ChromeOS ebuild (ecargo_test) runs all unit tests, including those under flashrom/src/cmd.rs which were previously being skipped due to not being in the default Cargo workspace. By adding flashrom/ to the [workspace] section of Cargo.toml, these tests will now be consistently included when building and testing flashrom-tester on ChromeOS. References: * ebuild of flashrom-tester: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/… * ecarg_test: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/… BUG=b:338962302 TEST=(ChromeOS) FEATURES=`test emerge-corsola flashrom-tester` Could see tests like `cmd::tests::decode_io_opt ... ok` TEST=(UPSTREAM) 1. Build flashrom by `meson` 2. Build bindings/rust/libflashrom by `cargo build` 3. Build util/flashrom_tester by `cargo build` `cargo test --workspace` Could see tests like `cmd::tests::decode_io_opt ... ok` Change-Id: Ic23bc35592e6d7d8dd24c71630ea9a2eb2d58573 Signed-off-by: Hsuan Ting Chen <roccochen(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/82231 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M util/flashrom_tester/Cargo.toml 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Angel Pons: Looks good to me, but someone else must approve Anastasia Klimchuk: Looks good to me, approved build bot (Jenkins): Verified diff --git a/util/flashrom_tester/Cargo.toml b/util/flashrom_tester/Cargo.toml index a76a5b4..50c73dd 100644 --- a/util/flashrom_tester/Cargo.toml +++ b/util/flashrom_tester/Cargo.toml @@ -15,6 +15,9 @@ name = "flashrom_tester" required-features = ["cli"] +[workspace] +members = [".", "flashrom"] + [dependencies] atty = "0.2" built = { version = "0.5", features = ["chrono"] } -- To view, visit https://review.coreboot.org/c/flashrom/+/82231?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ic23bc35592e6d7d8dd24c71630ea9a2eb2d58573 Gerrit-Change-Number: 82231 Gerrit-PatchSet: 5 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Evan Benn <evanbenn(a)gmail.com> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in flashrom[main]: erasure_layout: don't copy region buffers if they're null/zero-size
by Anastasia Klimchuk (Code Review) 12 May '24

12 May '24

Attention is currently required from: Aarya, Alexander Goncharov, Nikolai Artemiev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81548?usp=email ) Change subject: erasure_layout: don't copy region buffers if they're null/zero-size ...................................................................... Patch Set 2: (4 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/81548/comment/fd0cc90d_526bab2a : PS2, Line 10: the pointer is null I think from the meaning of the patch, you meant to say `the pointer is non-null` File erasure_layout.c: https://review.coreboot.org/c/flashrom/+/81548/comment/7680b945_70a9f658 : PS1, Line 263: old_start_buf = (uint8_t *)malloc(old_start - region_start); : if (!old_start_buf) { : msg_cerr("Not enough memory!\n"); : ret = -1; : goto _end; : } : old_end_buf = (uint8_t *)malloc(region_end - old_end); : if (!old_end_buf) { : msg_cerr("Not enough memory!\n"); : ret = -1; : goto _end; : } > Sorry it took longer than I expected. […] Great! this is what I was thinking about! I am resolving this comment. I added few more other comments though :) File erasure_layout.c: https://review.coreboot.org/c/flashrom/+/81548/comment/dd093a22_69ec2718 : PS2, Line 263: size_t old_start_len This can be const, but also maybe rename it into `start_buf_len` ? I think that "old" suffix doesn't really explain anything. What do you think? https://review.coreboot.org/c/flashrom/+/81548/comment/47062ded_d9a3f306 : PS2, Line 264: size_t old_end_len And this can be const and `end_buf_len` -- To view, visit https://review.coreboot.org/c/flashrom/+/81548?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I99aad4119f9c11bea75e3419926cc833bc1f68c5 Gerrit-Change-Number: 81548 Gerrit-PatchSet: 2 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Sun, 12 May 2024 11:00:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[XS] Change in flashrom[main]: flashrom_udev.rules: Add rule for CH347
by Anastasia Klimchuk (Code Review) 12 May '24

12 May '24

Attention is currently required from: Nicholas Chin. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82162?usp=email ) Change subject: flashrom_udev.rules: Add rule for CH347 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Nicholas, just wanted to check, is this patch ready, can I submit? -- To view, visit https://review.coreboot.org/c/flashrom/+/82162?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia83fa08f6d7c2f449b1a5c0c387c6d4368b99e3a Gerrit-Change-Number: 82162 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sun, 12 May 2024 08:04:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[main]: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME
by Anastasia Klimchuk (Code Review) 12 May '24

12 May '24

Attention is currently required from: Angel Pons, Martin L Roth, Martin Roth, Peter Marheine, Raj Astekar, Ravishankar Sarawadi, Wonkyu Kim. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58025?usp=email ) Change subject: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME ...................................................................... Patch Set 8: (10 comments) Patchset: PS8: > I read through the comments thread to recall what the patch have been waiting for. […] Many thanks to Victor on the mailing list for giving datasheets, I did a review and added some comments. File flashchips.c: https://review.coreboot.org/c/flashrom/+/58025/comment/76651360_3fec0d74 : PS8, Line 6552: .name = "GD25LR256E", This is out of order, both entries need to be moved after GD25LQ80 and just before GD25Q10 https://review.coreboot.org/c/flashrom/+/58025/comment/0deca606_33434b56 : PS8, Line 6590: SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD Datasheet has BP4, so this should be `SPI_PRETTYPRINT_STATUS_REGISTER_BP4_SRWD` https://review.coreboot.org/c/flashrom/+/58025/comment/343681e1_32b6595a : PS8, Line 6591: SPI_DISABLE_BLOCKPROTECT SPI_DISABLE_BLOCKPROTECT_BP4_SRWD https://review.coreboot.org/c/flashrom/+/58025/comment/e256659a_175ff710 : PS8, Line 6594: {1600, 2000} Slight correction : from datasheet it's 1.65~2.0V https://review.coreboot.org/c/flashrom/+/58025/comment/69474edd_5fc8758d : PS8, Line 6599: .tb = {STATUS1, 6, RW}, In such cases you should add a comment: `Called BP4 in datasheet, acts like TB` https://review.coreboot.org/c/flashrom/+/58025/comment/4ea82095_fcd0841a : PS8, Line 6646: SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD SPI_PRETTYPRINT_STATUS_REGISTER_BP4_SRWD https://review.coreboot.org/c/flashrom/+/58025/comment/f67121aa_1a0a7e2d : PS8, Line 6647: SPI_DISABLE_BLOCKPROTECT SPI_DISABLE_BLOCKPROTECT_BP4_SRWD https://review.coreboot.org/c/flashrom/+/58025/comment/b194c85c_4bf5c3fd : PS8, Line 6650: {1600, 2000}, 1.65~2.0V https://review.coreboot.org/c/flashrom/+/58025/comment/410965dc_2c5da58a : PS8, Line 6655: .tb = {STATUS1, 6, RW}, Also as above, needs a comment: `Called BP4 in datasheet, acts like TB` -- To view, visit https://review.coreboot.org/c/flashrom/+/58025?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I2fe6bc1219cd1ee19b93caabab69de938cfc44b0 Gerrit-Change-Number: 58025 Gerrit-PatchSet: 8 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sun, 12 May 2024 08:02:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit