Attention is currently required from: Edward O'Callaghan, Angel Pons, Daniel Campello, Anastasia Klimchuk.
Hello build bot (Jenkins), Thomas Heijligen, David Hendricks, Edward O'Callaghan, Daniel Campello, Angel Pons, Arthur Heymans, Anastasia Klimchuk, Peter Marheine,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/33521
to look at the new patch set (#10).
Change subject: layout: Use linked list for `struct romentry`
......................................................................
layout: Use linked list for `struct romentry`
This gets rid of the entry limit and hopefully makes future layout
handling easier. We start by making `struct flashrom_layout` private
to `layout.c`.
Change-Id: I60a0aa1007ebcd5eb401db116f835d129b3e9732
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M layout.c
M layout.h
M libflashrom.c
3 files changed, 51 insertions(+), 71 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/33521/10
--
To view, visit https://review.coreboot.org/c/flashrom/+/33521
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I60a0aa1007ebcd5eb401db116f835d129b3e9732
Gerrit-Change-Number: 33521
Gerrit-PatchSet: 10
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Daniel Campello <campello(a)chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan, Daniel Campello, Peter Marheine.
Hello build bot (Jenkins), Thomas Heijligen, Edward O'Callaghan, Daniel Campello, Anastasia Klimchuk, Peter Marheine,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/54286
to look at the new patch set (#7).
Change subject: layout: Kill the global layout
......................................................................
layout: Kill the global layout
Change-Id: Ic302e9c5faf1368e5ca244ce461e55e14f916ab8
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M cli_classic.c
M flash.h
M layout.c
M layout.h
4 files changed, 11 insertions(+), 27 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/54286/7
--
To view, visit https://review.coreboot.org/c/flashrom/+/54286
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic302e9c5faf1368e5ca244ce461e55e14f916ab8
Gerrit-Change-Number: 54286
Gerrit-PatchSet: 7
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Daniel Campello <campello(a)chromium.org>
Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Edward O'Callaghan, Angel Pons, Daniel Campello, Anastasia Klimchuk.
Hello build bot (Jenkins), Thomas Heijligen, David Hendricks, Edward O'Callaghan, Daniel Campello, Angel Pons, Arthur Heymans, Anastasia Klimchuk, Peter Marheine,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/33521
to look at the new patch set (#9).
Change subject: layout: Use linked list for `struct romentry`
......................................................................
layout: Use linked list for `struct romentry`
This gets rid of the entry limit and hopefully makes future layout
handling easier. We start by making `struct flashrom_layout` private
to `layout.c`.
Change-Id: I60a0aa1007ebcd5eb401db116f835d129b3e9732
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M layout.c
M layout.h
M libflashrom.c
3 files changed, 48 insertions(+), 71 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/33521/9
--
To view, visit https://review.coreboot.org/c/flashrom/+/33521
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I60a0aa1007ebcd5eb401db116f835d129b3e9732
Gerrit-Change-Number: 33521
Gerrit-PatchSet: 9
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Daniel Campello <campello(a)chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: newpatchset
Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/55866 )
Change subject: util: Give the udev-rules file a meaningful name
......................................................................
util: Give the udev-rules file a meaningful name
Rename `z60_flashrom.rules` to `flashrom_udev.rules`.
Change-Id: I1e7918d3121d89d3c388745e433a3a413eac0e21
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
R util/flashrom_udev.rules
1 file changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/66/55866/1
diff --git a/util/z60_flashrom.rules b/util/flashrom_udev.rules
similarity index 100%
rename from util/z60_flashrom.rules
rename to util/flashrom_udev.rules
--
To view, visit https://review.coreboot.org/c/flashrom/+/55866
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1e7918d3121d89d3c388745e433a3a413eac0e21
Gerrit-Change-Number: 55866
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: newchange
Attention is currently required from: Edward O'Callaghan, Angel Pons, Daniel Campello, Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33521 )
Change subject: layout: Use linked list for `struct romentry`
......................................................................
Patch Set 8:
(2 comments)
File layout.c:
https://review.coreboot.org/c/flashrom/+/33521/comment/0111516e_643ae007
PS8, Line 388: *layout = malloc(sizeof(**layout));
> Given that you memset() the allocated space afterwards, use calloc() instead?
I like to see it explicitly if something is cleared explicitly. I can try
something else, though. Maybe you'll like it better.
https://review.coreboot.org/c/flashrom/+/33521/comment/00d12983_54967aad
PS8, Line 458: if (layout == global_layout)
: return;
:
: while (layout && layout->head) {
: struct romentry *const entry = layout->head;
: layout->head = entry->next;
: free(entry->file);
: free(entry->name);
: free(entry);
: }
: free(layout);
> Given that `layout` is not modified in the while loop, how about evaluating it once? […]
Ack. Might make it less odd to read.
--
To view, visit https://review.coreboot.org/c/flashrom/+/33521
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I60a0aa1007ebcd5eb401db116f835d129b3e9732
Gerrit-Change-Number: 33521
Gerrit-PatchSet: 8
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Daniel Campello <campello(a)chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Sat, 26 Jun 2021 00:10:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55647 )
Change subject: ich_descriptors: Revise detection for chipsets w/ ICCRIBA
......................................................................
Patch Set 4:
(1 comment)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/55647/comment/ea3e311a_6d5aeb11
PS3, Line 946: } else if (upper->MDTBA == 0x00) {
> It seems much more invasive, do you want to do it? Anything to do here?
Ping
--
To view, visit https://review.coreboot.org/c/flashrom/+/55647
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I587ad1abe390843d4a9e74431b6fc4b63f8ba512
Gerrit-Change-Number: 55647
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Comment-Date: Fri, 25 Jun 2021 23:43:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-MessageType: comment
Attention is currently required from: Xiang W, Angel Pons.
Hello Xiang W, Angel Pons,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/flashrom/+/55862
to review the following change.
Change subject: [NOTFORMERGE] Add thoughts about bitbang CPOL/CPHA patches
......................................................................
[NOTFORMERGE] Add thoughts about bitbang CPOL/CPHA patches
Change-Id: I6a4b64c686497a7df99ea50273ed90105d669858
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M Documentation/bitbang_spi_analysis.md
1 file changed, 95 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/62/55862/1
diff --git a/Documentation/bitbang_spi_analysis.md b/Documentation/bitbang_spi_analysis.md
index 293abe5..02196af 100644
--- a/Documentation/bitbang_spi_analysis.md
+++ b/Documentation/bitbang_spi_analysis.md
@@ -148,3 +148,98 @@
This would have to be tested. It even seems possible that raising
`.half_period` above 0 together with this optimization might
increase the speed and reliability.
+
+What happens with CB:49255 (bitbang-spi.c: support clock polarity and phase)
+----------------------------------------------------------------------------
+
+Let's assume the default `cpol = 0`, `cpha = 0`.
+
+ __ h h h h h h h h
+ CS# |_____________________________________
+ ____ ____ ____ ____
+ SCK ______| |___| |___| |___| |_
+
+ MOSI XXXXXXX111111111222222222222222222222222
+
+ MISO XXXXXXXXXXXXXXXXXXXXXX333333333444444444
+ ^ ^
+
+MOSI is off by `.half_period`. It should be sampled right after the
+rising edge of `SCK` where it's unstable. Still, how does it look
+like with `.half_period = 0`?
+
+ __
+ CS# |_____________
+ _ _ _ _
+ SCK ___| || || || |_
+
+ MOSI XXXX111222222222
+
+ MISO XXXXXXXXXX333444
+ ^ ^
+
+Roughly the same, although MISO looks a little tighter. Note that
+the `SCK` pattern is the same now for writing and reading. This is
+because programming `MOSI` happens at the wrong time.
+
+Fixup to CB:49255 (bitbang_spi.c: fix spi sequence in time and rename)
+----------------------------------------------------------------------
+
+ __ h h h h h h h h
+ CS# |_____________________________________
+ ___ ___ ____ ____
+ SCK _______| |____| |___| |___| |_
+
+ MOSI XXXXXX1111111112222222222222222222222222
+
+ MISO XXXXXXXXXXXXXXXXXXXXXX333333333444444444
+ ^ ^
+
+This gives a little more margin to the botched `MOSI` setting. But,
+if looked at with a high `.half_period`, it would still look the
+same. However, with `.half_period = 0`
+
+ __
+ CS# |_____________
+ _ _
+ SCK ____||_||| || |_
+
+ MOSI XXX1112222222222
+
+ MISO XXXXXXXXXX333444
+ ^ ^
+
+things look better. The rising edge of `SCK` aligns again with
+`MOSI`. So the fixup fixes the regression for programmers with
+`.half_period = 0`. Not necessarily for other values.
+
+Let's have a final look at this version for programmers that
+pack the `SCK` setting with programming `MOSI` and sampling
+`MISO`.
+
+ __ h h h h h h h h
+ CS# |_________________________________
+ ___ ___ ___ ___
+ SCK ______| |___| |___| |___| |_
+
+ MOSI XXXXXX111111112222222222222222222222
+
+ MISO XXXXXXXXXXXXXXXXXXXX3333333344444444
+ ^ ^
+
+As things are packed, it's the same as without the fixup. And
+without `.half_period`:
+
+ __
+ CS# |_________
+
+ SCK ___||||||||_
+
+ MOSI XXX112222222
+
+ MISO XXXXXXXX3344
+ ^ ^
+
+`MOSI` is still less likely to be stable at the rising edge of
+`SCK`. For sampling `MISO` it's the same as for current `master`
+(after commit 455a6fc8).
--
To view, visit https://review.coreboot.org/c/flashrom/+/55862
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6a4b64c686497a7df99ea50273ed90105d669858
Gerrit-Change-Number: 55862
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Xiang W <wxjstz(a)126.com>
Gerrit-Attention: Xiang W <wxjstz(a)126.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newchange