Attention is currently required from: Nico Huber, Paul Menzel.
Hello build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/55866
to look at the new patch set (#3).
Change subject: util: Name udev-rules file accordingly
......................................................................
util: Name udev-rules file accordingly
Rename `z60_flashrom.rules` to `flashrom_udev.rules`.
Change-Id: I1e7918d3121d89d3c388745e433a3a413eac0e21
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
R util/flashrom_udev.rules
1 file changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/66/55866/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/55866
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1e7918d3121d89d3c388745e433a3a413eac0e21
Gerrit-Change-Number: 55866
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber, Paul Menzel.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55866 )
Change subject: util: Name udev-rules file meaningfully
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/55866/comment/454ac8ec_31235645
PS1, Line 9: Rename `z60_flashrom.rules` to `flashrom_udev.rules`.
> @Paul: Maybe. However, since this is the flashrom repository it might be not clear. […]
Done
--
To view, visit https://review.coreboot.org/c/flashrom/+/55866
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1e7918d3121d89d3c388745e433a3a413eac0e21
Gerrit-Change-Number: 55866
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Sat, 26 Jun 2021 14:54:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Paul Menzel.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55866 )
Change subject: util: Name udev-rules file meaningfully
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/55866/comment/353ec083_1674a7cf
PS1, Line 7: util: Give the udev-rules file a meaningful name
> Name udev-rules meaningfully
Done
https://review.coreboot.org/c/flashrom/+/55866/comment/09e51e02_c86ac898
PS1, Line 9: Rename `z60_flashrom.rules` to `flashrom_udev.rules`.
> Is there a standard for that ordering?
@Paul: Maybe. However, since this is the flashrom repository it might be not clear. This way it's more recognizable. Package maintainers can still rename it.
--
To view, visit https://review.coreboot.org/c/flashrom/+/55866
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1e7918d3121d89d3c388745e433a3a413eac0e21
Gerrit-Change-Number: 55866
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Sat, 26 Jun 2021 14:54:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment