Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/flashrom/+/56030 )
Change subject: print_wiki.c: Update mailing list reference
......................................................................
print_wiki.c: Update mailing list reference
Change-Id: I5c67b5b3be2f306132d8565539bbf10477222026
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/56030
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org>
---
M print_wiki.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Nico Huber: Looks good to me, approved
Edward O'Callaghan: Looks good to me, approved
diff --git a/print_wiki.c b/print_wiki.c
index 9af2e3e..2c8c109 100644
--- a/print_wiki.c
+++ b/print_wiki.c
@@ -80,7 +80,7 @@
or may not be added later.\n\n\
Mainboards (or individual revisions) which don't appear in the list may or may \
not work (we don't know, someone has to give it a try). Please report any \
-further verified mainboards on the [[Mailinglist|mailing list]].\n";
+further verified mainboards on the [[Contact#Mailing_List|mailing list]].\n";
#endif
static const char chip_th[] = "\
--
To view, visit https://review.coreboot.org/c/flashrom/+/56030
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5c67b5b3be2f306132d8565539bbf10477222026
Gerrit-Change-Number: 56030
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Victor Ding, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56475 )
Change subject: ene_lpc: remove ENE LPC programmer
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/56475/comment/57a39be1_997aec61
PS1, Line 10: reached Auto Update Expiration (AUE) a.k.a. end-of-life.
I suppose this is why nobody will object to the removal. Generally,
EOL products is not a reason to remove code from upstream flashrom.
The real reason, I guess, is that it was submitted in an untested,
unknown, undocumented state and nobody wants to fix that?
--
To view, visit https://review.coreboot.org/c/flashrom/+/56475
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3f40db22c42c04ce029c4defd837e05ebb550c9b
Gerrit-Change-Number: 56475
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Ding <victording(a)google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Victor Ding <victording(a)google.com>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Wed, 21 Jul 2021 10:59:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56469 )
Change subject: programmer_table: Remove space between address operator and variable
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File programmer_table.c:
https://review.coreboot.org/c/flashrom/+/56469/comment/3f0a7314_b66e9803
PS1, Line 176: const size_t programmer_table_size = ARRAY_SIZE(programmer_table);
> coreboot has a lint check for this. My editor automatically adds the newline.
We avoid /empty/ lines at the end. ASCII text files are supposed to end
with a new-line character, though (only broken editors don't add it).
This fixes it. (Gerrit shows the last new-line as an empty line but
there is none.)
--
To view, visit https://review.coreboot.org/c/flashrom/+/56469
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iba29b1bc3d77b8c17c51fc0552c129e6965fa308
Gerrit-Change-Number: 56469
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Wed, 21 Jul 2021 10:53:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Edward O'Callaghan.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56466 )
Change subject: programmer.h: Minor tidy up
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Do we need any of the #ifdef at all?
--
To view, visit https://review.coreboot.org/c/flashrom/+/56466
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7ceda32b66d17318d42b94a1fab621a9a926fa77
Gerrit-Change-Number: 56466
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Comment-Date: Wed, 21 Jul 2021 10:45:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56469 )
Change subject: programmer_table: Remove space between address operator and variable
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File programmer_table.c:
https://review.coreboot.org/c/flashrom/+/56469/comment/ab7282c7_460b3e64
PS1, Line 176: const size_t programmer_table_size = ARRAY_SIZE(programmer_table);
> I was told to avoid new lines at the end. But don't know if there are fixed style guidelines.
coreboot has a lint check for this. My editor automatically adds the newline.
--
To view, visit https://review.coreboot.org/c/flashrom/+/56469
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iba29b1bc3d77b8c17c51fc0552c129e6965fa308
Gerrit-Change-Number: 56469
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Wed, 21 Jul 2021 09:07:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, David Hendricks, Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Victor Ding has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56102 )
Change subject: spi_master: Add default write_aai function to masters that have none
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> The last possible use of these programmers I found was Daisy, which reached EoL in June 2019 (HP Chr […]
Once this patch series merged, CB:56475 and CB:56476 will delete ene_lpc and mec1308.
--
To view, visit https://review.coreboot.org/c/flashrom/+/56102
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I712e74e11244e1f0ab8d8e245fcd5207ce211219
Gerrit-Change-Number: 56102
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Victor Ding <victording(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Wed, 21 Jul 2021 08:23:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Victor Ding <victording(a)google.com>
Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com>
Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: comment
Victor Ding has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/55890 )
Change subject: Allow MEC1308 to build against DOS and libpayload
......................................................................
Abandoned
No longer needed because of CB:56476.
--
To view, visit https://review.coreboot.org/c/flashrom/+/55890
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic50fa2841b9e01b008ce82462e2b7120ee490a68
Gerrit-Change-Number: 55890
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Ding <victording(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon