- flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: tuxedo_ec: Implement support for flashing ECs on TUXEDO laptops
by Michael Niewöhner (Code Review) 22 Jun '21

22 Jun '21

Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 ) Change subject: tuxedo_ec: Implement support for flashing ECs on TUXEDO laptops ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > > I wouldn't craft a sanity check through user action (having to specify the I/O port pair) but having a list of supported EC's sounds like a good idea but I wonder if we should check the chip id or better the firmware id (e.g. the "ITE string" or sth else) because support for this firmware-based programming mechanism is implemented in EC fw. > > Probing I/O ports is fragile, as there's no universal mechanism to enumerate/discover devices... Probing the two most common Super I/O port pairs shouldn't hurt, especially when explicitly choosing this programmer. I agree that determining whether the EC firmware exposes the correct interface isn't easy. Still, after making sure that the EC hardware matches, testing whether the firmware interface is usable should be less error-prone. Ideas welcome. I agree. Probing the two commons is just fine > > The other approach is direct flashing via the flash registers (see it85spi.c, it87spi.c for example), which *should* also work on various ITE ec's even without firmware support. > > The code for it85spi.c never runs (function call is commented out). It's hooked to the "internal" programmer, and doesn't check if the machine is supported. I tried to use it a few years ago on an HP laptop with an ITE IT8502E EC: while flashrom managed to detect the EC's flash chip, the laptop suddenly powered off after a few seconds, reproducibly. This is less of an issue with it87spi.c and wbsio_spi.c because these Super I/Os don't run custom (cursed) firmware. ouch. yeah, firmware is the difference. See my latest comment, too -- To view, visit https://review.coreboot.org/c/flashrom/+/55715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031 Gerrit-Change-Number: 55715 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 22 Jun 2021 11:45:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tuxedo_ec: Implement support for flashing ECs on TUXEDO laptops
by Angel Pons (Code Review) 22 Jun '21

22 Jun '21

Attention is currently required from: Felix Singer, Nico Huber, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 ) Change subject: tuxedo_ec: Implement support for flashing ECs on TUXEDO laptops ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > I wouldn't craft a sanity check through user action (having to specify the I/O port pair) but having a list of supported EC's sounds like a good idea but I wonder if we should check the chip id or better the firmware id (e.g. the "ITE string" or sth else) because support for this firmware-based programming mechanism is implemented in EC fw. Probing I/O ports is fragile, as there's no universal mechanism to enumerate/discover devices... Probing the two most common Super I/O port pairs shouldn't hurt, especially when explicitly choosing this programmer. I agree that determining whether the EC firmware exposes the correct interface isn't easy. Still, after making sure that the EC hardware matches, testing whether the firmware interface is usable should be less error-prone. Ideas welcome. > The other approach is direct flashing via the flash registers (see it85spi.c, it87spi.c for example), which *should* also work on various ITE ec's even without firmware support. The code for it85spi.c never runs (function call is commented out). It's hooked to the "internal" programmer, and doesn't check if the machine is supported. I tried to use it a few years ago on an HP laptop with an ITE IT8502E EC: while flashrom managed to detect the EC's flash chip, the laptop suddenly powered off after a few seconds, reproducibly. This is less of an issue with it87spi.c and wbsio_spi.c because these Super I/Os don't run custom (cursed) firmware. -- To view, visit https://review.coreboot.org/c/flashrom/+/55715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031 Gerrit-Change-Number: 55715 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Tue, 22 Jun 2021 11:38:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tuxedo_ec: Implement support for flashing ECs on TUXEDO laptops
by Michael Niewöhner (Code Review) 22 Jun '21

22 Jun '21

Attention is currently required from: Felix Singer, Nico Huber, Angel Pons, Michael Niewöhner. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 ) Change subject: tuxedo_ec: Implement support for flashing ECs on TUXEDO laptops ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: The IT8987E and IT5570E/IT5576E are a bit special. The reason for this is, that it has internal flash (called eflash) and supports external flash as well. One example where this gets used is the Clevo L140CU/L140MU (PCZ Lafité Pro 14" / Tuxedo Infinitybook S14 V5 / SCHENKER VIA 14 / ...), where some sort of mirroring between these two flashes is happening. Do you have any idea, if we need to take special care of that mirroring mechanism or if it's handled by the ec firmware? Unfortunately, that mechanism is not documented at all in the regular EC's datasheet(s). The only thing I know is that pin GPG2 acts as strap for preventing that mirroring (verified by asking ITE, but got no mirroring datasheet b/c it requires NDA). If you have access to ITE ec source (e.g. IT8987E), look out for `SPI_MIRROR_MODE` (GPG2 strap) and `SUPPORT_MIRROR_ONCE`. -- To view, visit https://review.coreboot.org/c/flashrom/+/55715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031 Gerrit-Change-Number: 55715 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Tue, 22 Jun 2021 11:38:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tuxedo_ec: Implement support for flashing ECs on TUXEDO laptops
by Michał Żygowski (Code Review) 22 Jun '21

22 Jun '21

Attention is currently required from: Felix Singer, Nico Huber, Angel Pons, Michael Niewöhner. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 ) Change subject: tuxedo_ec: Implement support for flashing ECs on TUXEDO laptops ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: I am open to suggestions how to generalize it. I am not familiar with ITE EC firmware framework. We have been working purely with EFI binaries to update the firmware and this is the result. > Oh, good to know. We don't need to perform any DMI checks, then: given that no probing is done (one has to explicitly choose this programmer), the drawbacks of safeguarding against using it on a "wrong" machine by accident outweigh the benefits. > With this in mind, one could add some sanity checks for ITE ECs: Have users specify the Super I/O port pair (e.g. 0x2e/0x2f or 0x4e/0x4f), retrieve the chip ID at indices 0x20/0x21 and find a match in a table of supported ECs. This could also be used to handle the ITE IT5570E differences. I can do that. Probing both port pairs should not be a problem, why bother the user to select the ports. > Users could also specify the PMC (Power Management I/F Channel) to use to talk to the EC, have the code ensure the specified PMC LDN is enabled, and use the port pair values from the LDN IOBADx registers (indices 0x60 to 0x63) instead of having the user specify them. I don't have the datasheet of these ECs so I don't exactly know what to do with it. If if understood correclty, the PMC LDN holds the I/O port pairs at indices 0x60 and higher? > The other approach is direct flashing via the flash registers (see it85spi.c, it87spi.c for example), which *should* also work on various ITE ec's even without firmware support. Good to know, however I am obliged to implement and prove the firmware support way. So basically we can rename the programmer to something like ite_ec. Any other suggestions? -- To view, visit https://review.coreboot.org/c/flashrom/+/55715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031 Gerrit-Change-Number: 55715 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Tue, 22 Jun 2021 11:37:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tuxedo_ec: Implement support for flashing ECs on TUXEDO laptops
by Michael Niewöhner (Code Review) 22 Jun '21

22 Jun '21

Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 ) Change subject: tuxedo_ec: Implement support for flashing ECs on TUXEDO laptops ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Oh, good to know. […] I wouldn't craft a sanity check through user action (having to specify the I/O port pair) but having a list of supported EC's sounds like a good idea but I wonder if we should check the chip id or better the firmware id (e.g. the "ITE string" or sth else) because support for this firmware-based programming mechanism is implemented in EC fw. The other approach is direct flashing via the flash registers (see it85spi.c, it87spi.c for example), which *should* also work on various ITE ec's even without firmware support. -- To view, visit https://review.coreboot.org/c/flashrom/+/55715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031 Gerrit-Change-Number: 55715 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 22 Jun 2021 11:23:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flashchips.c: Add 'GD25LQ128E' to match C and D variants
by Angel Pons (Code Review) 22 Jun '21

22 Jun '21

Attention is currently required from: Edward O'Callaghan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55742 ) Change subject: flashchips.c: Add 'GD25LQ128E' to match C and D variants ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/55742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3bef9386a185a0e8c54c125af5509b63540995aa Gerrit-Change-Number: 55742 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Tue, 22 Jun 2021 10:42:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tests: Do not run a test if its driver is not built
by Angel Pons (Code Review) 22 Jun '21

22 Jun '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55295 ) Change subject: tests: Do not run a test if its driver is not built ...................................................................... Patch Set 4: Code-Review+2 (1 comment) File tests/init_shutdown.c: https://review.coreboot.org/c/flashrom/+/55295/comment/40cb7fd4_44eec321 PS1, Line 35: #if CONFIG_DUMMY == 1 : void dummy_init_and_shutdown_test_success(void **state) : { : run_lifecycle(state, PROGRAMMER_DUMMY, "bus=parallel+lpc+fwh+spi"); : } : #endif /* CONFIG_DUMMY */ > I returned back to #if for now. But if it comes to changing meson. […] Sounds good. -- To view, visit https://review.coreboot.org/c/flashrom/+/55295 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic1c48e41f658045a608f46636071f478ba646f77 Gerrit-Change-Number: 55295 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 22 Jun 2021 10:38:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: tuxedo_ec: Implement support for flashing ECs on TUXEDO laptops
by Angel Pons (Code Review) 22 Jun '21

22 Jun '21

Attention is currently required from: Felix Singer, Nico Huber, Michał Żygowski, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 ) Change subject: tuxedo_ec: Implement support for flashing ECs on TUXEDO laptops ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Well, Tuxedo sells Clevo notebooks. Clevo uses ITE EC with ITE EC firmware framework. […] Oh, good to know. We don't need to perform any DMI checks, then: given that no probing is done (one has to explicitly choose this programmer), the drawbacks of safeguarding against using it on a "wrong" machine by accident outweigh the benefits. With this in mind, one could add some sanity checks for ITE ECs: Have users specify the Super I/O port pair (e.g. 0x2e/0x2f or 0x4e/0x4f), retrieve the chip ID at indices 0x20/0x21 and find a match in a table of supported ECs. This could also be used to handle the ITE IT5570E differences. Users could also specify the PMC (Power Management I/F Channel) to use to talk to the EC, have the code ensure the specified PMC LDN is enabled, and use the port pair values from the LDN IOBADx registers (indices 0x60 to 0x63) instead of having the user specify them. TL;DR: I'm now convinced that the programmer-specific code shoved between reading and writing the flash chip should be removed completely. -- To view, visit https://review.coreboot.org/c/flashrom/+/55715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031 Gerrit-Change-Number: 55715 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Tue, 22 Jun 2021 10:18:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer: Introduce default shutdown function
by Anastasia Klimchuk (Code Review) 22 Jun '21

22 Jun '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54890 ) Change subject: programmer: Introduce default shutdown function ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/54890/comment/1c6afdd1_03de0eef PS1, Line 13: lot of par masters that : will use it in the nearest future. > I have an update: there are 4 more customers that would be using default_shutdown function (bitbang […] I am resolving the comment, this is ready for review. Patchset: PS4: rebased on the top of latest changes -- To view, visit https://review.coreboot.org/c/flashrom/+/54890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8b20717ba549e12edffbc5d1643ff064a4f0c517 Gerrit-Change-Number: 54890 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 22 Jun 2021 06:37:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: programmer: Introduce default shutdown function
by Anastasia Klimchuk (Code Review) 22 Jun '21

22 Jun '21

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Hello build bot (Jenkins), Nico Huber, Edward O'Callaghan, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/54890 to look at the new patch set (#4). Change subject: programmer: Introduce default shutdown function ...................................................................... programmer: Introduce default shutdown function Default shutdown function is only freeing master data (if data exists) and not doing anything else. There are five spi masters which can use default shutdown function (all included in this patch), and a lot of par masters that can benefit from it as well. BUG=b:185191942 TEST=builds Change-Id: I8b20717ba549e12edffbc5d1643ff064a4f0c517 Signed-off-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M flashrom.c M mcp6x_spi.c M nicintel_spi.c M ogp_spi.c M programmer.h M rayer_spi.c M usbblaster_spi.c 7 files changed, 12 insertions(+), 35 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/90/54890/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/54890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8b20717ba549e12edffbc5d1643ff064a4f0c517 Gerrit-Change-Number: 54890 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit