- flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: tests: Move test environment header files into tests directory
by Edward O'Callaghan (Code Review) 11 Jun '21

11 Jun '21

Attention is currently required from: Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55408 ) Change subject: tests: Move test environment header files into tests directory ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/55408 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia42773b98b1eb6c65241aa559c0c8b4926bd0814 Gerrit-Change-Number: 55408 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 11 Jun 2021 14:43:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: bitbang_spi.c: fix spi sequence in time and rename
by Angel Pons (Code Review) 11 Jun '21

11 Jun '21

Attention is currently required from: Nico Huber, Xiang W, Stefan Reinauer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49264 ) Change subject: bitbang_spi.c: fix spi sequence in time and rename ...................................................................... Patch Set 16: Code-Review-2 (1 comment) Patchset: PS16: > SCK and MOSI should be changed at once and some bitbang programmers […] Definitely. -- To view, visit https://review.coreboot.org/c/flashrom/+/49264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I107803afef044996c94ebfaf0b0e0040cea9f8c1 Gerrit-Change-Number: 49264 Gerrit-PatchSet: 16 Gerrit-Owner: Xiang W <wxjstz(a)126.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Fri, 11 Jun 2021 14:38:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: bitbang_spi.c: fix spi sequence in time and rename
by Edward O'Callaghan (Code Review) 11 Jun '21

11 Jun '21

Attention is currently required from: Xiang W, Stefan Reinauer, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49264 ) Change subject: bitbang_spi.c: fix spi sequence in time and rename ...................................................................... Patch Set 16: -Code-Review (1 comment) Patchset: PS16: I noticed bits of this are in a long discussion in https://review.coreboot.org/c/flashrom/+/49255/28 -- To view, visit https://review.coreboot.org/c/flashrom/+/49264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I107803afef044996c94ebfaf0b0e0040cea9f8c1 Gerrit-Change-Number: 49264 Gerrit-PatchSet: 16 Gerrit-Owner: Xiang W <wxjstz(a)126.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-Attention: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Jun 2021 14:38:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: bitbang_spi.c: fix bitbang_spi_send_command to make the delay symmetric
by Edward O'Callaghan (Code Review) 11 Jun '21

11 Jun '21

Attention is currently required from: Nico Huber, Xiang W, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49262 ) Change subject: bitbang_spi.c: fix bitbang_spi_send_command to make the delay symmetric ...................................................................... Patch Set 25: -Code-Review (1 comment) Patchset: PS25: > Also CB:49264 I do now thanks for pointing it out! The patch stream is a bit confused and hard to following coming back to it. -- To view, visit https://review.coreboot.org/c/flashrom/+/49262 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icf8b65aed20244ccffc231da2c599c6ca1796104 Gerrit-Change-Number: 49262 Gerrit-PatchSet: 25 Gerrit-Owner: Xiang W <wxjstz(a)126.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Jun 2021 14:35:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: buspirate_spi.c: Refactor singleton states into reentrant pattern
by Edward O'Callaghan (Code Review) 11 Jun '21

11 Jun '21

Attention is currently required from: Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52958 ) Change subject: buspirate_spi.c: Refactor singleton states into reentrant pattern ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File buspirate_spi.c: https://review.coreboot.org/c/flashrom/+/52958/comment/af0b0ab4_862f1979 PS4, Line 315: int buspirate_spi_init(void) > I agree it is large. Also I agree this is out of scope for this commit. […] It's ok. I mean if you get time please follow up splitting the function up please as I think it will unroll out all the clean up path complexity. -- To view, visit https://review.coreboot.org/c/flashrom/+/52958 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I418bbfff15fb126b042fbc9be09dbf59f4d243b8 Gerrit-Change-Number: 52958 Gerrit-PatchSet: 5 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 11 Jun 2021 14:33:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: bitbang_spi.c: fix bitbang_spi_send_command to make the delay symmetric
by Angel Pons (Code Review) 11 Jun '21

11 Jun '21

Attention is currently required from: Xiang W. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49262 ) Change subject: bitbang_spi.c: fix bitbang_spi_send_command to make the delay symmetric ...................................................................... Patch Set 25: Code-Review-1 (1 comment) Patchset: PS25: > Edward, have you seen Nico's comments on CB:49255 yet? Also CB:49264 -- To view, visit https://review.coreboot.org/c/flashrom/+/49262 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icf8b65aed20244ccffc231da2c599c6ca1796104 Gerrit-Change-Number: 49262 Gerrit-PatchSet: 25 Gerrit-Owner: Xiang W <wxjstz(a)126.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-Attention: Xiang W <wxjstz(a)126.com> Gerrit-Comment-Date: Fri, 11 Jun 2021 14:32:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: bitbang_spi.c: fix bitbang_spi_send_command to make the delay symmetric
by Angel Pons (Code Review) 11 Jun '21

11 Jun '21

Attention is currently required from: Xiang W. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49262 ) Change subject: bitbang_spi.c: fix bitbang_spi_send_command to make the delay symmetric ...................................................................... Patch Set 25: (1 comment) Patchset: PS25: Edward, have you seen Nico's comments on CB:49255 yet? -- To view, visit https://review.coreboot.org/c/flashrom/+/49262 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Icf8b65aed20244ccffc231da2c599c6ca1796104 Gerrit-Change-Number: 49262 Gerrit-PatchSet: 25 Gerrit-Owner: Xiang W <wxjstz(a)126.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-Attention: Xiang W <wxjstz(a)126.com> Gerrit-Comment-Date: Fri, 11 Jun 2021 14:31:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: bitbang_spi.c: fix spi sequence in time and rename
by Nico Huber (Code Review) 11 Jun '21

11 Jun '21

Attention is currently required from: Xiang W, Stefan Reinauer, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49264 ) Change subject: bitbang_spi.c: fix spi sequence in time and rename ...................................................................... Patch Set 16: Code-Review-1 (1 comment) Patchset: PS16: SCK and MOSI should be changed at once and some bitbang programmers do so. We must not rely on the order. This change is only necessary to cover up the bugs introduced in the previous commit. -- To view, visit https://review.coreboot.org/c/flashrom/+/49264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I107803afef044996c94ebfaf0b0e0040cea9f8c1 Gerrit-Change-Number: 49264 Gerrit-PatchSet: 16 Gerrit-Owner: Xiang W <wxjstz(a)126.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-Attention: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Jun 2021 14:31:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: lspcon: restart MPU on programmer shutdown
by Edward O'Callaghan (Code Review) 11 Jun '21

11 Jun '21

Attention is currently required from: Sam McNally, Peter Marheine. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55403 ) Change subject: lspcon: restart MPU on programmer shutdown ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File lspcon_i2c_spi.c: https://review.coreboot.org/c/flashrom/+/55403/comment/116eabee_61f5b07b PS1, Line 321: static int lspcon_i2c_spi_reset_mpu_stop(int fd) : { : int ret = 0; : ret |= lspcon_i2c_spi_write_register(fd, MPU, 0xc0); // cmd mode : ret |= lspcon_i2c_spi_write_register(fd, MPU, 0x40); // stop mcu : : return ret; : } : : static int lspcon_i2c_spi_start_mpu(int fd) : { : int ret; : // Assert reset : if ((ret = lspcon_i2c_spi_write_register(fd, MPU, 0xc0)) != 0) : return ret; : // Release reset and start MPU : return lspcon_i2c_spi_write_register(fd, MPU, 0); : } : Hey Peter, could just perhaps just combine these two functions as `lspcon_i2c_spi_mcu_state_toggle` ? -- To view, visit https://review.coreboot.org/c/flashrom/+/55403 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I66cd68f8f6905a2bfaf5b085bf08dcb218f42855 Gerrit-Change-Number: 55403 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Fri, 11 Jun 2021 14:30:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: bitbang_spi.c: fix spi sequence in time and rename
by Edward O'Callaghan (Code Review) 11 Jun '21

11 Jun '21

Attention is currently required from: Xiang W, Stefan Reinauer, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49264 ) Change subject: bitbang_spi.c: fix spi sequence in time and rename ...................................................................... Patch Set 16: Code-Review+2 (1 comment) Patchset: PS13: > This is a timing issue, and the signal changes sent should be earlier than received. […] Can you add a TEST=`..` line in the commit message please? -- To view, visit https://review.coreboot.org/c/flashrom/+/49264 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I107803afef044996c94ebfaf0b0e0040cea9f8c1 Gerrit-Change-Number: 49264 Gerrit-PatchSet: 16 Gerrit-Owner: Xiang W <wxjstz(a)126.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shawn C <citypw(a)hardenedlinux.org> Gerrit-Attention: Xiang W <wxjstz(a)126.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Jun 2021 14:24:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Xiang W <wxjstz(a)126.com> Comment-In-Reply-To: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit