- flashrom-gerrit - mail.coreboot.org

Change in flashrom[master]: Makefile: enable internal programmer for x86 and all linux platforms
by Nico Huber (Code Review) 20 Feb '22

20 Feb '22

Attention is currently required from: Thomas Heijligen, Peter Marheine. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61300 ) Change subject: Makefile: enable internal programmer for x86 and all linux platforms ...................................................................... Patch Set 6: Code-Review+1 (4 comments) File Makefile: https://review.coreboot.org/c/flashrom/+/61300/comment/f43d50a9_c029a9f0 PS3, Line 104: CONFIG_INTERNAL_MIPSLE \ > I haven't looked it up yet Done https://review.coreboot.org/c/flashrom/+/61300/comment/3ab695b0_a0767769 PS3, Line 332: # Disable the internal programmer on unsupported architectures (everything but x86 and mipsel) > > (mark_unsupported) works fine, it's just hard to understand what it does. […] Done, I think. File Makefile: https://review.coreboot.org/c/flashrom/+/61300/comment/e4273ade_6be73120 PS5, Line 594: CONFIG_INTERNAL_X86 := yes > The new patchset should fix all this. […] A bit more redundancy, but also more explicit, looks ok. File Makefile: https://review.coreboot.org/c/flashrom/+/61300/comment/5cd8f3a7_46d1ae8b PS6, Line 315: #ifneq ($(ARCH)-$(TARGET_OS), $(filter $(ARCH)-$(TARGET_OS), x86-$(TARGET_OS) $(ARCH)-Linux)) leftover? -- To view, visit https://review.coreboot.org/c/flashrom/+/61300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia607ea60c3d7d15fe231fa412595992dadc535ad Gerrit-Change-Number: 61300 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sat, 19 Feb 2022 16:07:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: enable internal programmer for x86 and all linux platforms
by Felix Singer (Code Review) 20 Feb '22

20 Feb '22

Attention is currently required from: Nico Huber, Thomas Heijligen. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61300 ) Change subject: Makefile: enable internal programmer for x86 and all linux platforms ...................................................................... Patch Set 6: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/61300/comment/5f832fd5_30025191 PS6, Line 9: independend nit: independen_t_ -- To view, visit https://review.coreboot.org/c/flashrom/+/61300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia607ea60c3d7d15fe231fa412595992dadc535ad Gerrit-Change-Number: 61300 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sat, 19 Feb 2022 15:44:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: enable internal programmer for x86 and all linux platforms
by Thomas Heijligen (Code Review) 20 Feb '22

20 Feb '22

Attention is currently required from: Felix Singer, Nico Huber. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61300 ) Change subject: Makefile: enable internal programmer for x86 and all linux platforms ...................................................................... Patch Set 5: (3 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/61300/comment/bde59052_b7a6d9ce PS3, Line 7: Makeile > Make_f_ile Done https://review.coreboot.org/c/flashrom/+/61300/comment/3925434b_6200cbf6 PS3, Line 10: for > Remove this Commit message has changed File Makefile: https://review.coreboot.org/c/flashrom/+/61300/comment/2979996c_561a95aa PS5, Line 594: CONFIG_INTERNAL_X86 := yes > Shouldn't it be the other way around, i.e. CONFIG_INTERNAL needs to be […] The new patchset should fix all this. If libpci is not found, the internal programmer can not be build. -- To view, visit https://review.coreboot.org/c/flashrom/+/61300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia607ea60c3d7d15fe231fa412595992dadc535ad Gerrit-Change-Number: 61300 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sat, 19 Feb 2022 15:29:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: enable internal programmer for x86 and all linux platforms
by Thomas Heijligen (Code Review) 20 Feb '22

20 Feb '22

Attention is currently required from: Thomas Heijligen. Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/61300 to look at the new patch set (#6). Change subject: Makefile: enable internal programmer for x86 and all linux platforms ...................................................................... Makefile: enable internal programmer for x86 and all linux platforms The internal programmer has platform independend code for x86 and linux based code for mipsel. Furthermore the internal programmer can call the linux mtd programmer when available. Enable the internal programmer on x86 or linux. Change-Id: Ia607ea60c3d7d15fe231fa412595992dadc535ad Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile 1 file changed, 21 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/61300/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/61300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia607ea60c3d7d15fe231fa412595992dadc535ad Gerrit-Change-Number: 61300 Gerrit-PatchSet: 6 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: libflashrom/fmap: Don't use off_t for flash offsets
by Angel Pons (Code Review) 19 Feb '22

19 Feb '22

Attention is currently required from: David Hendricks, Julius Werner, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61943 ) Change subject: libflashrom/fmap: Don't use off_t for flash offsets ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/61943 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I68a386973f79ea634f63dfcd7d95a63400e1fdee Gerrit-Change-Number: 61943 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 19 Feb 2022 14:26:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: libflashrom/fmap: Don't use off_t for flash offsets
by Nico Huber (Code Review) 19 Feb '22

19 Feb '22

Attention is currently required from: David Hendricks, Julius Werner, Angel Pons, Arthur Heymans. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61943 ) Change subject: libflashrom/fmap: Don't use off_t for flash offsets ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/61943 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I68a386973f79ea634f63dfcd7d95a63400e1fdee Gerrit-Change-Number: 61943 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 19 Feb 2022 13:38:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: enable internal programmer for x86 and all linux platforms
by Nico Huber (Code Review) 19 Feb '22

19 Feb '22

Attention is currently required from: Thomas Heijligen. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61300 ) Change subject: Makefile: enable internal programmer for x86 and all linux platforms ...................................................................... Patch Set 5: (1 comment) File Makefile: https://review.coreboot.org/c/flashrom/+/61300/comment/3e285ae6_34d6e1b0 PS5, Line 594: CONFIG_INTERNAL_X86 := yes Shouldn't it be the other way around, i.e. CONFIG_INTERNAL needs to be disabled on x86 if CONFIG_INTERNAL_X86 is disabled (because of missing dependencies)? What happens with the current version on x86/linux if libpci is missing for instance? -- To view, visit https://review.coreboot.org/c/flashrom/+/61300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia607ea60c3d7d15fe231fa412595992dadc535ad Gerrit-Change-Number: 61300 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Sat, 19 Feb 2022 13:03:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: Makefile: enable internal programmer for x86 and all linux platforms
by Thomas Heijligen (Code Review) 19 Feb '22

19 Feb '22

Attention is currently required from: Nico Huber. Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/61300 to look at the new patch set (#5). Change subject: Makefile: enable internal programmer for x86 and all linux platforms ...................................................................... Makefile: enable internal programmer for x86 and all linux platforms The internal programmer has platform independend code for x86 and linux based code for mipsel. Furthermore the internal programmer can call the linux mtd programmer when available. Enable the internal programmer on x86 or linux. Change-Id: Ia607ea60c3d7d15fe231fa412595992dadc535ad Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M Makefile 1 file changed, 15 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/61300/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/61300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia607ea60c3d7d15fe231fa412595992dadc535ad Gerrit-Change-Number: 61300 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: newpatchset

1 0

Change in flashrom[master]: Makeile: enable internal programmer for x86 and all linux platforms
by Thomas Heijligen (Code Review) 19 Feb '22

19 Feb '22

Attention is currently required from: Nico Huber. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61300 ) Change subject: Makeile: enable internal programmer for x86 and all linux platforms ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/flashrom/+/61300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia607ea60c3d7d15fe231fa412595992dadc535ad Gerrit-Change-Number: 61300 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sat, 19 Feb 2022 12:00:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in flashrom[master]: libflashrom/fmap: Don't use off_t for flash offsets
by Julius Werner (Code Review) 19 Feb '22

19 Feb '22

Attention is currently required from: Nico Huber, David Hendricks, Angel Pons, Arthur Heymans. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61943 ) Change subject: libflashrom/fmap: Don't use off_t for flash offsets ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/61943/comment/d723f092_b54ea11e PS2, Line 19: > BUG=b:219811851 […] Done Patchset: PS1: > I ran into this problem today from `elogtool list` breaking is a truly bizarre way with "Out of memo […] Yes, that's how I saw it too. However, it only happened to me when trying to build elogtool locally -- the one in our official images works fine. It's also build slightly differently (e.g. linking libflashrom statically instead of dynamically). I didn't have time to figure out why those build differences are there yet. -- To view, visit https://review.coreboot.org/c/flashrom/+/61943 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I68a386973f79ea634f63dfcd7d95a63400e1fdee Gerrit-Change-Number: 61943 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 18 Feb 2022 23:42:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit