February 2025 - flashrom-gerrit

[M] Change in flashrom[main]: libflashrom: Update the API for progress callback
by Anastasia Klimchuk (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Anastasia Klimchuk, Richard Hughes. Hello Peter Marheine, Richard Hughes, Sergii Dmytruk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86031?usp=email to look at the new patch set (#5). Change subject: libflashrom: Update the API for progress callback ...................................................................... libflashrom: Update the API for progress callback The initial version of API for progress callback would require the callback function to make a second call to get the needed data about progress state (current, total etc). This patch changes the callback API, so that callback function gets all needed data straight away as parameters, and with this, callback has all the data to do its job. Since the initial version was submitted and it was in the tree for a while, the change needs to add a _v1 suffix for new thing and deprecated attribute for old thing. Testing: both unit tests and cli are libflashrom clients. All unit tests run successfully, for the cli all scenarios from commit 75dc0655b95dde91f1426a7e5aecfc04d7b8d631 run successfully. Change-Id: Ia8cc0461c449b7e65888a64cdc594c55b81eae7a Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M cli_classic.c M cli_output.c M doc/release_notes/devel.rst M include/cli_output.h M include/flash.h M include/libflashrom.h M libflashrom.c M libflashrom.map M tests/chip.c M tests/spi25.c 10 files changed, 91 insertions(+), 68 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/86031/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/86031?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia8cc0461c449b7e65888a64cdc594c55b81eae7a Gerrit-Change-Number: 86031 Gerrit-PatchSet: 5 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for progress callback
by Anastasia Klimchuk (Code Review) 07 Feb '25

07 Feb '25

Attention is currently required from: Anastasia Klimchuk, Richard Hughes. Hello Peter Marheine, Richard Hughes, Sergii Dmytruk, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86031?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: libflashrom: Update the API for progress callback ...................................................................... libflashrom: Update the API for progress callback The initial version of API for progress callback would require the callback function to make a second call to get the needed data about progress state (current, total etc). This patch changes the callback API, so that callback function gets all needed data straight away as parameters, and with this, callback has all the data to do its job. Since the initial version was submitted and it was in the tree for a while, the change needs to add a _v1 suffix for new thing and deprecated attribute for old thing. Testing: both unit tests and cli are libflashrom clients. All unit tests run successfully, for the cli all scenarios from commit 75dc0655b95dde91f1426a7e5aecfc04d7b8d631 run successfully. Change-Id: Ia8cc0461c449b7e65888a64cdc594c55b81eae7a Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M cli_classic.c M cli_output.c M doc/release_notes/devel.rst M include/cli_output.h M include/flash.h M include/libflashrom.h M libflashrom.c M libflashrom.map M tests/chip.c M tests/spi25.c 10 files changed, 91 insertions(+), 68 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/86031/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/86031?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia8cc0461c449b7e65888a64cdc594c55b81eae7a Gerrit-Change-Number: 86031 Gerrit-PatchSet: 4 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: doc: Migrate old pages about laptops and EC
by Anastasia Klimchuk (Code Review) 05 Feb '25

05 Feb '25

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/86243?usp=email ) Change subject: doc: Migrate old pages about laptops and EC ...................................................................... doc: Migrate old pages about laptops and EC Old pages are: https://wiki.flashrom.org/Laptops https://wiki.flashrom.org/Laptop_enable Info from both is gathered into one doc. Change-Id: I26f5aef8d679d37fcaebfd830a04d09d818ffe0b Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/86243 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M doc/contrib_howtos/index.rst A doc/contrib_howtos/laptops_and_ec.rst 2 files changed, 171 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved diff --git a/doc/contrib_howtos/index.rst b/doc/contrib_howtos/index.rst index cb74e1c..3df2fac 100644 --- a/doc/contrib_howtos/index.rst +++ b/doc/contrib_howtos/index.rst @@ -7,5 +7,7 @@ how_to_add_new_chip how_to_mark_chip_tested how_to_add_unit_test + laptops_and_ec + ../how_to_add_docs ../how_to_support_flashrom diff --git a/doc/contrib_howtos/laptops_and_ec.rst b/doc/contrib_howtos/laptops_and_ec.rst new file mode 100644 index 0000000..30c2082 --- /dev/null +++ b/doc/contrib_howtos/laptops_and_ec.rst @@ -0,0 +1,169 @@ +====================== +Info on laptops and EC +====================== + +The page contains some info about flashing the EC on the laptops without official vendor support. + +For the info how to flash system firmware on modern laptops with vendor support, please check +"Flashing coreboot" document in user docs. + +**Note the document below was migrated from old website and the content >10yrs old** +(exept the links to mailing list and dev guide, those are up-to-date). + +Why laptops are difficult +========================= + +Laptops, notebooks and netbooks are difficult to support and we recommend to use the vendor flashing utility. +The embedded controller (EC) in these machines often interacts badly with flashing, +either by blocking all read/write access to the flash chip or by crashing +(it may power off the machine or mess with the battery or cause system instability). + +ECs are particularly difficult besides blocking access and crashing: + +* Almost all ECs do not have public datasheets with programming information. + +* Even if the programming information for an EC is public, + the errata (often needed to use the EC for flashing) are not. + +* Even if you have the datasheets with programming information (under NDA or by convincing the EC vendor to release them), + the following problems remain: + + * flashrom has to detect/probe the EC. For this, it writes a magic byte sequence to a magic port. + The bad news is that a laptop vendor can customize the magic sequence and the magic port and the response to that, + so even if you try all magic sequences mentioned in the datasheet on all magic ports mentioned in the datasheet, + it will either not react (because the laptop vendor came up with its own secret magic sequence/port or + because the laptop vendor decided to disable all detection support) or it will respond with a non-default ID + which is not present in any table. If you are really extremely lucky, + the EC will react to the probing sequence mentioned in the datasheet and respond with the ID mentioned in the datasheet. + + * Most ECs support 3-5 different interfaces to the flash chip. Depending on the software running on the EC, + none, some or all of them can be disabled. So if you want to support a given embedded controller with reasonable reliability, + you have to write code for all flash interfaces (usually vastly different from each other). + + * During a flash erase/read/write, flashrom competes with the EC for flash access. The EC usually executes + its software directly from flash (no RAM involved) and starving the EC instruction decoder may crash the EC. + If you erase the part of the flash chip where the EC fetches its instructions from, the EC will execute garbage + and crash/misbehave. When (not if, it always happens) the flash chip is in ID mode during flash probing, + the EC will mistake the ID data for instructions and execute them, resulting in a crash. + + * You have to find a way to let the EC software run for some time without requiring flash access. + This can be achieved by writing a loop (not really a loop, but this is just to illustrate the point) + to EC-internal tiny RAM and then jumping there. Only during that time + you can access the flash chip reliably without side effects. + + * After flashing, you have to reset the EC so that it can resume running normally. + This is not optional because the EC controls battery charging (among others) and you want that to work. + +Adding support for laptops +========================== + +That said, adding support for an EC is doable. Here is a cheat sheet on what to do. + +* Find out which flash chip you have by physical inspection of the board + (or by looking at the internal docs of the manufacturer or the repair manual). + +* Find out the controller where the flash chip is attached to. Can be the EC (likely), + SuperI/O (somewhat likely), Southbridge (pretty unlikely, if it were, you wouldn't be reading this). + This is a job done by physical inspection of the board (or by looking at the internal docs + of the manufacturer which sometimes only the ODM and not even the laptop vendor has). + +* You can post on the flashrom mailing list (see :ref:`mailing list`) that you plan to work on your EC, + mention the exact EC model (and laptop model). You can ask if someone has public docs for the EC, + knows how to get them under NDA or has vendor contacts at the EC vendor. + With some luck, you might even get docs (some vendors are more friendly than others). + +* Get hold of a BIOS image for your laptop (flashrom dump in force mode won't work reliably here). + Locate the EC code in the BIOS image. The EC often is 8051 compatible or has an architecture with similar limitations. + The EC code will be uncompressed in flash. Download BIOS images for other laptops with the same EC + and try to compare the EC code. It may be 100% vanilla code directly from the EC manufacturer + (which makes your task rather easy) or a heavily customized variant of the original code + (bad, because you have to analyze it). + +* Cross-check the EC code with the EC docs to find out which interfaces for detecting the EC + and which interfaces for flashing are enabled and working. + +* The above two steps can be skipped if you get that information from the laptop vendor. + +* Make sure your flash chip is removable in case something goes wrong. If it is not removable, + look for an in-system-programming header on the board and check if it is supported by flashrom + (or your hardware programmer of choice). If there is no header and the chip is soldered, + desolder it and solder a socket in place. + +* Dump the old firmware via the programming header or via reading the chip in an external programmer + and store it safely (backup on a readonly medium like CD-ROM). It contains your laptop serial number, + your MAC address, and sometimes your Windows preactivation keys. + +* (optional) Disconnect the battery. You don't know how the EC behaves if it crashes + and batteries are expensive and prone to unwanted reactions. + +* Start implementing and testing EC detection code. We recommend to do this either + as external programmer driver init code (and have the code return 1 to make sure flashrom aborts after init) + or in a standalone program (this helps you keep an overview). + +* Start implementing flasher support for your EC. The best way to do this is an external programmer driver. + +* Note that you can push your patch for review even if it is still in Work In Progress state, if you want to + get early feedback and/or share your effort with the people on the mailing list. See :doc:`/dev_guide/development_guide`. + +Laptop enable +============= + +Most (all?) laptop designs use an EC (embedded controller) to control the backlight, +watch the battery status, etcetera. + +To access the flash chip (safely), the EC needs to be suspended/stopped. +The code to stop the EC typically is found at the end of a BIOS binary. +This page is about that trailing part of a binary. + +PhoenixBIOS specifics +--------------------- + +This subsection is about the disassembly of a laptop BIOS file (Compal HTW20, ENE KB910QF, SMC LPC47B227?, Phoenix TrustedCore) +that is 1052598 bytes large, the trailer starts at 0x100000 (1024 * 1024) and is 4022 bytes in size. + +To extract the trailer, use dd:: + + dd if=<romfile> of=bios.bin bs=1024k skip=1 + +Example of a disassembly +^^^^^^^^^^^^^^^^^^^^^^^^ + +The disassembler that is used is IDAPro, the freeware version. + +Example of how the disassembly of the trailer looks:: + + TRAILER:0010 09 00 00 00 00 00 00 00 00 00 00 43 6F 6D 70 61 ..........Compa + TRAILER:0020 6C 20 57 69 6E 50 68 6C 61 73 68 20 2D 20 46 6C l WinPhlash - Fl + TRAILER:0030 61 73 68 69 6E 74 2E 61 73 6D 20 76 30 2E 30 33 ashint.asm v0.03 + TRAILER:0040 5A 46 4C 50 46 25 00 00 00 00 00 00 00 59 02 00 ZFLPF% + +Hints and facts +^^^^^^^^^^^^^^^ + +Facts: + +* ZFLPF is found at 0x40 +* len(ZFLPH) = 5 + +The location of the entrypoint is stored at 0x51: + +(base of ZFLPF) + len(ZFLPF) + 0xc = 0x40 + 5 + 0xc = 0x51 + + +Let's take a look at position 0x51:: + + TRAILER:0051 DE 02 dw 2DEh + +Fact: + +* 0x2de + 0x1b = 0x2f9 + +Preview of the begin of the board specific code +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +:: + + TRAILER:02F9 ; --------------------------------------------------------------------------- + TRAILER:02F9 9C pushf + TRAILER:02FA 60 pusha + TRAILER:02FB E8 C2 00 call determine_lpc_pci_id -- To view, visit https://review.coreboot.org/c/flashrom/+/86243?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I26f5aef8d679d37fcaebfd830a04d09d818ffe0b Gerrit-Change-Number: 86243 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in flashrom[main]: doc: Migrate privacy policy page from old website into new one
by Anastasia Klimchuk (Code Review) 04 Feb '25

04 Feb '25

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/86242?usp=email ) Change subject: doc: Migrate privacy policy page from old website into new one ...................................................................... doc: Migrate privacy policy page from old website into new one Change-Id: I54ace480b3bebe3031ea6d1e507c540ac1dc7cc6 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/86242 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Tested-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- M doc/about_flashrom/index.rst A doc/about_flashrom/privacy_policy.rst 2 files changed, 52 insertions(+), 0 deletions(-) Approvals: Stefan Reinauer: Verified; Looks good to me, approved build bot (Jenkins): Verified diff --git a/doc/about_flashrom/index.rst b/doc/about_flashrom/index.rst index 49c9849..143c7b6 100644 --- a/doc/about_flashrom/index.rst +++ b/doc/about_flashrom/index.rst @@ -6,3 +6,4 @@ team code_of_conduct + privacy_policy diff --git a/doc/about_flashrom/privacy_policy.rst b/doc/about_flashrom/privacy_policy.rst new file mode 100644 index 0000000..f675eec --- /dev/null +++ b/doc/about_flashrom/privacy_policy.rst @@ -0,0 +1,51 @@ +============== +Privacy policy +============== + +Email address: stefan.reinauer(a)coreboot.org + +Disclaimer +========== + +Liability for content +--------------------- + +We try to be careful when creating our pages, however we can not take any responsibility for the accuracy, +completeness, or timeliness of any of our content. Obligations to remove or block the use of information +under the law remains unaffected. Upon formal notification of any such violations, we will remove the content. + +Liability for links +------------------- + +Our site contains links to external websites, over which we have no control. +We therefore cannot accept any responsibility for the remote content. +It is always the responsibility of the respective provider or operator for the contents of any linked site. +The linked sites were checked at the time of linking for possible legal violations +and no illegal contents were noticed at that time. Removal of the linked pages is unreasonable +without concrete evidence of a legal violation. Upon formal notification of legal violations, +we will remove such links. + +Copyright & license +------------------- + +With the exception of use for sending unsolicited advertisements, we encourage copying, editing, +and distribution of the flashrom project source and of the contents of the website for educational, +personal, and commercial use. Copyrights are maintained by the individual authors, +and the copyright notices must be included anywhere they are present. + +In instances where the content on this page were not the created by the flashrom project, +the rights of third party creators are maintained. Please see the credits page for a list of these items. +Should you be aware of any copyright infringement, we request that the copyright owner send a notice. +Upon appropriate notification of violations, we will remove the infringing content. + +Data protection +--------------- + +The use of our website is usually possible without providing personal information. +As much as possible, any personal data such as your name, address or email address which is collected, +is done on a voluntary basis. This data is not saved without your express request. + +The flashrom project takes reasonable security measures to protect your private data, however data transmission over the internet (for example, when communicating via e-mail) can have security holes. Complete protection of data against unauthorized access by third parties is impossible. + +The use of data published on this website (anything on the flashrom.org domain) by third parties +for sending unsolicited advertisements and information materials is hereby expressly prohibited. -- To view, visit https://review.coreboot.org/c/flashrom/+/86242?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I54ace480b3bebe3031ea6d1e507c540ac1dc7cc6 Gerrit-Change-Number: 86242 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in flashrom[main]: flashchips/winbond.c: Add reg_bits for W25Q256JW
by Anastasia Klimchuk (Code Review) 03 Feb '25

03 Feb '25

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/85323?usp=email ) Change subject: flashchips/winbond.c: Add reg_bits for W25Q256JW ...................................................................... flashchips/winbond.c: Add reg_bits for W25Q256JW Add reg_bits for W25Q256JW as per the datasheet. The register definitions are same as W25Q256JW_DTR. Datasheet: https://www.winbond.com/hq/support/documentation/levelOne.jsp?__locale=en&D… BUG=b:376929528 TEST=Program and verify WP ranges ``` flashrom -p internal --wp-status flashrom -p internal --wp-range 0x0,0x2000000 flashrom -p internal --wp-enable flashrom -p internal --wp-status ``` Change-Id: I050754b28a90911a50f891869297524ce9a6720e Signed-off-by: Kapil Porwal <kapilporwal(a)google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/85323 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-by: Subrata Banik <subratabanik(a)google.com> --- M flashchips/winbond.c 1 file changed, 13 insertions(+), 2 deletions(-) Approvals: Subrata Banik: Looks good to me, but someone else must approve Anastasia Klimchuk: Looks good to me, approved build bot (Jenkins): Verified diff --git a/flashchips/winbond.c b/flashchips/winbond.c index 973bf2c..9709e78 100644 --- a/flashchips/winbond.c +++ b/flashchips/winbond.c @@ -655,8 +655,9 @@ .page_size = 256, /* supports SFDP */ /* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ - .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA, - .tested = TEST_OK_PREW, + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA | FEATURE_WRSR2 + | FEATURE_WRSR3, + .tested = TEST_OK_PREWB, .probe = PROBE_SPI_RDID, .probe_timing = TIMING_ZERO, .block_erasers = @@ -689,6 +690,16 @@ .write = SPI_CHIP_WRITE256, .read = SPI_CHIP_READ, .voltage = {1650, 1950}, + .reg_bits = + { + .srp = {STATUS1, 7, RW}, + .srl = {STATUS2, 0, RW}, + .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}, {STATUS1, 5, RW}}, + .tb = {STATUS1, 6, RW}, + .cmp = {STATUS2, 6, RW}, + .wps = {STATUS3, 2, RW}, + }, + .decode_range = DECODE_RANGE_SPI25, }, { -- To view, visit https://review.coreboot.org/c/flashrom/+/85323?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I050754b28a90911a50f891869297524ce9a6720e Gerrit-Change-Number: 85323 Gerrit-PatchSet: 4 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-Reviewer: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for progress callback
by Peter Marheine (Code Review) 02 Feb '25

02 Feb '25

Attention is currently required from: Anastasia Klimchuk, Richard Hughes. Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86031?usp=email ) Change subject: libflashrom: Update the API for progress callback ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: I think this warrants an entry in the release notes too, since it's a user-visible change. File libflashrom.c: https://review.coreboot.org/c/flashrom/+/86031/comment/0a806d8d_857fd0d1?us… : PS3, Line 71: msg_gerr("%s deprecated, use flashrom_set_progress_callback_v2 instead\n", __func__); This message will probably be shown to users more often than developers (who should see the warning at build-time), so I think it should try to be a little more helpful. Perhaps: `"__func__: this function is deprecated and no progress will be reported (for developers: call __func___v2 instead)"` I also think this shouldn't be logged at error level, because that seems likely to confuse people. Flashrom still works in this case, so it should be a warning. -- To view, visit https://review.coreboot.org/c/flashrom/+/86031?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia8cc0461c449b7e65888a64cdc594c55b81eae7a Gerrit-Change-Number: 86031 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 03 Feb 2025 00:12:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: doc: Migrate old pages about laptops and EC
by Stefan Reinauer (Code Review) 02 Feb '25

02 Feb '25

Attention is currently required from: Anastasia Klimchuk, Matt DeVillier. Stefan Reinauer has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86243?usp=email ) Change subject: doc: Migrate old pages about laptops and EC ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/86243?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I26f5aef8d679d37fcaebfd830a04d09d818ffe0b Gerrit-Change-Number: 86243 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sun, 02 Feb 2025 08:12:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in flashrom[main]: doc: Migrate old pages about laptops and EC
by Anastasia Klimchuk (Code Review) 02 Feb '25

02 Feb '25

Attention is currently required from: Matt DeVillier, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86243?usp=email ) Change subject: doc: Migrate old pages about laptops and EC ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I found the room for improvement and swapped two sentences in intro, so that new document is mentioned first, and then we say everything below is >10yr old. -- To view, visit https://review.coreboot.org/c/flashrom/+/86243?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I26f5aef8d679d37fcaebfd830a04d09d818ffe0b Gerrit-Change-Number: 86243 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Sun, 02 Feb 2025 08:01:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: doc: Migrate old pages about laptops and EC
by Anastasia Klimchuk (Code Review) 02 Feb '25

02 Feb '25

Attention is currently required from: Anastasia Klimchuk, Matt DeVillier, Stefan Reinauer. Hello Matt DeVillier, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/86243?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Matt DeVillier, Verified+1 by build bot (Jenkins) Change subject: doc: Migrate old pages about laptops and EC ...................................................................... doc: Migrate old pages about laptops and EC Old pages are: https://wiki.flashrom.org/Laptops https://wiki.flashrom.org/Laptop_enable Info from both is gathered into one doc. Change-Id: I26f5aef8d679d37fcaebfd830a04d09d818ffe0b Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M doc/contrib_howtos/index.rst A doc/contrib_howtos/laptops_and_ec.rst 2 files changed, 171 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/86243/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/86243?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I26f5aef8d679d37fcaebfd830a04d09d818ffe0b Gerrit-Change-Number: 86243 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: libflashrom: Update the API for progress callback
by Sergii Dmytruk (Code Review) 01 Feb '25

01 Feb '25

Attention is currently required from: Anastasia Klimchuk, Peter Marheine, Richard Hughes. Sergii Dmytruk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86031?usp=email ) Change subject: libflashrom: Update the API for progress callback ...................................................................... Patch Set 3: (1 comment) File include/libflashrom.h: https://review.coreboot.org/c/flashrom/+/86031/comment/df710d3f_8e12c9ac?us… : PS2, Line 90: * @deprecated Use flashrom_set_progress_callback_v1 instead > There is an important detail here, I will try to explain the full context. […] The old version was usable but required global state. Client code was responsible for managing progress state and passed it into libflashrom, which then didn't return the pointer in the callback, but the client knew its value and could display progress. -- To view, visit https://review.coreboot.org/c/flashrom/+/86031?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia8cc0461c449b7e65888a64cdc594c55b81eae7a Gerrit-Change-Number: 86031 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Richard Hughes <richard(a)hughsie.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Richard Hughes <richard(a)hughsie.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sat, 01 Feb 2025 14:56:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit February 2025