May 2024 - flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[main]: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME
by Anastasia Klimchuk (Code Review) 12 May '24

12 May '24

Attention is currently required from: Angel Pons, Martin L Roth, Martin Roth, Peter Marheine, Raj Astekar, Ravishankar Sarawadi, Wonkyu Kim. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58025?usp=email ) Change subject: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME ...................................................................... Patch Set 8: (10 comments) Patchset: PS8: > I read through the comments thread to recall what the patch have been waiting for. […] Many thanks to Victor on the mailing list for giving datasheets, I did a review and added some comments. File flashchips.c: https://review.coreboot.org/c/flashrom/+/58025/comment/76651360_3fec0d74 : PS8, Line 6552: .name = "GD25LR256E", This is out of order, both entries need to be moved after GD25LQ80 and just before GD25Q10 https://review.coreboot.org/c/flashrom/+/58025/comment/0deca606_33434b56 : PS8, Line 6590: SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD Datasheet has BP4, so this should be `SPI_PRETTYPRINT_STATUS_REGISTER_BP4_SRWD` https://review.coreboot.org/c/flashrom/+/58025/comment/343681e1_32b6595a : PS8, Line 6591: SPI_DISABLE_BLOCKPROTECT SPI_DISABLE_BLOCKPROTECT_BP4_SRWD https://review.coreboot.org/c/flashrom/+/58025/comment/e256659a_175ff710 : PS8, Line 6594: {1600, 2000} Slight correction : from datasheet it's 1.65~2.0V https://review.coreboot.org/c/flashrom/+/58025/comment/69474edd_5fc8758d : PS8, Line 6599: .tb = {STATUS1, 6, RW}, In such cases you should add a comment: `Called BP4 in datasheet, acts like TB` https://review.coreboot.org/c/flashrom/+/58025/comment/4ea82095_fcd0841a : PS8, Line 6646: SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD SPI_PRETTYPRINT_STATUS_REGISTER_BP4_SRWD https://review.coreboot.org/c/flashrom/+/58025/comment/f67121aa_1a0a7e2d : PS8, Line 6647: SPI_DISABLE_BLOCKPROTECT SPI_DISABLE_BLOCKPROTECT_BP4_SRWD https://review.coreboot.org/c/flashrom/+/58025/comment/b194c85c_4bf5c3fd : PS8, Line 6650: {1600, 2000}, 1.65~2.0V https://review.coreboot.org/c/flashrom/+/58025/comment/410965dc_2c5da58a : PS8, Line 6655: .tb = {STATUS1, 6, RW}, Also as above, needs a comment: `Called BP4 in datasheet, acts like TB` -- To view, visit https://review.coreboot.org/c/flashrom/+/58025?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I2fe6bc1219cd1ee19b93caabab69de938cfc44b0 Gerrit-Change-Number: 58025 Gerrit-PatchSet: 8 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sun, 12 May 2024 08:02:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: doc: Add doc for supported flash chips
by Alexander Goncharov (Code Review) 11 May '24

11 May '24

Attention is currently required from: Anastasia Klimchuk, Peter Marheine, Thomas Heijligen, Victor Lim. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82197?usp=email ) Change subject: doc: Add doc for supported flash chips ...................................................................... Patch Set 2: (4 comments) Patchset: PS1: > The old page is here: https://wiki.flashrom.org/Supported_hardware#Supported_flash_chips […] Yeah, great idea! As far as I can see last time it was updated in 2013! More than 10 years ago... But having a table of supported hardware is really handy. I think it makes sense to spend time on finding any built-in methods in sphinx that can help us maintain a table in this document instead of the wiki. File doc/supported_hw/supported_flashchips.rst: https://review.coreboot.org/c/flashrom/+/82197/comment/24a35ed4_872eb23b : PS2, Line 12: Alternatively inspect the file on the `web UI of our GitHub mirror <https://github.com/flashrom/flashrom/blob/main/flashchips.c>`_. I would suggest moving this paragraph to the first one, because they're logically related https://review.coreboot.org/c/flashrom/+/82197/comment/20b1798b_115ac143 : PS2, Line 14: If you want to check whether a flash chip is supported in the given release, you can rebase your local : repo at the release tag, alternatively select a tag/branch in GitHub web UI (dropdown on the top-left). It doesn't sound like a really user-friendly method to check whether a desired flash chip is supported :( Can we maintain a list of supported chips for a specific release as a text file? Looks like we have to add it to the upcoming agenda :D https://review.coreboot.org/c/flashrom/+/82197/comment/72490d88_8e7bc1d2 : PS2, Line 23: Instructions how to update tested status of the chip are here: :doc:`/contrib_howtos/how_to_mark_chip_tested`. : : Instructions how to add support for a chip are here: :doc:`/contrib_howtos/how_to_add_new_chip`. How about just adding them as a "related topics" list? -- To view, visit https://review.coreboot.org/c/flashrom/+/82197?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I05fb60a4caf2cfb30586fa482687b10638996395 Gerrit-Change-Number: 82197 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Victor Lim <vlim(a)gigadevice.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sat, 11 May 2024 15:34:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[main]: erasure_layout: don't copy region buffers if they're null/zero-size
by Alexander Goncharov (Code Review) 11 May '24

11 May '24

Attention is currently required from: Aarya, Anastasia Klimchuk, Nikolai Artemiev. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81548?usp=email ) Change subject: erasure_layout: don't copy region buffers if they're null/zero-size ...................................................................... Patch Set 2: (1 comment) File erasure_layout.c: https://review.coreboot.org/c/flashrom/+/81548/comment/0c1561f9_cb1bdc70 : PS1, Line 263: old_start_buf = (uint8_t *)malloc(old_start - region_start); : if (!old_start_buf) { : msg_cerr("Not enough memory!\n"); : ret = -1; : goto _end; : } : old_end_buf = (uint8_t *)malloc(region_end - old_end); : if (!old_end_buf) { : msg_cerr("Not enough memory!\n"); : ret = -1; : goto _end; : } > Thanks for the details, Anastasia! Yeah, I will dive deeper to see possible solutions and understand […] Sorry it took longer than I expected. Please, Anastasia, check out the new patch set -- To view, visit https://review.coreboot.org/c/flashrom/+/81548?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I99aad4119f9c11bea75e3419926cc833bc1f68c5 Gerrit-Change-Number: 81548 Gerrit-PatchSet: 2 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Sat, 11 May 2024 15:05:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: flashchips: Add (or update) chip models <list models>
by Victor Lim (Code Review) 11 May '24

11 May '24

Victor Lim has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/82332?usp=email ) Change subject: flashchips: Add (or update) chip models <list models> ...................................................................... flashchips: Add (or update) chip models <list models> Adding GD25LF128E to flashchip.c GD25LF128E: 1.8V 128Mbit, QE default fixed at 1. Datasheet link https://www.gigadevice.com.cn/Public/Uploads/uploadfile/files/20230627/DS-0… Change-Id: I71fdc7ea1aea69d14db6af3bac2da3e7bee8abbe Signed-off-by: Victor Lim <vlim(a)gigadevice.com> --- M flashchips.c 1 file changed, 49 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/32/82332/1 diff --git a/flashchips.c b/flashchips.c index 041ac40..07f6c0f 100644 --- a/flashchips.c +++ b/flashchips.c @@ -6500,6 +6500,55 @@ { .vendor = "GigaDevice", + .name = "GD25LF128E", + .bustype = BUS_SPI, + .manufacture_id = GIGADEVICE_ID, + .model_id = GIGADEVICE_GD25LF128E, + .total_size = 16384, + .page_size = 256, + /* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_WRSR_EXT2, + .tested = TEST_OK_PREWB, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 4096} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {32 * 1024, 512} }, + .block_erase = SPI_BLOCK_ERASE_52, + }, { + .eraseblocks = { {64 * 1024, 256} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {16 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP4_SRWD, + .unlock = SPI_DISABLE_BLOCKPROTECT_BP4_SRWD, /* TODO: 2nd status reg (read with 0x35) */ + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, /* Fast read (0x0B) and multi I/O supported */ + .voltage = {1695, 1950}, + .reg_bits = + { + .srp = {STATUS1, 7, RW}, + .srl = {STATUS2, 0, RW}, + .bp = {{STATUS1, 2, RW}, {STATUS1, 3, RW}, {STATUS1, 4, RW}}, + .tb = {STATUS1, 5, RW}, /* Called BP3 in datasheet, acts like TB */ + .sec = {STATUS1, 6, RW}, /* Called BP4 in datasheet, acts like SEC */ + .cmp = {STATUS2, 6, RW}, + }, + .decode_range = DECODE_RANGE_SPI25, + }, + + { + .vendor = "GigaDevice", .name = "GD25LQ128C/GD25LQ128D/GD25LQ128E", .bustype = BUS_SPI, .manufacture_id = GIGADEVICE_ID, -- To view, visit https://review.coreboot.org/c/flashrom/+/82332?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I71fdc7ea1aea69d14db6af3bac2da3e7bee8abbe Gerrit-Change-Number: 82332 Gerrit-PatchSet: 1 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[main]: erasure_layout: don't copy region buffers if they're null/zero-size
by Alexander Goncharov (Code Review) 11 May '24

11 May '24

Attention is currently required from: Aarya, Anastasia Klimchuk, Nikolai Artemiev. Hello Aarya, Anastasia Klimchuk, Nikolai Artemiev, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/81548?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: erasure_layout: don't copy region buffers if they're null/zero-size ...................................................................... erasure_layout: don't copy region buffers if they're null/zero-size memcpy() function expects 2nd parameter to be non-null. Make sure that the pointer is null before passing it to the function. Also move allocations under if conditions to avoid allocating memory for a potentially 0 size. Found-by: scan-build, clang v17.0.6 Signed-off-by: Alexander Goncharov <chat(a)joursoir.net> Change-Id: I99aad4119f9c11bea75e3419926cc833bc1f68c5 --- M erasure_layout.c 1 file changed, 30 insertions(+), 24 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/48/81548/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/81548?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I99aad4119f9c11bea75e3419926cc833bc1f68c5 Gerrit-Change-Number: 81548 Gerrit-PatchSet: 2 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)chromium.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[main]: flashchips: Add support for Boya B25Q64AS
by Anastasia Klimchuk (Code Review) 11 May '24

11 May '24

Attention is currently required from: Malcolm Boyes, Nikolai Artemiev, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/82259?usp=email ) Change subject: flashchips: Add support for Boya B25Q64AS ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: Malcolm thank you for the patch! I have just one comment. File flashchips.c: https://review.coreboot.org/c/flashrom/+/82259/comment/a1d1cbe6_f96086f7 : PS1, Line 3640: SPI_DISABLE_BLOCKPROTECT_AT25FS040 I think SPI_DISABLE_BLOCKPROTECT_BP4_SRWD is more correct in this case which is > A common block protection disable that tries to unset the status register bits masked by 0x7C (BP0-4) and protected/locked by bit #7. (Even if it might internally comes down to the same thing) As I understand you were not testing write protection anyway, right? -- To view, visit https://review.coreboot.org/c/flashrom/+/82259?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I05ecf2b118902db974544d86e023a348912371dd Gerrit-Change-Number: 82259 Gerrit-PatchSet: 1 Gerrit-Owner: Malcolm Boyes <boyesmalcolm(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Malcolm Boyes <boyesmalcolm(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Sat, 11 May 2024 11:02:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[main]: tests: Remove mock struct pci_dev, use real pci symbols in tests
by Anastasia Klimchuk (Code Review) 11 May '24

11 May '24

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/62948?usp=email ) Change subject: tests: Remove mock struct pci_dev, use real pci symbols in tests ...................................................................... Abandoned not working on this anymore -- To view, visit https://review.coreboot.org/c/flashrom/+/62948?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I1206fbdca392f190066a364376ce0db28071e53c Gerrit-Change-Number: 62948 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[main]: tests: Add test for extract operation
by Anastasia Klimchuk (Code Review) 11 May '24

11 May '24

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/59532?usp=email ) Change subject: tests: Add test for extract operation ...................................................................... Abandoned not working on this anymore -- To view, visit https://review.coreboot.org/c/flashrom/+/59532?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I13107c0e095d53184e32a41fa72227cf7dc1d449 Gerrit-Change-Number: 59532 Gerrit-PatchSet: 5 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Daniel Campello <campello(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Marheine <pmarheine(a)chromium.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[main]: layout: Hoist prepare_layout_for_extraction into libflashrom API
by Anastasia Klimchuk (Code Review) 11 May '24

11 May '24

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/62555?usp=email ) Change subject: layout: Hoist prepare_layout_for_extraction into libflashrom API ...................................................................... Abandoned not working on this anymore -- To view, visit https://review.coreboot.org/c/flashrom/+/62555?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I3f5b4079528ddd4d1ca9acfa6d107e8c3d6814ff Gerrit-Change-Number: 62555 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[main]: layout: Change signature for prepare_layout_for_extraction
by Anastasia Klimchuk (Code Review) 11 May '24

11 May '24

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/62554?usp=email ) Change subject: layout: Change signature for prepare_layout_for_extraction ...................................................................... Abandoned not working on this anymore -- To view, visit https://review.coreboot.org/c/flashrom/+/62554?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I7d3874d1097bb0d7bb8d9fa8e639cc1e71407627 Gerrit-Change-Number: 62554 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit May 2024