December 2024 - flashrom-gerrit

Change in flashrom[master]: libflashrom.map: Add missing symbols
by Edward O'Callaghan (Code Review) 07 Apr '25

07 Apr '25

Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/38993 ) Change subject: libflashrom.map: Add missing symbols ...................................................................... libflashrom.map: Add missing symbols The following symbols were missing at link-time from libflashrom: supported_flash_chips; supported_boards; supported_chipsets; Change-Id: I299928d62788c0abfe7f6cdd3e8ad8be0c49e45e Signed-off-by: Edward O'Callaghan <quasisec(a)google.com> --- M libflashrom.map 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/93/38993/1 diff --git a/libflashrom.map b/libflashrom.map index d6dd24d..9430775 100644 --- a/libflashrom.map +++ b/libflashrom.map @@ -25,6 +25,9 @@ flashrom_set_log_callback; flashrom_shutdown; flashrom_supported_programmers; + flashrom_supported_flash_chips; + flashrom_supported_boards; + flashrom_supported_chipsets; flashrom_system_info; flashrom_version_info; local: *; -- To view, visit https://review.coreboot.org/c/flashrom/+/38993 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I299928d62788c0abfe7f6cdd3e8ad8be0c49e45e Gerrit-Change-Number: 38993 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newchange

4 3

[M] Change in flashrom[main]: flashchips: Add Spansion S25FS512S
by Anastasia Klimchuk (Code Review) 25 Dec '24

25 Dec '24

Attention is currently required from: Anton Samsonov, Anton Samsonov, Nikolai Artemiev, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Anton Samsonov. ( https://review.coreboot.org/c/flashrom/+/85585?usp=email ) Change subject: flashchips: Add Spansion S25FS512S ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/85585?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I40b6c081ec7d57eac4f6d2b69cea3878bc92bb47 Gerrit-Change-Number: 85585 Gerrit-PatchSet: 3 Gerrit-Owner: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Comment-Date: Wed, 25 Dec 2024 06:16:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: Add Glasgow to supported serprog programmers documentation
by Anastasia Klimchuk (Code Review) 24 Dec '24

24 Dec '24

Anastasia Klimchuk has posted comments on this change by Cattus QQ. ( https://review.coreboot.org/c/flashrom/+/85527?usp=email ) Change subject: Add Glasgow to supported serprog programmers documentation ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: The doc change (once submitted) goes live on the website within a few hours. Should be in by the time for your Christmas :) You can watch this page: https://flashrom.org/supported_hw/supported_prog/serprog/overview.html -- To view, visit https://review.coreboot.org/c/flashrom/+/85527?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iabcec27dd675485c69875178858c604ce5c3da29 Gerrit-Change-Number: 85527 Gerrit-PatchSet: 3 Gerrit-Owner: Cattus QQ <cattusqq(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 24 Dec 2024 07:33:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: Add Glasgow to supported serprog programmers documentation
by Anastasia Klimchuk (Code Review) 24 Dec '24

24 Dec '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/85527?usp=email ) Change subject: Add Glasgow to supported serprog programmers documentation ...................................................................... Add Glasgow to supported serprog programmers documentation Updated the serprog overview page with info about the Glasgow Interface Explorer as a valid programmer. Wasn't able to test as the project wouldnt compile with meson for me (MacOS 15.1) but tried to make it as similar as possible to what was already there. Change-Id: Iabcec27dd675485c69875178858c604ce5c3da29 Signed-off-by: Cattus QQ <cattusqq(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/85527 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- A doc/supported_hw/supported_prog/serprog/300px-glasgow-in-case.png A doc/supported_hw/supported_prog/serprog/300px-glasgow-pcba.png M doc/supported_hw/supported_prog/serprog/overview.rst 3 files changed, 11 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Anastasia Klimchuk: Looks good to me, approved diff --git a/doc/supported_hw/supported_prog/serprog/300px-glasgow-in-case.png b/doc/supported_hw/supported_prog/serprog/300px-glasgow-in-case.png new file mode 100644 index 0000000..8630424 --- /dev/null +++ b/doc/supported_hw/supported_prog/serprog/300px-glasgow-in-case.png Binary files differ diff --git a/doc/supported_hw/supported_prog/serprog/300px-glasgow-pcba.png b/doc/supported_hw/supported_prog/serprog/300px-glasgow-pcba.png new file mode 100644 index 0000000..b06bb9f --- /dev/null +++ b/doc/supported_hw/supported_prog/serprog/300px-glasgow-pcba.png Binary files differ diff --git a/doc/supported_hw/supported_prog/serprog/overview.rst b/doc/supported_hw/supported_prog/serprog/overview.rst index ba01b02..995a694 100644 --- a/doc/supported_hw/supported_prog/serprog/overview.rst +++ b/doc/supported_hw/supported_prog/serprog/overview.rst @@ -93,3 +93,14 @@ `Riku_V's fork <https://codeberg.org/Riku_V/pico-serprog>`_ which uses the hardware SPI implementation instead of SPI over PIO (programmable IO) which sacrifices arbitrary pinouts. The fork also implements custom USB descriptors which allow for custom udev-rules. + +Glasgow Interface Explorer by Whitequark +======================================== + +.. image:: 300px-glasgow-in-case.png +.. image:: 300px-glasgow-pcba.png + +The Glasgow Interface Explorer is a tool for programming, debugging, and analysing digital electronics. +It is based on an FPGA and a microcontroller, and can be used as a serprog programmer. +Source for the Glasgow Project can be found here: `Glasgow Project Souce <https://github.com/GlasgowEmbedded/glasgow>`_. +For example use with Flashrom and serprog, see `this blog post <https://cattusqq.github.io/posts/Firmware_Dumping_with_SPI/>`_. \ No newline at end of file -- To view, visit https://review.coreboot.org/c/flashrom/+/85527?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iabcec27dd675485c69875178858c604ce5c3da29 Gerrit-Change-Number: 85527 Gerrit-PatchSet: 3 Gerrit-Owner: Cattus QQ <cattusqq(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in flashrom[main]: flashchips: Add Spansion S25FS512S
by Anton Samsonov (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Anastasia Klimchuk, Anton Samsonov, Nikolai Artemiev, Stefan Reinauer. Anton Samsonov has posted comments on this change by Anton Samsonov. ( https://review.coreboot.org/c/flashrom/+/85585?usp=email ) Change subject: flashchips: Add Spansion S25FS512S ...................................................................... Patch Set 3: (1 comment) File include/flashchips.h: https://review.coreboot.org/c/flashrom/+/85585/comment/bd479abf_5f312026?us… : PS2, Line 717: SPANSION_S25FS512S > > If you vote for the _UL suffix, then should S25FL512 also be changed to S25FL512S_UL simultaneousl […] Acknowledged -- To view, visit https://review.coreboot.org/c/flashrom/+/85585?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I40b6c081ec7d57eac4f6d2b69cea3878bc92bb47 Gerrit-Change-Number: 85585 Gerrit-PatchSet: 3 Gerrit-Owner: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Comment-Date: Mon, 23 Dec 2024 18:50:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anton Samsonov <avscomputing(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: flashchips: Add Spansion S25FS512S
by Anton Samsonov (Code Review) 23 Dec '24

23 Dec '24

Attention is currently required from: Anton Samsonov, Anton Samsonov, Nikolai Artemiev, Stefan Reinauer. Hello Anastasia Klimchuk, Anton Samsonov, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/85585?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: flashchips: Add Spansion S25FS512S ...................................................................... flashchips: Add Spansion S25FS512S Tested probe, read, erase, write on FS512SAIF01 chips using Linux SPI and DediProg SF100 programmers. This change affects S25FL512S identification as well, so that both chips can be unambiguously detected by probing. Datasheets used: * Infineon-S25FS512S_512_Mb_1-DataSheet-v16_00-EN.pdf at https://www.infineon.com/dgdl/?fileId=8ac78c8c7d0d8da4017d0ed681a356fe * Infineon-S25FL512S_512_Mb_64_MB_FL-S_Flash_SPI_Multi-I_O_3-DataSheet-v21_00-EN.pdf at https://www.infineon.com/dgdl/?fileId=8ac78c8c7d0d8da4017d0ed046ae4b53 Change-Id: I40b6c081ec7d57eac4f6d2b69cea3878bc92bb47 Signed-off-by: Anton Samsonov <devel(a)zxlab.ru> --- M flashchips/spansion.c M include/flashchips.h M s25f.c 3 files changed, 52 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/85/85585/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/85585?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I40b6c081ec7d57eac4f6d2b69cea3878bc92bb47 Gerrit-Change-Number: 85585 Gerrit-PatchSet: 3 Gerrit-Owner: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru>

1 0

[S] Change in flashrom[main]: doc: Add section about v1.5.1 into release notes
by Anastasia Klimchuk (Code Review) 22 Dec '24

22 Dec '24

Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/85698?usp=email ) Change subject: doc: Add section about v1.5.1 into release notes ...................................................................... doc: Add section about v1.5.1 into release notes Change-Id: Iea0a8a388d74f4e1ad7e9630413d4a5affc755fe Original-Change-Id: I80f8423133bf779093d57ea6928f09d9d377d20e Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Original-Reviewed-on: https://review.coreboot.org/c/flashrom/+/85655 Original-Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Original-Reviewed-by: Peter Marheine <pmarheine(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/flashrom/+/85698 Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M doc/release_notes/v_1_5.rst 1 file changed, 33 insertions(+), 6 deletions(-) Approvals: Matt DeVillier: Looks good to me, but someone else must approve build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved diff --git a/doc/release_notes/v_1_5.rst b/doc/release_notes/v_1_5.rst index 6fcfe33..a7c09d0 100644 --- a/doc/release_notes/v_1_5.rst +++ b/doc/release_notes/v_1_5.rst @@ -10,15 +10,42 @@ Download ======== -flashrom v1.5.0 can be downloaded in various ways: +flashrom v1.5 can be downloaded either via anonymous git at https://review.coreboot.org/flashrom.git, +or as signed source tarballs. -Anonymous checkout from the git repository at https://review.coreboot.org/flashrom.git -(tag v1.5.0) +The key fingerprint for source tarballs is -A tarball is available for download at https://download.flashrom.org/releases/flashrom-v1.5.0.tar.xz -(signature https://download.flashrom.org/releases/flashrom-v1.5.0.tar.xz.asc) +6E6E F9A0 BA47 8006 E277 6E4C C037 BB41 3134 D111 -fingerprint: 6E6E F9A0 BA47 8006 E277 6E4C C037 BB41 3134 D111 +Version v1.5.1 +--------------- + +Version 1.5.1 fixed an issue flashing some Intel-based platforms with the internal programmer +that was introduced in 1.5.0. +Users with older Intel-based platforms (Broadwell/Braswell and earlier) flashing using the internal +programmer option might encounter an 'Invalid OPCODE' error when erasing/writing which would lead to an +incomplete flash and potentially a bricked device. External flashing was not affected at all. + +All users are encouraged to update. + +Ticket: https://ticket.coreboot.org/issues/573 + +Patch: https://review.coreboot.org/c/flashrom/+/85612 + +Git tag: ``v1.5.1`` + +Tarball: https://download.flashrom.org/releases/flashrom-v1.5.1.tar.xz + +Signature: https://download.flashrom.org/releases/flashrom-v1.5.1.tar.xz.asc + +Version v1.5.0 +-------------- + +Git tag: ``v1.5.0`` + +Tarball: https://download.flashrom.org/releases/flashrom-v1.5.0.tar.xz + +Signature: https://download.flashrom.org/releases/flashrom-v1.5.0.tar.xz.asc Known issues ============ -- To view, visit https://review.coreboot.org/c/flashrom/+/85698?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iea0a8a388d74f4e1ad7e9630413d4a5affc755fe Gerrit-Change-Number: 85698 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in flashrom[main]: doc: Add section about v1.5.1 into release notes
by Stefan Reinauer (Code Review) 22 Dec '24

22 Dec '24

Attention is currently required from: Anastasia Klimchuk, Peter Marheine. Stefan Reinauer has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/85698?usp=email ) Change subject: doc: Add section about v1.5.1 into release notes ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/85698?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iea0a8a388d74f4e1ad7e9630413d4a5affc755fe Gerrit-Change-Number: 85698 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Sun, 22 Dec 2024 05:41:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: Add Glasgow to supported serprog programmers documentation
by Anastasia Klimchuk (Code Review) 21 Dec '24

21 Dec '24

Attention is currently required from: Cattus QQ. Anastasia Klimchuk has posted comments on this change by Cattus QQ. ( https://review.coreboot.org/c/flashrom/+/85527?usp=email ) Change subject: Add Glasgow to supported serprog programmers documentation ...................................................................... Patch Set 2: Code-Review+2 (6 comments) Patchset: PS1: > I'm not sure why this is happening. I followed step 6, in my 'https://review.coreboot. […] As of right now: your last patch update produced an email from "Cattus QQ", so you made it work, all good! :) PS1: > Thanks for being so nice Anastasia! You are very welcome! Commit Message: https://review.coreboot.org/c/flashrom/+/85527/comment/3ca4ff16_ca02b66f?us… : PS1, Line 10: the project wouldnt compile with meson for me (MacOS 15.1) > I will try again with these updates. So just to confirm: does flashrom compile for you? is it only documentation that does not? https://review.coreboot.org/c/flashrom/+/85527/comment/243a67ac_8d1bae8f?us… : PS1, Line 9: Updated the serprog overview page with info about the Glasgow Interface Explorer as a valid programmer. : Wasnt able to test as the project wouldnt compile with meson for me (MacOS 15.1) : but tried to make it as similar as possible to what was already there. > Apologies, will fix, thankyou! Done File doc/supported_hw/supported_prog/serprog/overview.rst: https://review.coreboot.org/c/flashrom/+/85527/comment/7eb9e0ff_71717b98?us… : PS1, Line 105: Source for the Glasgow Project can be found `here <https://github.com/GlasgowEmbedded/glasgow>`_ > This is my first time using rst and gerrit, sorry for all the newbie mistakes! […] The latest version does not produce any warnings, all good. I don't remember which "here" produced a warning, first or the second, but it doesn't really matter: as long as you know that the goal is not to have repeated link text. https://review.coreboot.org/c/flashrom/+/85527/comment/55e1a854_566ba879?us… : PS1, Line 108: 76hPuPkpDOTAxj7TegVqV8UkmKEjZ8TvLLBoDoVPpw > Yep that definitely shouldn't be there. Thanks. Done -- To view, visit https://review.coreboot.org/c/flashrom/+/85527?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Iabcec27dd675485c69875178858c604ce5c3da29 Gerrit-Change-Number: 85527 Gerrit-PatchSet: 2 Gerrit-Owner: Cattus QQ <cattusqq(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Cattus QQ <cattusqq(a)gmail.com> Gerrit-Comment-Date: Sat, 21 Dec 2024 12:32:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Cattus QQ <cattusqq(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: flashchips: Add Spansion S25FS512S
by Anastasia Klimchuk (Code Review) 21 Dec '24

21 Dec '24

Attention is currently required from: Anton Samsonov, Anton Samsonov, Nikolai Artemiev, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Anton Samsonov. ( https://review.coreboot.org/c/flashrom/+/85585?usp=email ) Change subject: flashchips: Add Spansion S25FS512S ...................................................................... Patch Set 2: (3 comments) File flashchips/spansion.c: https://review.coreboot.org/c/flashrom/+/85585/comment/a1a766e3_4533b4b1?us… : PS2, Line 1043: /* Note on FEATURE_4BA_ENTER: the command set only defines command 0xB7 : to enter 4BA mode, but there is no counterpart command "Exit 4BA mode", : and the code 0xE9 is assigned to another command ("Password unlock"). */ : /* Note on FEATURE_4BA_ENTER_EAR7 (not set): the "Extended address mode" bit : is stored in configuration register CR2V[7], which can only be read / written : by generic commands ("Read any register" / "Write any register"), that itself : expect a 3- or 4-byte address of register in question, which in turn depends on : the same register, that is initially set from non-volatile register CR2NV[7] : that defaults to 0, but can be programmed to 1 for starting in 32-bit mode. */ > That is not a "wisdom", but merely observations of trial and error in finding proper combination. […] You made trials and errors, and documented it: and this comment will be helping lots of other people who are reading it. This makes community stronger, I count this as wisdom! :) My first thought about commands from datasheet: you spent time implementing Evaluate Erase Status command, and then it turns out it doesn't work as promised. I would be reluctant to spend even more on another very special command: maybe it doesn't work either? A half of promised Blank Check During Erase functionality is already implemented in flashrom: checking whether bytes already have expected "erase value", and in this case nothing to do. About your WIP work, I can think of two options. One is: do nothing. Second one: create a WIP patch and make a post on the mailing list about it. Both options are fine, you can do any. File include/flashchips.h: https://review.coreboot.org/c/flashrom/+/85585/comment/b0a325c4_35b95f51?us… : PS2, Line 717: SPANSION_S25FS512S > If you vote for the _UL suffix, then should S25FL512 also be changed to S25FL512S_UL simultaneously, since this patch alters that macro anyway? Yes I like this idea, sorry I missed the bigger picture. Also because S25FL512 -> S25FL512S_UL now has long ID, it can go together with other log IDs (as the first one alphabetically). https://review.coreboot.org/c/flashrom/+/85585/comment/8a4da31a_76819d1e?us… : PS2, Line 717: 0x02200081 > > 03h -> ?? where it is? […] Thank you so much! Very useful explanation for me. -- To view, visit https://review.coreboot.org/c/flashrom/+/85585?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I40b6c081ec7d57eac4f6d2b69cea3878bc92bb47 Gerrit-Change-Number: 85585 Gerrit-PatchSet: 2 Gerrit-Owner: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anton Samsonov <avscomputing(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Attention: Anton Samsonov <devel(a)zxlab.ru> Gerrit-Comment-Date: Sat, 21 Dec 2024 09:04:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anton Samsonov <avscomputing(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit December 2024